queue: row 112 round 2 approvals and done (#1606, revs 1115-1117)

This commit is contained in:
2026-10-14 11:09:12 -05:00
parent cc48b124f1
commit 5b86abe47d
2 changed files with 93 additions and 11 deletions
+91 -9
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 1114,
"revision": 1117,
"rows": [
{
"id": 1,
@@ -10107,7 +10107,7 @@
"closes": [
1606
],
"state": "in-review",
"state": "done",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -10202,19 +10202,33 @@
}
],
"duplicateRisk": false,
"receipts": []
"receipts": [
{
"reviewer": "filbert",
"op": "filbert-112-r2",
"at": "2026-10-14T16:01:34.656Z",
"verdict": "approve",
"comment": 28383,
"candidate": "013c82c2fd99d23d92f6bed543a788aa04ff97b164019ccb15252ae808b4138e"
},
{
"reviewer": "sage",
"op": "sage-112-review-2",
"at": "2026-10-14T16:01:38.939Z",
"verdict": "approve",
"comment": 28384,
"candidate": "013c82c2fd99d23d92f6bed543a788aa04ff97b164019ccb15252ae808b4138e"
}
]
}
]
},
"claim": {
"seat": "darkwing",
"op": "darkwing-112-start-1"
},
"claim": null,
"note": "Round 1: Sage's recorded approve (rev 1106, comment 28377) is superseded by changes in comment 28378. The README invalid-options row misstates the shape cases: keys() refuses a malformed option invalid-request. The queue allows one verdict per round, so round 1 must not land; round 2 carries the README fix.",
"blockedReason": null,
"createdAt": "2026-10-14T15:36:36.626Z",
"updatedAt": "2026-10-14T16:00:14.974Z",
"updatedBy": "darkwing"
"updatedAt": "2026-10-14T16:08:37.716Z",
"updatedBy": "sage"
},
{
"id": 113,
@@ -39686,6 +39700,74 @@
"receipt": "ok darkwing-112-review-2.outcome rev 1114 row 112 round 2 request darkwing-112-review-2 posted comment 28382"
},
"viewSha": "8b3236ee2522961c4e65f18397e0f58ac3aa915af46e71597906009b7e6aa7ad"
},
{
"rev": 1115,
"op": "filbert-112-r2",
"verb": "review-record",
"args": {
"id": 112,
"verdict": "approve",
"comment": 28383,
"candidate": "013c82c2fd99d23d92f6bed543a788aa04ff97b164019ccb15252ae808b4138e"
},
"by": "filbert",
"at": "2026-10-14T16:01:34.656Z",
"semantics": 2,
"result": {
"row": 112,
"round": 2,
"verdict": "approve",
"receipt": "ok filbert-112-r2 rev 1115 row 112 round 2 approve by filbert (comment 28383)"
},
"viewSha": "f8af621d873e2db746f125092d3992eb942102eb63e102c8575c3a70c9660a3b"
},
{
"rev": 1116,
"op": "sage-112-review-2",
"verb": "review-record",
"args": {
"id": 112,
"verdict": "approve",
"comment": 28384,
"candidate": "013c82c2fd99d23d92f6bed543a788aa04ff97b164019ccb15252ae808b4138e"
},
"by": "sage",
"at": "2026-10-14T16:01:38.939Z",
"semantics": 2,
"result": {
"row": 112,
"round": 2,
"verdict": "approve",
"receipt": "ok sage-112-review-2 rev 1116 row 112 round 2 approve by sage (comment 28384)"
},
"viewSha": "f4d3aaae0b2c1ac8d045e85024458065ee9147cd8c4280ad4216b94eef4ca895"
},
{
"rev": 1117,
"op": "sage-112-done",
"verb": "move",
"args": {
"id": 112,
"to": "done",
"reason": null,
"candidate": null,
"evidence": null,
"issue": null
},
"by": "sage",
"at": "2026-10-14T16:08:37.716Z",
"semantics": 2,
"result": {
"row": 112,
"from": "in-review",
"to": "done",
"round": 2,
"issue": null,
"candidate": null,
"receipt": "ok sage-112-done rev 1117 row 112 in-review→done round 2"
},
"viewSha": "bc0b5b0d1796a1c813e3a8d7bb34b4318bee10f4d85dff72d47c5bf1debeb3df"
}
]
}