From 5c35a250de82f5d8a3057ec19d529400c67a17e7 Mon Sep 17 00:00:00 2001 From: fred Date: Sun, 16 Aug 2026 00:21:13 -0500 Subject: [PATCH] test(fleet): name what the pane-boundary case's binary check rides on (#1241) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Review finding from scooby. This case does not use run_start, so install_pane_binaries' symlinks land under a home its launcher never consults (HOME is the trusted parent here). It resolves mosaic and pi through MOSAIC_RUNTIME_BIN=$FAKE_BIN instead. Valid path, valid green — and a trap for anyone who later drops that env var believing the symlinks cover it, which would break the #1241 binary check rather than exercise it. Comment only; no behavior change. Harness rc=0. Refs #1241. --- .../framework/tools/fleet/test-start-agent-session.sh | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/mosaic/framework/tools/fleet/test-start-agent-session.sh b/packages/mosaic/framework/tools/fleet/test-start-agent-session.sh index eca95fdf..e7d8e94f 100755 --- a/packages/mosaic/framework/tools/fleet/test-start-agent-session.sh +++ b/packages/mosaic/framework/tools/fleet/test-start-agent-session.sh @@ -304,6 +304,13 @@ PANE_BASH_ENV="$ROOT/pane-boundary.bash-env" printf 'MOSAIC_RUNTIME_BIN=%s\n' "$FAKE_BIN" > \ "$HOME_PANE_BOUNDARY/fleet/agents/coder-pane-boundary.env.local" chmod 600 "$HOME_PANE_BOUNDARY/fleet/agents/coder-pane-boundary.env.local" +# This case does not go through run_start, so its pane binaries come from +# MOSAIC_RUNTIME_BIN=$FAKE_BIN in the env.local written above — not from the +# symlinks install_pane_binaries planted under the generated home, which this +# launcher never consults because HOME here is the trusted parent. That is a +# legitimate resolution path, but it means dropping MOSAIC_RUNTIME_BIN from +# this case on the belief that the symlinks cover it would break the #1241 +# binary check rather than exercise it. LD_PRELOAD='/not/loaded/by-clean-bootstrap.so' \ BASH_ENV="$PANE_BASH_ENV" \ MOSAIC_UNTRUSTED_SENTINEL='must-not-reach-pane' \