duckworth: row 206 r4 approve carries to 0cbe2e9b3 (duckworth-0196)
This commit is contained in:
1 parent
43c79fbcc5
commit
5e00522c73
2 files changed
+48
No files matched your search
@@ -0,0 +1,47 @@
|
||||
# Row 206 (193b2, #1704) round 4: slot rebase and gate on 0cbe2e9b3 (duckworth-0196)
|
||||
|
||||
Reviewer: Duckworth. Author: Launchpad. Request: launchpad-0045.
|
||||
Candidate: refactor 17f415792..0cbe2e9b35e51fe06dedde69c022b46e040f98c0, 10 commits, 22 paths.
|
||||
Earlier round: r3 670658dd1 on 3410df7c3 (duckworth-0179/0180).
|
||||
Method: git reads, plus the logs under /mnt/storage/scratch/launchpad-r206/runs/ that BUILD.md "Runs"
|
||||
names.
|
||||
|
||||
## Verdict: APPROVE carries to 0cbe2e9b3
|
||||
|
||||
## Rebase
|
||||
|
||||
- 17f415792 is an ancestor of the tip, and it equals local refactor and origin/refactor.
|
||||
- range-diff 3410df7c3..670658dd1 against 17f415792..0cbe2e9b3 shows `=` for all six r3 commits.
|
||||
Four commits are new: 829562260, 1a228f395 and 0cbe2e9b3 are BUILD.md only, and 9538e0fc8 is the
|
||||
test fix.
|
||||
- The path list is the same 22 paths. Per path, the row's +/- lines are byte-equal between rounds,
|
||||
except BUILD.md and thread-shares.test.mjs.
|
||||
- Drift 3410df7c3..17f415792 on manifest paths: only broker.mjs and sessions.test.mjs, as Launchpad
|
||||
says. The row's lines in both are unchanged.
|
||||
- SCHEMA_VERSION on refactor is '3l' (store.mjs:17), so 3l→3m stands. fixtures/schema-3l.sql has the
|
||||
same blob as refactor's packages/bus/schema.sql.
|
||||
|
||||
## 9538e0fc8 (mos-1272, sage-2960)
|
||||
|
||||
thread-shares.test.mjs:294 now reads `session` from session_defaults and doesn't use the thread id.
|
||||
That fits 264a's `message_threads_session` trigger (schema.sql:351-353), which refuses a session
|
||||
whose thread isn't NEW.thread. It changes one fixture insert in a test this row adds. No assertion
|
||||
or product line changes.
|
||||
|
||||
## Gate (logs read)
|
||||
|
||||
- The suites ran on 9538e0fc8 (suites summary `head 9538e0fc8`), and the tip differs only in
|
||||
BUILD.md.
|
||||
- bus 850/850 and cli 869/869. Both have 0 failed, 0 cancelled and 0 skipped.
|
||||
- The ten scripts/test-*.sh shells are all rc=0, with counts matching BUILD.md.
|
||||
- The skip lines are the test-queue canonical-root line and the two test-task live-provider lines.
|
||||
- thread-shares-fix1.log shows 16/16 with no `not ok`.
|
||||
- Mutants M2, M3, M4, M7, M8 and M9 and the Q2 probe:
|
||||
- Each diff is the single named edit, matching the r1 kill rules in REVIEW-manifest-631a256ba.md.
|
||||
- Each log fails only on ERR_ASSERTION, with no ERR_SQLITE.
|
||||
- The failing tests are the ones BUILD.md names.
|
||||
|
||||
## Notes (non-blocking)
|
||||
|
||||
- N1. 13 of the touched files ran on 1a228f395, before the fix. The fix changes only
|
||||
thread-shares.test, which reran whole on 9538e0fc8, so the counts hold.
|
||||
@@ -1518,3 +1518,4 @@ are never rewritten or removed; corrections are new entries.
|
||||
2026-10-22T18:25Z | Duckworth (Opus 5.5) | row 276 integration recheck 05af615fb on 94c33a43c (gander-0137) | static APPROVE carries, manifest 2af7e8ba; duckworth-0189 |
|
||||
2026-10-22T18:51Z | Duckworth (Opus 5.5) | row 239 r2 rebase check of 70c6e3772 (duckworth-0193) | clean, 0168 approve carries pending whole-file rerun |
|
||||
2026-10-22T18:51Z | Duckworth (Opus 5.5) | row 269 r3 manifest verdict on efcc9ea8d (duckworth-0194) | APPROVE, gate green, N1-N2 |
|
||||
2026-10-22T19:44Z | Duckworth (Opus 5.5) | row 206 r4 slot rebase and gate check on 0cbe2e9b3 (duckworth-0196) | APPROVE carries, N1 |
|
||||
Reference in new issue
Block a user