queue: revs 543-544, row 74 round 2 approvals, Filbert (543) and Darkwing comment 27486 (#1568) (darkwing)

This commit is contained in:
2026-10-11 18:31:41 -05:00
parent 3a2b051736
commit 5fbb681b7e
2 changed files with 64 additions and 5 deletions
+1 -1
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin --> <!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 542 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. Generated from `docs/plans/queue.json` revision 544 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note | | # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---| |---|---|---|---|---|---|---|---|---|
+63 -4
View File
@@ -1,7 +1,7 @@
{ {
"version": 1, "version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack", "canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 542, "revision": 544,
"rows": [ "rows": [
{ {
"id": 1, "id": 1,
@@ -5564,7 +5564,24 @@
} }
], ],
"duplicateRisk": false, "duplicateRisk": false,
"receipts": [] "receipts": [
{
"reviewer": "filbert",
"op": "filbert-74-review-2",
"at": "2026-10-11T23:30:33.046Z",
"verdict": "approve",
"comment": 27485,
"candidate": "17b6d7f62d106a23d99441eefa46e34ab2e9bd1442a1d02e219f126a82a8668d"
},
{
"reviewer": "darkwing",
"op": "darkwing-74-review-2",
"at": "2026-10-11T23:30:43.080Z",
"verdict": "approve",
"comment": 27486,
"candidate": "17b6d7f62d106a23d99441eefa46e34ab2e9bd1442a1d02e219f126a82a8668d"
}
]
} }
] ]
}, },
@@ -5575,8 +5592,8 @@
"note": "Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged.", "note": "Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged.",
"blockedReason": null, "blockedReason": null,
"createdAt": "2026-10-11T21:53:29.970Z", "createdAt": "2026-10-11T21:53:29.970Z",
"updatedAt": "2026-10-11T23:23:45.949Z", "updatedAt": "2026-10-11T23:30:43.080Z",
"updatedBy": "dewey" "updatedBy": "darkwing"
}, },
{ {
"id": 75, "id": 75,
@@ -20973,6 +20990,48 @@
"receipt": "ok dewey-74-review-r2-20261011.outcome rev 542 row 74 round 2 request dewey-74-review-r2-20261011 posted comment 27484" "receipt": "ok dewey-74-review-r2-20261011.outcome rev 542 row 74 round 2 request dewey-74-review-r2-20261011 posted comment 27484"
}, },
"viewSha": "539481b29d24811eca61c821cb7d69b56fa875efeb8eac09aa7a23ee90f80f34" "viewSha": "539481b29d24811eca61c821cb7d69b56fa875efeb8eac09aa7a23ee90f80f34"
},
{
"rev": 543,
"op": "filbert-74-review-2",
"verb": "review-record",
"args": {
"id": 74,
"verdict": "approve",
"comment": 27485,
"candidate": "17b6d7f62d106a23d99441eefa46e34ab2e9bd1442a1d02e219f126a82a8668d"
},
"by": "filbert",
"at": "2026-10-11T23:30:33.046Z",
"semantics": 2,
"result": {
"row": 74,
"round": 2,
"verdict": "approve",
"receipt": "ok filbert-74-review-2 rev 543 row 74 round 2 approve by filbert (comment 27485)"
},
"viewSha": "0ddf0a6118de9a6860bbf8a6aa848091818491c4340d68576189d521e1757c34"
},
{
"rev": 544,
"op": "darkwing-74-review-2",
"verb": "review-record",
"args": {
"id": 74,
"verdict": "approve",
"comment": 27486,
"candidate": "17b6d7f62d106a23d99441eefa46e34ab2e9bd1442a1d02e219f126a82a8668d"
},
"by": "darkwing",
"at": "2026-10-11T23:30:43.080Z",
"semantics": 2,
"result": {
"row": 74,
"round": 2,
"verdict": "approve",
"receipt": "ok darkwing-74-review-2 rev 544 row 74 round 2 approve by darkwing (comment 27486)"
},
"viewSha": "cb057e9cae582c579a67ad47f1e0d242ac30b4b56de4942fd005e0d1fe3b431e"
} }
] ]
} }