From 63c351b2843542603d068f1c4e6f18b293bb03e2 Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Fri, 23 Oct 2026 11:43:59 -0500 Subject: [PATCH] webby: row 308 PRD 1.17 round 1 approve; and session line --- agents/webby/work/queue-308/REVIEW-r1.md | 95 ++++++++++++++++++++++++ agents/webby/work/queue-308/apply-d9.py | 72 ++++++++++++++++++ docs/SESSIONS.md | 1 + 3 files changed, 168 insertions(+) create mode 100644 agents/webby/work/queue-308/REVIEW-r1.md create mode 100644 agents/webby/work/queue-308/apply-d9.py diff --git a/agents/webby/work/queue-308/REVIEW-r1.md b/agents/webby/work/queue-308/REVIEW-r1.md new file mode 100644 index 000000000..754389e81 --- /dev/null +++ b/agents/webby/work/queue-308/REVIEW-r1.md @@ -0,0 +1,95 @@ +# Row 308 round 1: PRD 1.17, Case 2 story files are DOCX + +Webby, 2026-10-23. Request: rev 3604/3605, Gitea comment 31223 on #1815 +(sage-3525, gosalyn-0200). Static review only. Scrooge held the slot, so I ran +no tests. + +- Candidate: 45fe7b3ce4fe4da997f3d4ff1dddf9fb4e46369d on gosalyn/prd-1-17-docx, + one commit on 4874d1e83. +- Approved text: agents/sage/work/prd-1-17/DRAFT-d9.md at 4607e15b8, sha256 + 02f28decad7f946f (checked). +- Base PRD: 4874d1e83 docs/prd/mosaic-stack.md is blob a6db9b4a1, the same blob + as 1.16 at 482e865ac. +- Brief: docs/plans/2026-10-23_prd-1-17-brief.md at e909ef51a. + +## Verdict: APPROVE + +## Files + +`git diff --stat 4874d1e83 45fe7b3ce` lists four files, the four the brief owns, +382 insertions and 54 deletions. The blobs match Gosalyn's list: +mosaic-stack.md 7d15d0c9a, requirements.json b47169e6b, tasks test 7c755f16c, +bus test f63fb92de. + +Drift: origin/refactor is now 9c8877bdf (row 306 landed). None of the 9 files +changed in 4874d1e83..9c8877bdf is a manifest path. + +## PRD, instruction by instruction + +I wrote my own applier rather than reuse Gosalyn's (apply-d9.py, beside this +file). It parses d9's "Text changes" section from 4607e15b8 and applies each +instruction to the 1.16 text with whitespace flattened. Every old quote must +occur exactly once: in the whole document, or inside REQ-LIB-2 for the scoped +Console sentence, or inside REQ-LIB-1 for "(Design 1.1". All 24 operations +passed that check: + +1. Status "version 1.16." becomes "version 1.17." +2. The 1.17 Status sentences go after "(mos-1328, mos-1329).", which ends the + Status bullet (base :50). +3. The "Version 1.17 source:" bullet goes above "- Version 1.16 source:". +4. The Creative library lead sentence is replaced. +5. REQ-LIB-1: the archive sentences go before "(Design 1.1", and the tag. +6. REQ-LIB-2: the scope paragraph, lookups, "so an agent can't cite", the + Console sentence scoped to REQ-LIB-2, and the tag. +7. REQ-LIB-4: replace, add after "Bus writes and pushes...", replace, and the tag. +8. REQ-LIB-5: add after "Each answer names the commit it read.", replace, and the + tag with Q239. +9. REQ-LIB-6: replace, add after "the broker refuses such a write before any git + call.", and the tag. +10. REQ-LIB-8 and REQ-LIB-9 go before "### Installer". +11. The 1.17 notes go before "## Risks and open questions", that is, after the + 1.16 notes. +12. The four risks go before "## Milestones", after the "Trusted mode" bullet. + +The result equals the candidate PRD with whitespace flattened. So no word +changes beyond d9, and none of d9's review sections went in. + +Structure, which flattening can't see: + +- The three inserted blocks are line-for-line identical to d9's quoted text, + once d9's outer quote marks are removed: REQ-LIB-8/9 (cand :1400-1503), the + notes (:1985-2087) and the risks (:2126-2145). Blank lines around + "### Installer", "## Risks and open questions" and "## Milestones" are intact. +- Edited hunks add or remove no list markers. The one extra top-level "- " is the + 1.17 source bullet, as intended. +- Every added line in the edited bullets (cand :1-1399) is at most 74 columns. +- The tasks test's guard on bold ids holds: 87 bullets and 87 `**REQ-` strings + in the candidate. + +## requirements.json and pins + +- Version 1.17. 87 ids, all unique, equal to the PRD bullet ids in order. + REQ-LIB-8 and REQ-LIB-9 sit between REQ-LIB-7 and REQ-INST-1. +- The REQ-LIB-1, -2, -4, -8 and -9 titles each occur verbatim, in single quotes, + in d9's flattened requirements.json note. REQ-LIB-5 and -6 are unchanged. +- Title lengths are 120, 116, 117, 113 and 114. requirements.mjs:33 allows + `str(r.title, 120)`, which is `length <= max`, so 120 passes. +- tasks requirements.test.mjs: 87 (:21), '1.17' (:24), `requirements[87].id: + REQ-ROLE-1 twice` (:77). bus requirements.test.mjs:48 pins 87. Each is a + one-line change. +- Other readers: broker.mjs:480 and verbs.mjs:68 load the list, and verbs.test + uses requirements[0] and .at(-1), whose ids don't change. stack-copy.test:52 + only checks that the file exists. No test pins a hash of either file. + +## Notes + +- N1, no change needed. The inserted blocks keep d9's own wrap, up to 82 + columns, which is the width rounds 6-8 checked. The edited bullets wrap at 74. + The 1.16 PRD already has lines up to 176 columns, and no test reads the width. + So the mixed width is harmless. A later doc pass could rewrap it if anyone + cares. + +## Gate left to Sage + +Tasks and bus run whole, cli stack-copy.test.mjs, and every scripts/test-*.sh +under `timeout -k 10`, on CLEAR. After that, Mos gets the landing commit. diff --git a/agents/webby/work/queue-308/apply-d9.py b/agents/webby/work/queue-308/apply-d9.py new file mode 100644 index 000000000..dfe6888cb --- /dev/null +++ b/agents/webby/work/queue-308/apply-d9.py @@ -0,0 +1,72 @@ +import re,sys +D=sys.argv[1] +fl=lambda s:re.sub(r'\s+',' ',s).strip() +base=fl(open(D+'/base.md').read()); cand=fl(open(D+'/cand.md').read()) +d9=open(D+'/d9.md').read().split('\n') +sec=fl # helper +lines=d9[56:475] # Text changes .. before d9 changes +paras=[];cur=[] +for l in lines: + if l.strip()=='' or l.startswith('#'): + if cur: paras.append(' '.join(cur)); cur=[] + if l.startswith('#'): paras.append(l) + else: cur.append(l) +if cur: paras.append(' '.join(cur)) +t=base; log=[] +def once(old): + n=t.count(old); return n +def rep(old,new,scope=None): + global t + if scope: + a=t.index(scope[0]); b=t.index(scope[1],a) + seg=t[a:b]; assert seg.count(old)==1,(old,seg.count(old)) + t=t[:a]+seg.replace(old,new)+t[b:]; log.append(('scoped',old[:50])); return + n=t.count(old); assert n==1,(n,old[:80]); t=t.replace(old,new); log.append(('rep',old[:50])) +P=[fl(p) for p in paras] +def find(prefix): + r=[p for p in P if p.startswith(prefix)]; assert len(r)==1,(prefix,len(r)); return r[0] +# Status +p=find('In the Status bullet') +m=re.match(r'In the Status bullet\'s first line, "(.+?)" becomes "(.+?)" Status gains, after the two 1.16 sentences at the end of the bullet: "(.+)"$',p); assert m +rep(m[1],m[2]); rep('(mos-1328, mos-1329).','(mos-1328, mos-1329). '+m[3]) +p=find('New source line'); m=re.match(r'New source line, above the 1.16 one: "(.+)"$',p); assert m +rep('- Version 1.16 source:','- '+m[1]+' - Version 1.16 source:') +for p in P: + if p.startswith('#') or p.startswith('In the Status') or p.startswith('New source'): continue + for m in re.finditer(r'(?:In REQ-LIB-2 only, replace|Replace) "(.+?)" with "(.+?)"(?=\.?$| Add| Version tag|\.? Replace)',p): + if p.startswith('In REQ-LIB-2 only'): + rep(m[1],m[2],scope=('**REQ-LIB-2.**','**REQ-LIB-3.**')) + else: + # Replace quote ends with '.', new text quoted with trailing ." + rep(m[1],m[2]) + for m in re.finditer(r'Add, after "(.+?)": "(.+?)"(?=$| Version tag)',p): + rep(m[1],m[1]+' '+m[2]) + for m in re.finditer(r'Add, before "(.+?)": "(.+?)"(?= Version tag|$)',p): + a=t.index('**REQ-LIB-1.**'); b=t.index('**REQ-LIB-2.**') + seg=t[a:b]; assert seg.count(m[1])==1; t=t[:a]+seg.replace(m[1],m[2]+' '+m[1])+t[b:]; log.append(('before',m[1])) + for m in re.finditer(r'Version tag(?:, inside the closing parenthesis)?: (["\'])(.+?)\1 becomes \1(.+?)\1$',p): + rep(m[2],m[3]) +for i,p in enumerate(P): + m=re.match(r'Replace "(.+)" with:$',p) + if m: + q=P[i+1]; assert q[0]=='"' and q[-1]=='"'; rep(m[1],q[1:-1]) +# New bullets: paragraphs after the "### New REQ-LIB-8" heading +txt='\n'.join(lines) +def block(h1,h2): + s=txt.index(h1); e=txt.index(h2,s); return txt[s:e] +def quoted(b): + s=b.index('"- '); e=b.rindex('"'); return fl(b[s+1:e]) +l8=quoted(block('### New REQ-LIB-8','### New REQ-LIB-9')); l9=quoted(block('### New REQ-LIB-9','### Version 1.17 notes')) +rep('### Installer',l8+' '+l9+' ### Installer') +nt=quoted(block('### Version 1.17 notes','### Risks')) +rep('## Risks and open questions',nt+' ## Risks and open questions') +rb=txt[txt.index('### Risks'):txt.index('## d9 changes')] +risks=[fl(x) for x in re.findall(r'^- "(.*?)"$',rb,flags=re.S|re.M)] +rb2=rb[rb.index('\n- "'):] +items=re.split(r'\n- "',rb2)[1:]; items=['- '+fl(i.rstrip().rstrip('"')) for i in items] +rep('## Milestones',' '.join(items)+' ## Milestones') +print(len(log),'ops'); +for x in log: print(x) +print('EQUAL' if t==cand else 'DIFF') +if t!=cand: + i=next(i for i in range(min(len(t),len(cand))) if t[i]!=cand[i]); print(repr(t[i-200:i+200])); print(repr(cand[i-200:i+200])) diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 5b30d5c50..3b54e94f5 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1519,3 +1519,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-23T15:37Z | Webby (Opus 5.5, reviewer seat) | PRD 1.17 draft d9 r2 round 7 review (sage-3502, 8b4201055) | APPROVE; B1 met (R3.1-3.3, 3.5 verbatim), N19/N20 met, N21 to Mos 2026-10-23T15:39Z | Webby (Opus 5.5, reviewer seat) | row 252 early static read on b0d8ac6c8 (sage-3502) | J11c and J18 equivalent, J19 killer pins config and owner-only, J16 config accepted, old tests 1 1 x3; formal round on the post-306 rebase 2026-10-23T15:41Z | Webby (Opus 5.5, reviewer seat) | PRD 1.17 d9 r3 round 8 on 4607e15b8 (sage-3505, mos-1470 edits only) | APPROVE; N20/N21 edits as relayed, widths <82, d8-to-d9.diff matches +2026-10-23T16:43Z | Webby (Opus 5.5, reviewer seat) | row 308 round 1, PRD 1.17 on 45fe7b3ce (sage-3525, gosalyn-0200) | APPROVE: own d9 applier equals the PRD flattened, inserted blocks line-identical, 87 ids, pins 87/1.17; N1 wrap width only; static, no runs