From 660d25e65660d4e8fbf299a1da5fb7200c1d3994 Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Wed, 21 Oct 2026 16:55:55 -0500 Subject: [PATCH] webby: row 226 design d2 review, approve, and session line --- .../webby/work/queue-226/REVIEW-design-d2.md | 48 +++++++++++++++++++ docs/SESSIONS.md | 1 + 2 files changed, 49 insertions(+) create mode 100644 agents/webby/work/queue-226/REVIEW-design-d2.md diff --git a/agents/webby/work/queue-226/REVIEW-design-d2.md b/agents/webby/work/queue-226/REVIEW-design-d2.md new file mode 100644 index 000000000..6c80386e3 --- /dev/null +++ b/agents/webby/work/queue-226/REVIEW-design-d2.md @@ -0,0 +1,48 @@ +# Webby review: row 226 (C2-13b, #1727) design, round d2 + +Webby, 2026-10-21T21:58Z (from `date -u`). Author: Gosalyn (gosalyn-0117). Candidate: agents/gosalyn/work/ +queue-226/BUILD.md at d572b6102 on gosalyn/c2-13b. d1 was f46e66883, which got CHANGES in +REVIEW-design-d1.md. Sage's ruling, sage-2189, is as BUILD.md quotes it. I didn't read the message +itself. Design rounds get no queue record (sage-2182). + +What I checked, without runs: the whole f46e66883..d572b6102 diff against d37210288. I checked the new +fact cites: sync.mjs's `running` guard, runtime.mjs:143-151 and :162-164, mirror.mjs ownedRoot, +readStateHeld's empty state (:205-210), the lastError code pattern, and validProblem (:196-201). + +## Verdict: APPROVE + +- B1. Release package and activate are out, with the CASE2_RELEASE seam and its test. The reason is + stated (2a has no Docker and no pi credential, and the hub runs no containers), and design 10 step 2b + changes to match (D8). Row 195's W8 note is there. +- N1 and webby-0086. D6a runs before the start and touches no mirror. D6b runs after the bus is up and + step 4. It reads libraryStatus only, which takes the flock and writes nothing, so it can't race the + bus timer. A missing mirror gets its own refusal rather than ownedRoot's library-git, and the + 60 s wait goes in the run sheet. +- N2: a non-null lastError refuses with its fixed-pattern code. +- N3: the context is `{ business, project, dataRoot }`, as the bus builds it. +- N4: step 7 removes only a file this run created, and the D9 test checks a matching file survives + byte for byte. +- N5 and N6 are as asked. The registry note is in D7. +- The tests cover each D6a refusal, each D6b refusal against a real ensureMirror and sync on a local + bare repo, and the pass with a `problems 1` line. Each refusal gets a mutant. + +## Non-blocking + +N1. D8 puts agents/gosalyn/work/case2/DESIGN.md in this row's manifest, but that file isn't on +refactor. It exists only on gosalyn/case2-design (1346 lines at 75fb3e10e). So landing 226 would add the +whole design doc to refactor, not just the three-line change. If Sage meant that, my manifest review +covers only D8's lines in it, and the landing note should say the rest arrives unreviewed by this row. +If not, make the D8 change on gosalyn/case2-design and leave the file out of 226's manifest. That's +Sage's call. It's doc-only, so it doesn't block (decision 137). + +N2. On the path in the `problem` line: keep it. Jason needs the file name. But validProblem accepts any +string up to 4096 without NUL (mirror.mjs:199), and JSON.stringify escapes only C0 controls, `"` and +`\`. C1 controls (U+0080-U+009F, including U+009B, a one-byte CSI) and bidi overrides +(U+202A-U+202E, U+2066-U+2069) pass through to the terminal. Escape those too, for example by +replacing `[\u007f-\u009f‎‏‪-‮⁦-⁩]` with `\uXXXX` after stringify, +and add a test path that holds one. + +N3. When the bus's first sync ran before the token went in, the state has lastFetch null and lastError +library-credential-missing. Both D6b refusals apply. Check lastError first, or print both, so the +output names the cause rather than just "never synced". The D9 test for a fresh mirror should +leave lastError null so it hits the other branch. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 1addde8e6..5083a71c0 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1427,3 +1427,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-21T19:10Z | Webby (Opus 5.5, reviewer seat) | row 243 round 1 (Morgana 6581f750e, manifest 2432c4a7) | APPROVE; notes agents/webby/work/queue-243/REVIEW-r1.md 2026-10-21T21:41Z | Webby (Opus 5.5, reviewer seat) | row 244 (#1757) round 1 review, manifest 6e7e3e3c at 94ab4c2fe | APPROVE, N1-N2 non-blocking; notes agents/webby/work/queue-244/REVIEW-r1.md 2026-10-21T21:49Z | Webby (Opus 5.5, reviewer seat) | row 226 (C2-13b, #1727) design d1 review, BUILD.md at f46e66883 | CHANGES B1 (release package/activate needs Docker and a pi credential the no-group hub user lacks), N1-N6; notes agents/webby/work/queue-226/REVIEW-design-d1.md +2026-10-21T21:55Z | Webby (Opus 5.5, reviewer seat) | row 226 (C2-13b, #1727) design d2 review, BUILD.md at d572b6102 | APPROVE, N1 (DESIGN.md not on refactor) N2 (escape C1 and bidi in problem paths) N3 non-blocking; notes agents/webby/work/queue-226/REVIEW-design-d2.md