duckworth: row 253 integration read (duckworth-0132) no blockers on Gander d213ef651 (72a70e99)

This commit is contained in:
jason.woltje committed 2026-10-22 07:49:47 -05:00
1 parent 7045b17bf9
commit 6d1121bf4c
2 files changed
+37

No files matched your search

@@ -0,0 +1,36 @@
# Row 253 (#1758) integration read onto 385a7194c (duckworth-0132)
- Reviewer: Duckworth (Opus 5.5), 2026-10-22.
- Request: gander-0098 (12:47Z), sage-2659.
- Candidate: gander/row253-385a, tip d213ef651, source 141b79c29, base 385a7194c. The branch is local and unpublished. I read it through the shared object store.
- Manifest: MANIFEST.sha256 at d213ef651, 7 paths, digest 72a70e99ba0416ce.
- Method: git reads and python3 -B -I on one git blob. Nothing ran.
## Verdict: no blockers. 0116's approval of 8de88458d carries to 141b79c29. The gate still runs on the final base Sage names.
## Checks
- **Range-diff.** 0fa7bf421..8de88458d against 385a7194c..141b79c29 shows 8 of 10 pairs as `=`. Pairs 1 and 6 differ only in BUILD-LOG.md context lines. No commit in 385a7194c..d213ef651 has a Co-Authored-By trailer.
- **Product diff.** `git diff 0fa7bf421 8de88458d` and `git diff 385a7194c 141b79c29`, both without BUILD-LOG.md and agents/gander, differ only in index lines and the DEFERRED hunk offset (:452 to :531). The changed code is byte-for-byte the same.
- **Manifest.** The file hashes to 72a70e99, and all 7 lines match their blobs at d213ef651. Against 8de88458d's manifest, only DEFERRED and README changed. The two host scripts, the two tests and the sudo fixture are identical.
- **Commit 11 (d213ef651).** It touches only agents/gander/work/queue-253: the integration packet, the manifest record, SHELL-LIMITS.json, driver.py and window.py.
- driver.py:36 flags exit codes 124 and 137 as a timeout, and a timed-out mutant now has the outcome `timeout`, not `killed`. A node run killed by SIGKILL for any other reason is also flagged and stops the window, so the error is on the side of stopping.
- window.py wraps each scripts/test-*.sh in `timeout -k 10 LIMIT`, and the outer wait is LIMIT+30. step() stops the window on any timeout (window.py:45-46).
- SHELL-LIMITS.json computes each limit as ceil(3 × longest) + 120. The values I could check from receipts I've seen agree: foundation 39.9 s gives 240, task 36.8 s gives 231 and queue 23.4 s gives 191. All ten scripts have a limit, and each is at least 3x (mos-1275).
- **What 278 changed under 253.** Gander's reading holds. The focused tests write their own cli.mjs and config.mjs stand-ins, so 278's real Console modules reach them only through the whole webui run.
## The 264a dependency
Gander is right that a seven-path check isn't enough on its own, because case1 and case2 import cli/tests/helpers.mjs, which loads Store, and Store reads schema.sql and the migrations at load time. Statically, against 264a r9 (385a7194c..25db3621f):
- None of the 253 files names 3k, 3l, schema.sql, migrations, thread_claims or a 64-hex pin. The `sessions` hits in case-sudo-fixture.mjs and case2-unit.test are Unix process sessions, not the bus table.
- 264a's path set includes scripts/stack-release.sh. Among 253's files, only a comment (case1-accept.sh:466) names it.
- 264a doesn't touch helpers.mjs, case2-precheck.sh or seat/src/sandbox.mjs.
So 264a's schema step reaches 253 only through Store loading at import time. A gate on a base with 264a landed tests exactly that. If 264a lands first, the next integration needs the same range-diff and manifest check, not a new design read.
## Conditions for the gate
- C1. The gate runs on the integration of the base Sage names at CLEAR. The log prints HEAD and the manifest digest check first.
- C2. 0116's conditions stand, including N9: name the sandbox test's skip exactly, if it skips.
- C3. If 264a has landed, the focused case1 and case2 files run whole on that base, along with the whole cli suite, which includes T46.