diff --git a/agents/webby/work/queue-197/REVIEW-manifest.md b/agents/webby/work/queue-197/REVIEW-manifest.md new file mode 100644 index 000000000..2aa4c5af7 --- /dev/null +++ b/agents/webby/work/queue-197/REVIEW-manifest.md @@ -0,0 +1,34 @@ +# Webby review: row 197 manifest (#1695) + +Webby, 2026-10-20T19:39Z (from `date -u`). Author: Herb. Subjects on herb/row197: `MANIFEST.md` at 84f21923c, +sha256 16768433...b23b, and `TIMING.md` at fa820fed6, sha256 148a1416...52bd (both verified). TIMING's commit +sits on top of the manifest's. I read both whole, against DESIGN.md at 6ad25d745 (my r2 APPROVE) and the base +aa1bd209e. Static review. I ran nothing. + +## Verdict: CHANGES + +T1-T5 cover the design. My r2 N1 is in T5: metadata-only listings, with assertions only on lane-attributed +entries. TIMING.md copies Sage's table and says what it is not: a controlled solo baseline. The 25 values sum +to 659 s, as stated. + +## Blocker + +B1. Drop the dead Board `:9` replacements from P2. Port 9 is not a resource the two lanes share. On this host +`net.ipv4.ip_unprivileged_port_start` is 1024, so no test, lane or seat can bind 127.0.0.1:9. A connection +there is refused at once in both lanes. Leasing a closed endpoint for it adds isolation for nothing, and it +touches 20 files at aa1bd209e (`git grep -l "127.0.0.1:9'"`: 17 under webui/tests plus stack-copy, +launch-routes and bus tasks). I approved R9 in the design. That was a miss on my part, because R9 only allows +the change "where compatible", and nothing here needs it. +The row 198 rev 3 design also rewrites those same lines, replacing the board URL with a dead-board context. +Whichever row lands second would redo the other's edit. +Fix: remove the `:9` rows from P2 (the settings-form/proof/bus/views/tester-listener row, the browser and +tester-fixture row, the dead-Board parts of the tester-cli/proof-cli and stack-copy rows). Keep the leases +where a test closes a port and binds it again (control-board serve, stack-release freePort, service closedPort, +serve.test :100 if it rebinds). Add a T1 preflight refusal for a listener on 127.0.0.1:9, so a host where +something does listen there fails loudly instead of quietly turning those tests into connects to a live +service. + +## Non-blocking + +N1. Tell Sage that row 198 edits `stack-copy.test.mjs`, `pinned-copy.test.mjs` and the webui serve/preview tests +too. Even with B1, those are the files where the two rows meet. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 89f86a4ed..3cf5c1aeb 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1370,3 +1370,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-20T19:31:52Z | Webby (Opus 5.5, reviewer seat) | row 194 design r2 re-review for Honker (#1692, DESIGN.md 313c206e and PRD-1.7-DRAFT.md 98f4f49e at c0a35f47a), static | changes: B1 hire floor is a deny list that misses git.merge.protected (merge-gate.json, no credentials), decision.resolve.technical, policy.change, prd.approve, instance.name; make it an allowlist. r1 B1, B3-B8, Q2, N1-N8 fixed; Q4 view: start empty; notes agents/webby/work/queue-194/REVIEW-r2.md 2026-10-20T19:33:02Z | Webby (Opus 5.5, reviewer seat) | row 194 design r3 review for Honker (#1692, DESIGN.md 885fce0d and PRD-1.7-DRAFT.md 04c32917 at d0afda024), static | changes: r2 B1 stands except instance.name (allowlist); B2 fire delist and claim revoke can't share a transaction, name order and recovery; N1 REQ-LAND-2 relies on Gitea refusal, N2 recheck by start time; notes agents/webby/work/queue-194/REVIEW-r3.md 2026-10-20T19:36:19Z | Webby (Opus 5.5, reviewer seat) | row 198 design rev 3 re-review for Bushroot (#1696, DESIGN.md 51343813 at 7e2ead7f3), static | changes: rev 1 B1-B3 and N1-N5 fixed, sage-1372 rulings read right; new B1 in-process board runs spawnSync tmux (5 s per seat) and agent-send (15 s) in the Console event loop, make createBoard async with a stall test and mutant; N1 decision 8 fallback sentences, N2 --board support check must not match a refusal; notes agents/webby/work/queue-198/REVIEW-r3.md +2026-10-20T19:37:29Z | Webby (Opus 5.5, reviewer seat) | row 197 manifest review for Herb (#1695, MANIFEST.md 16768433 at 84f21923c, TIMING.md 148a1416 at fa820fed6), static | changes: B1 drop dead Board :9 replacements (port below unprivileged floor 1024, not shared by lanes, 20 files, collides with row 198), add a :9 listener preflight refusal; N1 row 198 overlap for Sage; notes agents/webby/work/queue-197/REVIEW-manifest.md