Record #780 R2 and correct the R1 entry in BUILD-LOG and SESSIONS (Vikunja #780)

Appends a BUILD-LOG entry that corrects the R1 entry without editing it: the
R1 walk change also dropped the recursive lstat, which R2 restores; the
tester-cli freePort helper has no callers and binds nothing; the stack-release
and control-board probe-then-bind window stays a known risk for a follow-up.
Appends one SESSIONS line.
This commit is contained in:
jason.woltje committed 2026-11-02 18:57:39 -06:00
1 parent 1977f4ffc6
commit 728442fcef
2 files changed
+17

No files matched your search

+15
View File
@@ -5919,3 +5919,18 @@ sync, mirror, case2-install 69/0/0; read.test.mjs 10 of 10 green. No hash or siz
restored by git checkout with a clean status: closed lease probes and closes again, and holder released immediately, each
killed by three gate-lane-fixtures tests; leasePort accepts closed again, killed by its refusal test; inspectGit mapping
removed, killed by the read.test.mjs vanished-entry test.
## 2026-11-03, Vikunja #780 R2: fresh recursive lstat restored; corrections to the R1 entry above
- The R1 walk change was broader than the ENOENT mapping. Passing the parent's stat into the recursive walk dropped the
fresh lstat at recursive entry: a directory replaced by a symlink after its listed stat passed the stale check and
readdirSync read through the link; one replaced by a regular file leaked a raw ENOTDIR (GPT review P2).
- The tester-cli freePort helper (packages/webui/tests/tester-cli.test.mjs:21) has no callers and binds nothing; the
active tester CLI test uses a private Unix socket. R1 wrongly counted it among the callers that listen themselves.
- stack-release.test.mjs:2051 and control-board serve.test.mjs:78 still probe, close, then bind: a known risk, and
the lead files a follow-up.
R2, code 1977f4ffc, not pushed: walk(directory, root) stats with root ? lstatSync : statEntry and recurses walk(path),
the reviewer's control shape; .git keeps its raw lstat, the mapper stays ENOENT only. Two read.test.mjs tests swap a
.git/objects directory, inside its listed lstat after the real stat, for a symlink to a fixture-only outside directory
or a file; both refuse "expected local .git directory", and were red on 9944100ad (symlink resolved, raw ENOTDIR).
Mutant walk(path, entry) using the passed stat: killed by both. project 44/0/0; read.test.mjs alone 11/0/0 5 of 5.
+2
View File
@@ -1959,3 +1959,5 @@ are never rewritten or removed; corrections are new entries.
2026-11-02 | Lead (Claude Opus 5.5, T3 c5c1e8ba) | PR 1838 (#725) landing: disk-space governance PRD as version 1.19 | Merge 31222d81d of the Haiku rebase 3d00efe39 onto ea02c061e; GPT review APPROVE, P3s fixed here: approved wording in the tasks requirements test header, location correction in REBASE-1.19.md. Full gate before push.
2026-11-02 | Lead sub-agent (Claude Sonnet 5.5, under T3 c5c1e8ba) | Vikunja #780 and #781: project inspectGit race with git maintenance, closed fixture ports | Code 7e0d3c93f (#780) and 1009bbfaf (#781) on t3/fix-flakes-780-781: both flakes made deterministic, pin tests added, three mutants plus one extra each killed and restored, project, webui, control-board, stack-release and lane fixture suites green, read.test.mjs 10 of 10. Not pushed; record in BUILD-LOG.md.
2026-11-03 | Lead sub-agent (Claude Opus 5.5, under T3 c5c1e8ba) | Vikunja #780 R2: restore the fresh recursive lstat in project inspectGit | Code 1977f4ffc on t3/flakes-780-781-r2-fix: symlink and file replacement tests red on 9944100ad and green now, stale-stat mutant killed by both, project 44/0/0, read.test.mjs 5 of 5. BUILD-LOG entry corrects the R1 walk and tester-cli descriptions. Not pushed.