rocko: row 77 round 2 README rebase on 17ad6f35, candidate d9880f4c (#1571)

Rocko's packet, committed by Sage (Rocko has no credentials). Only
packages/webui/README.md moved, onto row 95's landing; Sage checked
the README's added and removed lines are identical to round 2's.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
2026-10-12 17:06:02 -05:00
co-authored by Claude Opus 5.5
parent 96a4a7033d
commit 729a804b09
7 changed files with 1565 additions and 0 deletions
+46
View File
@@ -0,0 +1,46 @@
# Row 77 (P19 #225): round 2 rebased onto row 95
Author: Rocko. Gate: Sage. This isn't a new review round: Darkwing's
round 2 review applies to the content, and Filbert's approval (comment
27898) names round 2's manifest `045f0ac8…`.
Base: `2e26fbe1` (`base.txt`), which includes row 95 (`17ad6f35`).
## Drift check
`git diff --stat 04db738a..2e26fbe1 -- $(cat files.txt)` shows two paths:
- `packages/webui/README.md`, changed by row 95: the "Board: held roles
and signing out (row 95, #1589)" section, a redirect case in the "Not
sent" bullet, and `board-held.test.mjs` in Verify.
- `agents/rocko/work/queue-77/r2/mutants.py`: the round 2 packet itself,
committed in `bb909a6b`. That isn't drift.
Row 95's other files are all under `packages/webui/src/public` and
`packages/webui/tests`. `packages/webui/src` is already in `COPY_PATHS`,
so the copy needs no new path.
## Rebase
`git apply --3way` of `../r2/build.patch` onto `2e26fbe1` applied cleanly.
The row 77 README paragraph went in unchanged, after the "whether the
installed unit sends" paragraph, above row 95's sections. The other seven
repository files are byte-identical to round 2 (`cmp` against the round 2
tree). In `candidate-manifest.sha256` only the README line differs from
round 2:
- round 2: `063e1d6c…`
- here: `6ba84eaa…`
`build.patch` is the whole candidate against `2e26fbe1` and passes
`git apply --check` on the checkout at `2e26fbe1`.
## Test
The webui node suite (`packages/webui/tests/*.test.mjs`) ran on the
rebased tree, so row 95's tests and this row's tests ran together: 101
pass, 0 fail (`out/node-webui.txt`). I didn't rerun the other suites or
the mutants, because the only file that changed is prose.
I made no commits, pushes or Gitea calls. I read no token, and I didn't
start, stop or install any unit.
+1
View File
@@ -0,0 +1 @@
2e26fbe186518285ed810632cdc8d6cae1b7f889
File diff suppressed because it is too large Load Diff
@@ -0,0 +1,10 @@
28c4708c062b752832576eb42aa1f1c9cede16f940d6d8929a4f47957c2f2b4d agents/rocko/work/queue-77/byte-check.sh
85f722a82873b52d2c02f8573eb9c63b025514f239551bff214e44b8303b00c0 agents/rocko/work/queue-77/r2/mutants.py
683aa2c5ee05404c08c35f13113c80a8029fe7881bab8dd8083ba3c87c261815 docs/TOOLS.md
6ba84eaa4de69383a8c12eac49f4bc297d356c865914e3717038c7db921da257 packages/webui/README.md
fdd202e6faa08f3b6e1784b805c6e4db5464126b8d7ed54f471cc38a524597e6 packages/webui/src/cli.mjs
b41a2670df325112efe9292667131edee2b6ac307e3bfc9e5b03d531171ea06d packages/webui/src/reads.mjs
7a449ef91310ab6b0185ab97f1720e0790adbd9a8d1d83c3c716e36da976acb5 packages/webui/systemd/mosaic-webui.service.in
9f336ae0e51814bc19fcd5a039ca95dc92912663c6a46eaf63e1933d6c84e863 packages/webui/tests/pinned-copy.test.mjs
3fd286a744e7e4827b2f15da9bcae1484228ba077c4823ac84bfad9026e42470 packages/webui/tests/service.test.mjs
03350df28932e61c16a3ba87db4ccd2d3cff8e74a88fb08f5828a462639aa185 scripts/webui-service.sh
+10
View File
@@ -0,0 +1,10 @@
agents/rocko/work/queue-77/byte-check.sh
agents/rocko/work/queue-77/r2/mutants.py
docs/TOOLS.md
packages/webui/README.md
packages/webui/src/cli.mjs
packages/webui/src/reads.mjs
packages/webui/systemd/mosaic-webui.service.in
packages/webui/tests/pinned-copy.test.mjs
packages/webui/tests/service.test.mjs
scripts/webui-service.sh
@@ -0,0 +1,110 @@
✔ the Board: held roles with no machine sessions, a claim with no address, the toggle kept across a reload, and Message addressed to the role (5652.728726ms)
✔ a redirect answer on a Board read, a bus read, a conversation read, a board POST, a module read and a send signs the page out: one line, nothing stale, no further reads (6873.044072ms)
✔ browser edge states: loading, empty, malformed, stale, hostile/long values, in-flight reply and appearance fallback (3886.542008ms)
Rendered contrast: {"failures":[],"count":330,"lowest":4.504658476260286}
✔ served Console browser: real board fixtures, keyboard, drafts, receipts, themes, 320px and failures (5033.393073ms)
✔ S5 pages in a browser: real broker rows, inert text, Copy, routes, failures, layout and no writes (6555.909601ms)
✔ bus routes serve the four reads from the reader view, unescaped JSON for the page to escape (125.583049ms)
✔ decisions route serves the roles and recent lists from the reader view (66.292246ms)
✔ credentials route serves the broker credential status from the reader view (58.068868ms)
✔ replies route serves the replies to one message from the reader view (921.453381ms)
✔ bus routes are GET-only, have no write verb, and keep the same-origin checks (797.687543ms)
✔ bus refusals map to statuses and never carry a path or a stack (252.662949ms)
✔ humanCall speaks the human transport protocol without blocking the server (2539.198873ms)
✔ busReader takes --business, else the live bus host, else refuses (854.179791ms)
✔ humanCall kills a transport that runs past its timeout (577.69489ms)
✔ serve refuses a --business value that is not a business id (964.435564ms)
✔ conversation view: full history, collapsed tools, hidden thinking, inert hostile content, malformed and reconcile markers (3678.265073ms)
✔ conversation view: a fork keeps the open branch, says so, and opens the new one on request (3693.506552ms)
✔ conversation view: a newer session with no readable history keeps the marker (1761.750889ms)
✔ conversation view: seats without history say so and offer no reply (1187.425228ms)
✔ Discord row through real board/WebUI: independent brake/liveness, no Reply, literal content (3021.416947ms)
✔ return flow through the conversation view: send, tool call, delayed result, peer message, exact long answers, relaunch (55721.404225ms)
✔ copy writes the Console paths at the full id, read-only, and leaves an existing copy alone (3104.716419ms)
✔ copy refuses a commit off refactor, an unknown one, a worktree and a bad copies directory (2529.488318ms)
✔ copy writes nothing when an archived path is missing at the commit (930.290612ms)
✔ a copy that loses the rename race leaves no read-only temp directory behind (934.405727ms)
✔ serve runs from a copy: /healthz 200, the config check, roles and RELEASE from the copy, the queue from --checkout (1216.072881ms)
✔ serve refuses a --checkout that is not an absolute directory path (473.79803ms)
✔ consoleReads runs the queue read under queueRoot and reads RELEASE under root (134.11589ms)
✔ preview options are all three or none, and each is checked (11.992261ms)
✔ the CLI refuses a partial or invalid preview flag set at start (3725.171551ms)
✔ the CLI with all three flags serves the preview mode (555.846884ms)
✔ a request for the public name needs the header equal to the user id, else 401 and nothing read (71.214805ms)
✔ the header name matches without regard to case, and the value compare is exact (21.271076ms)
✔ the public name with the header reads the bus views, and the Host and Origin are checked first (108.177559ms)
✔ in preview mode every write answers 403 read-only, from the public name and loopback, and reaches nothing (79.433331ms)
✔ loopback requests are unchanged in preview mode, and the bus views work with the board down (20.740235ms)
✔ a proxy that rewrites Host to the loopback port gets 403 on its first request, whatever the user (84.43866ms)
✔ a repeated Host is 400 before any other check, in preview mode and without it (64.395643ms)
✔ without the preview flags the public name is refused and writes still reach the board (26.697231ms)
✔ redactor: config, dataRoot, any absolute path, Discord ids and the JSON parser quote (2.525235ms)
✔ credential state from the date alone, as the bus states it (0.313658ms)
✔ queue: rows, one row, ids and methods, notes; no path or id from a row (3350.849682ms)
✔ queue: a refused read fails closed with the store's text, redacted (1122.987514ms)
✔ queue: a store that fails to load, or a child that dies, gives a fixed message with no path or stack (2767.073053ms)
✔ business: names, vars on the allowlist, authority, credential metadata only (26.592648ms)
✔ business: missing or invalid file refuses with the module's text, redacted (26.386315ms)
✔ business without --business: the live bus host, else no-bus-host; no system config: not-configured (17.494384ms)
✔ settings: release, board, loopback address, notifier binding name only (368.437794ms)
✔ task fields: the committed table with no reads configured, GET only; a bad table refuses with no path (37.868594ms)
✔ both presentations replace old activity with relaunch notice, label retained history, then resume after new activity (3726.089723ms)
✔ reported return flow and relative Age: reply sent from the inspector, then the new answer appears there without manual refresh (23179.214479ms)
✔ the send box: held roles, the draft and caret across a refresh, each receipt, one POST per Send, and the trail link; the board Reply on a 4xx and a 5xx (5646.908673ms)
✔ a sent receipt lists its replies as the page refreshes, oldest first and capped, and marks none delivered or read (12413.943966ms)
✔ startServer takes send only as a function and only with the preview mode (10.395531ms)
✔ the CLI refuses --send without the preview flags, and without a configured bus (3274.86502ms)
✔ the CLI with --send and a configured bus sends through the human transport and logs one line (775.430695ms)
✔ without --send the route is read-only like every other write, and config says no send (57.605036ms)
✔ with --send every other write is still 403 read-only, and nothing reaches the board or bus (35.678827ms)
✔ config says send only on the public name with --send on (5.343804ms)
✔ a send without the signed-in user is 401 and is neither sent nor logged, loopback included (12.370985ms)
✔ each request check refuses before anything is sent, and logs the refusal without the body (43.788471ms)
✔ a send passes exactly to, body and in_reply_to, answers the id, and logs it (6.843107ms)
✔ a crafted role name cannot forge a log line (11.546315ms)
✔ a bus refusal is not sent, with its status; an outcome the bus could not confirm is unknown and never retried (24.676453ms)
✔ through the human transport the request is exactly the business, message.send and the keys (367.497313ms)
✔ against a real broker: the message is written once as a human send, and its refusals map (207.778351ms)
✔ loopback host and board origin fail closed (21.512593ms)
✔ real board fixture passes through WebUI; assets and isolated seen/reply work (477.826728ms)
✔ proxy preserves exact request bytes, status and receipt, rejects forms and malformed JSON, never follows redirect (191.781768ms)
✔ unreachable board reports URL; CLI rejects unsupported options (1675.540375ms)
✔ render prints the unit without the preview flags (73.548054ms)
✔ render carries every serve flag, the preview set included (76.300501ms)
✔ a partial preview set is refused (155.479949ms)
✔ a value the unit cannot carry is refused, for every flag (2550.371939ms)
✔ the rendered unit names none of the human proof agent markers and sets no agent variable (169.790731ms)
✔ install into --dir with --no-reload writes the file whole, then reports unchanged (278.350138ms)
✔ install without --no-reload runs daemon-reload and nothing that starts the unit (122.433297ms)
✔ uninstall refuses while the unit is running, with or without --no-reload, and removes it once it is not (473.731385ms)
✔ status prints the unit state and GET /healthz on the installed port (537.676307ms)
✔ usage: an unknown verb or flag, and start or enable, exit 4 (167.833482ms)
✔ without --send, render is the template with its placeholders filled, byte for byte (58.047323ms)
✔ render --send with the preview set ends ExecStart with --send and changes nothing else (85.331478ms)
✔ --send without the whole preview set is refused and writes nothing (424.926036ms)
✔ install --send into --dir with --no-reload writes the sending unit, and status says whether it sends (706.922257ms)
✔ uninstall and status take no --send (59.102864ms)
✔ install refuses while the unit is running, in any state but inactive or failed, and changes nothing (424.757864ms)
✔ when the state read fails, install and uninstall refuse with one line and change nothing (89.319685ms)
✔ install needs --copy naming a copy that exists, and refuses outside the canonical checkout without --allow-worktree (85.537932ms)
✔ install refuses unless the bus unit runs from the same copy, naming both paths, and changes nothing (280.974851ms)
✔ render --copy runs the copy and reads the queue in the checkout; without --copy the unit is unchanged (49.346291ms)
✔ the uid header takes only an Authentik uid; the username header still takes a username (448.021656ms)
✔ a preview value cannot start with - or . (34.804782ms)
✔ status names the copy and whether refactor has moved past it, and says when the unit runs from no copy (277.931898ms)
✔ tokens.css and icons.svg are byte copies of docs/design (1.927007ms)
✔ JetBrains Mono files match the digests in their sources file, with the OFL text (4.175329ms)
✔ shipped strings are unchanged, and the web keeps its write boundary (4.239968ms)
✔ shell in a browser: System default, seeded states, 400px, focus and the Ctrl+K palette (8233.628854ms)
✔ five states on Board, Inbox, Tasks, Agents and Trail (2417.926873ms)
✔ Queue, Business and Settings in their five states, with no move button (5246.406734ms)
✔ seeded secrets, Discord ids and paths reach no response and no page; business refusals in the module's words (1539.169728ms)
✔ the server log names no config path when the system config refuses (316.630021ms)
ℹ tests 101
ℹ suites 0
ℹ pass 101
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 56427.272196
@@ -0,0 +1,6 @@
ff70f9b757cd27efc6c2213ec09699afd88fe4987274c59ce937763ef084abce ./base.txt
77780f1fb97ff82507d9cc793b34d1fefaafe2b646c8950de8e7b0e2b6932772 ./BUILD.md
d584776887e7184e2035ce891ce2ed9cc5df9ecdab06b92cf90f953ed9e7b22d ./build.patch
d9880f4c92d1d976027562a03cc5dd07512954e86f49f1da0ebb34e642a955f5 ./candidate-manifest.sha256
adaee0d7d46742fe5b1eb17d04b75128f80ae5bc9544a3bc4b1de3ce632bb1d7 ./files.txt
d9bfa1b2e1342cbd629dc965475fc783b179a9b581f0debd6f5aaaaac6e070c9 ./out/node-webui.txt