From 78ec47cd97bf0abc49334401f08c5b86e5be3a1a Mon Sep 17 00:00:00 2001 From: coder-mos1 Date: Sat, 1 Aug 2026 00:37:08 -0500 Subject: [PATCH] docs(rm-03): record review bypass remediation --- docs/scratchpads/rm-03-queue-guard.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/docs/scratchpads/rm-03-queue-guard.md b/docs/scratchpads/rm-03-queue-guard.md index 9ca37acc..f2cc3d8c 100644 --- a/docs/scratchpads/rm-03-queue-guard.md +++ b/docs/scratchpads/rm-03-queue-guard.md @@ -74,7 +74,7 @@ Logs remain untracked under the worktree as `.mosaic-test-work-red-*.log` and wi - [x] Mutant tests authored and observed red. - [x] Implementation green. - [x] Baseline and focused situational gates green; full package suite has an unrelated framework-shell environment abort recorded below. -- [ ] Independent review clean. +- [ ] Independent review clean (rev-974 requested changes at `44ffa99a`; bypass remediation committed and awaiting re-review). - [ ] PR CI terminal-green at exact head by full step scan. - [ ] Merge-gate verdict issued against frozen head. @@ -86,6 +86,13 @@ Logs remain untracked under the worktree as `.mosaic-test-work-red-*.log` and wi - `pr-metadata.sh` is consequential only as the normalized source of that head branch/repository/SHA. Its diff is limited to exposing those fields on GitHub and Gitea. - `test-pr-merge-gitea-empty-uid.sh` changes because exact-head Gitea merges now always use the API path (the only path that can send `head_commit_id`), superseding the prior tea-empty-identity fallback behavior. +## Review remediation + +- rev-974 independently proved that the documented `--skip-queue-guard` merge option bypassed an exit-99 guard stub, reached the provider merge payload, printed success, and exited 0 at head `44ffa99a`. +- RED-first reproduction was added to `test-pr-merge-head-pin.sh` before the production fix: `FAIL merge-bypass: --skip-queue-guard reached the provider merge path`, suite rc 1. The test-only commit is `241113e6`. +- Production remediation `37aae650` removes the option from parsing, usage, help, and examples. Every merge-capable path now invokes the queue guard; `--dry-run` alone omits it and has a regression proving that it exits before provider dispatch and creates no merge payload. +- Existing Gitea merge tests now exercise a successful guard response rather than bypassing the guard. + ## Risks / boundaries - The local JSONL audit is durable operational evidence but not tamper-resistant against the same UID. RM-03 does not claim otherwise. @@ -104,6 +111,8 @@ Fresh after rescue checkpoint `b7175012`: - `pnpm format:check` passed. - `pnpm --filter @mosaicstack/mosaic test`: Vitest passed 1508/1508 on the confirmation run; framework-shell then aborted at the pre-existing wake coordinate assertion with exit 97: `BASH_LINENO ... probe reported [3 5], expected [3 4] ... (#973)`. This is outside the RM-03 diff and is disclosed rather than substituted or called green. - The prior package-suite attempt had one transient, out-of-diff `install-ordering-guard.spec.ts` failure (1/1508); its isolated rerun passed 19/19 and the confirmation full Vitest run passed 1508/1508. +- After bypass remediation: all six focused RM-03 queue/merge regressions passed, including bypass refusal and dry-run non-dispatch; shell syntax and source-aware ShellCheck passed; `pnpm typecheck`, `pnpm lint`, and `pnpm format:check` passed. +- Fresh `test:framework-shell` reached and passed every RM-03 test, then again aborted at the unrelated wake coordinate assertion with exit 97; it remains explicitly non-green rather than substituted. - An ad hoc raw Prettier invocation over `.template` and `.sh` files was unrunnable because no parser is registered for those extensions; it was not used as a substitute for canonical `pnpm format:check`. ## Final evidence