duckworth: row 301 round 2 approve (static) on acc97fb9c (6e1e4fcd), mos-1451 fixture lines only, stub sweep clean, round 1 miss corrected, C1 gate (duckworth-0274)

2026-10-23 07:18:27 -05:00
1 parent 65318da249
commit 790aa7550c
@@ -0,0 +1,50 @@
+# Row 301 (R6-N4, #1808) round 2: fixture delta review (duckworth-0274)
+
+Reviewer: Duckworth. Builder: Launchpad. Request: launchpad-0115. Ruling: mos-1451 under mos-1272.
+Candidate: launchpad/row301 at acc97fb9c, a fast-forward from 04a179740. Manifest digest
+6e1e4fcd14dad3b9923f6859a6e8a5f0bb3a46e7b04d2245b8fbdd020bda05d2, seven paths. DELETED.txt still
+names packages/webui/src/user-bus.mjs.
+Method: git reads of local objects only. No node, no tests, no fetch.
+
+## Verdict: APPROVE, with C1
+
+- All seven manifest hashes equal the blobs at acc97fb9c, and the file hashes to the stated digest.
+  The five round 1 paths keep their round 1 hashes. The two new paths are
+  packages/webui/tests/library-cli.test.mjs (7e782c2b…) and
+  packages/webui/tests/thread-claims.test.mjs (dd1e62d1…).
+- **The delta is the ruled text.** `git diff 04a179740 acc97fb9c -- packages/` changes one line in
+  each test, library-cli.test.mjs:17 and thread-claims.test.mjs:58. Each appends exactly
+  `export const busBusiness=()=>{throw Error('busBusiness outside --sso')};export const userCaller=()=>{throw Error('userCaller outside --sso')};`
+  to its busSource template string. No assertion, comment or other byte changes. The added text
+  has no backtick, `${` or backslash, so the template literal carries it as written.
+- **The stubs stay unreached.** cli.mjs calls busBusiness (:98) and userCaller (:103) only inside
+  `if (ssoOn)` (:91). Neither test passes --sso. The only `--sso` hits in either file are the stub
+  error strings. If a later change reaches them outside --sso, they throw, so the test fails loudly
+  rather than passing on a null.
+- **Stub sweep (the round 1 miss).** At acc97fb9c two tests swap a module by URL in a load hook
+  and match bus.mjs: library-cli.test.mjs:21 and thread-claims.test.mjs:61. Both also stub
+  serve.mjs. With serve.mjs stubbed, cli.mjs pulls these names from bus.mjs:
+  - cli.mjs:5 takes busCaller, busBusiness and userCaller.
+  - chat.mjs:7 (via cli.mjs:3 and console-bus.mjs:5) takes BusReadError.
+  Each stub now exports all four. console-bus.mjs and access.mjs import nothing from bus.mjs.
+  chat-http.mjs and serve.mjs take sendOutcome, subjectOk and busStatus, but serve.mjs is stubbed
+  in both tests and cli.mjs doesn't import chat-http.mjs. No test stubs user-bus.mjs. The
+  remaining user-bus mentions are comments in channel-proof.test.mjs:28 and bus.mjs:78.
+- **Row 300 coupling.** I checked row 300's test at a00b25b37. user-option-swap.test.mjs imports
+  userOptionsFor and BusReadError from the real modules, and its hook touches only
+  `serve.mjs?gate=open`. Row 301 changes only a comment word in console-bus.mjs, so either landing
+  order works.
+- BUILD.md: the re-pin section is repaired. The run 1 record and the ruling match launchpad-0115
+  and sage-3415. The record cites the cli.mjs line numbers correctly. Doc only.
+
+## Round 1 correction
+
+Round 1 (duckworth-0263) said the fold was safe because nothing else imports user-bus.mjs. It
+missed that two old tests replace bus.mjs by URL with a source that exported only BusReadError and
+busCaller. I grepped importers, not hook sources. Run 1 on 04a179740 went 372/2 on those two tests.
+
+## Conditions
+
+- **C1** Sage's gate on acc97fb9c: webui suite whole 374/0, channel-proof.test 2/0,
+  granted-user.test 19/0. Any other red stops the gate and goes to Mos. Round 1's C1 (rebase
+  recheck) still applies if any of the seven blobs change.
@@ -1557,3 +1557,4 @@ are never rewritten or removed; corrections are new entries.
 2026-10-23T07:13Z | Duckworth (Opus 5.5) | row 303 round 1 diff review (88ffecaf7, digest 3c3be5d3, launchpad-0089) | approve: one added R9 guard line, matches brief and mos-1422 pt 2, nothing else changed; C1 whole-file gate (duckworth-0260) |
 2026-10-23T11:49Z | Duckworth (Opus 5.5) | rows 300/301 round 1 manifest reviews (6a1d53066 62023a00, 04a179740 def28197, launchpad-0098) | 300 approve C1 gate+M12, N1 upstream unrecorded; 301 approve C1 rebase recheck C2 gate, fold is a pure move, pin 15e8123f->39fcb27c (duckworth-0263) |
 2026-10-23T12:08Z | Duckworth (Opus 5.5) | row 300 round 2 delta review (db5122920, digest db8be52c, sage-3412) | approve: call() resolves headers again, no assertion change; round 1 miss of the missing headers field recorded; C1 carried (duckworth-0268) |
+2026-10-23T12:18Z | Duckworth (Opus 5.5) | row 301 round 2 fixture delta review (acc97fb9c, digest 6e1e4fcd, launchpad-0115, mos-1451) | approve: one appended throwing-stub line in each of library-cli and thread-claims, stub sweep clean, round 1 miss recorded; C1 gate (duckworth-0274) |