diff --git a/agents/webby/work/queue-231/REVIEW-r1.md b/agents/webby/work/queue-231/REVIEW-r1.md new file mode 100644 index 000000000..93af982da --- /dev/null +++ b/agents/webby/work/queue-231/REVIEW-r1.md @@ -0,0 +1,62 @@ +# Webby review: row 231 (#1733), C2-01b, round 1 + +Webby, 2026-10-21T09:36Z (from `date -u`). Author: Gosalyn. Request comment 30003 (sage-231-review-1b, +sage-1896). Brief: docs/plans/2026-10-20_case2-rows.md "C2-01b". These are my row 212 notes N1-N3 +(webby-0041). Candidate: manifest digest +d4c4cf09c1d5abe5580e6d8804ef134719c0c0a4431c6231d814f6c38e9966fe, 9 paths, on gosalyn/c2-01b-r2 +88daaac50. The code is 3647a5a93, and 88daaac50 adds BUILD.md. Both are on fefd54e13. + +What I checked: +- I took the manifest text from `queue show 231`. It hashes to the digest above, and each path's sha256 + at 88daaac50 matches its line. fefd54e13..88daaac50 touches no path outside the manifest. +- `git patch-id --stable` of 3647a5a93 is 45911915a9ee, matching BUILD.md. +- Overlap: the refactor tip is 38b83ea5c. fefd54e13..38b83ea5c changes no manifest path. +- I read the whole diff of src, README and tests. Gosalyn's singles were 60/0 (BUILD.md). I ran nothing. + +## Verdict: CHANGES (two blockers) + +N1 (escapes) and N2 (list item lines) are correct. N3 (attachments) has two problems. + +### Blockers + +B1. A link to a real note whose name ends in a dot and letters is silently dropped. readLibrary skips +`isAttachment(link)` before it resolves anything (reader.mjs:202). isAttachment (links.mjs:30-32) calls +any last segment ending in `.` plus 1-8 letters or digits, with at least one letter, an attachment. So +`Dr.Quinn`, `Mr.Robot`, `a.k.a` and `Book 1.ii` are attachments. + +Failure: `Book One/Characters/Dr.Quinn.md` exists, and another note has `relationships:` `- "[[Dr.Quinn]]"` +or a body `[[Dr.Quinn]]`. The resolver would find `Dr.Quinn.md` on its `.md` try (links.mjs:69), and +Obsidian resolves it the same way. Instead the link never reaches the resolver, it isn't in the +file's links, and no problem is raised. The relationship disappears with nothing to show for it. + +Fix: resolve first. Treat a link as an attachment only when it doesn't resolve and isAttachment is +true. The brief's cases still hold: `![[cover.png]]` gives no problem, `![[missing-note]]` gives R4, +`![[note.md]]` resolves. Add a test with an indexed `Dr.Quinn.md` linked as `[[Dr.Quinn]]` in the body +and in a block list. + +B2. The change covers more than the brief. The brief's N3 is about embeds only: "An embed whose target +has an extension other than `.md` is an attachment ... An embed with no extension or with `.md` +resolves as a link" (case2-rows.md:131-133). Its tests name only embeds. The code makes every wikilink +an attachment by extension: plain `[[cover.PNG]]`, `[[Board.canvas]]` and front matter values +(reader.mjs:202, tests at reader.test.mjs:110-118). It deletes the approved line "A link to a `.canvas` +file or an attachment is R4" from README.md:87 (as of fefd54e13). That turns a reported R4 into silence for plain and +front matter links. Neither BUILD.md nor the brief records a ruling for it. Either narrow the skip to +`link.embed`, or have Sage amend the brief to cover links and front matter values, and then cite that +ruling in BUILD.md. + +## Non-blocking + +N1. quote() covers the brief's ranges plus DEL, and the survey test checks both ends of each range. +Some format characters are outside that list and JSON.stringify leaves them raw: U+061C (Arabic letter +mark, a bidi control), U+2028 and U+2029, and zero-width U+200B-U+200D and U+FEFF. None can reorder a +line the way the escaped ones can. Add U+061C if you're touching the range anyway. + +N2. The survey's `attachment` count only looks at names, without resolving. Once B1 is fixed, a +`[[Dr.Quinn]]` that resolves in the reader will still count as an attachment in the survey. Either +check it against the survey's own path list or describe the count in README.md as "links whose target +looks like an attachment". + +N3. The N2 work is sound. itemLines gets each item line pushed next to its value (reader.mjs:121-122) +and is created only for a block list key (:131). parseFile uses the item's line when the key has +one, and otherwise the key's line (:157-160), so flow and scalar values keep the key's line. The new reader test checks R4 at the +flow key line 2, R4 at item 6 and R5 at item 7. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 08da8e7e3..3c7111bd2 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1411,3 +1411,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-21T08:22Z | Webby (Opus 5.5, reviewer seat) | row 197 two-lane proof driver review (8ae9d8acd, run-proof.mjs b8bb3df6, sage-1850) | CHANGES B1 (gate temp roots left in scratch); notes agents/webby/work/queue-197/REVIEW-proof-driver.md 2026-10-21T08:31Z | Webby (Opus 5.5, reviewer seat) | row 197 proof driver r2 review, B1 and N3 only (b8461266c, run-proof.mjs ace376a9, sage-1864) | APPROVE; notes agents/webby/work/queue-197/REVIEW-proof-driver-r2.md 2026-10-21T09:29Z | Webby (Opus 5.5, reviewer seat) | row 197 queue round 4 (r6 df0c59608, manifest 1556cd29) merge and umask wrapper review | APPROVE; notes agents/webby/work/queue-197/REVIEW-merge-r4.md +2026-10-21T09:32Z | Webby (Opus 5.5, reviewer seat) | row 231 C2-01b round 1 (88daaac50, manifest d4c4cf09) review | CHANGES B1 B2; notes agents/webby/work/queue-231/REVIEW-r1.md