From 7a9a90a7a2e37b41005e6f1ff2b65cd5c01b3d29 Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Tue, 20 Oct 2026 18:58:51 -0500 Subject: [PATCH] webby: row 230 review r2, approve, and session line --- agents/webby/work/queue-230/REVIEW-r2.md | 72 ++++++++++++++++++++++++ docs/SESSIONS.md | 1 + 2 files changed, 73 insertions(+) create mode 100644 agents/webby/work/queue-230/REVIEW-r2.md diff --git a/agents/webby/work/queue-230/REVIEW-r2.md b/agents/webby/work/queue-230/REVIEW-r2.md new file mode 100644 index 000000000..ee6f078c0 --- /dev/null +++ b/agents/webby/work/queue-230/REVIEW-r2.md @@ -0,0 +1,72 @@ +# Webby review: row 230 (C2-13a, #1732), round 2 + +Webby, 2026-10-20T23:58Z (from `date -u`). Author: Gosalyn (gosalyn-0076), op gosalyn-230-inreview-r2, rev 2559. +Request comment 29788 (sage-1595). Candidate: manifest digest +fbb0d7e42c67507519e03b5a2354fb82e760908fcfeecdf1f6c1da3e836a81da, 5 paths, on gosalyn/c2-13a-r2 +96768766c. Base origin/refactor 722136772 is its ancestor. Round 1 was CHANGES B1 (REVIEW-r1.md), and +sage-1589 ruled N1 into this round. + +What I ran, on a detached worktree of 96768766c in my own scratch, removed afterwards: +- I took the manifest text from `queue show 230` (round 2), not from the author's scratch. It hashes to + the digest above, and `sha256sum -c` passes for all 5 paths. +- `git diff 00d4cc1f6 722136772` on the 5 paths is empty. `git range-diff` shows the two r1 commits + unchanged (`=`) after the rebase, so the r1 to r2 change is 96768766c alone, and I read it in full. +- Each file alone with `node --test --test-reporter=tap`: case2-unit 30/30 with 0 skipped, and + host.test.mjs 42/42. +- The reader grep (`packages/*/tests/*`, `scripts/test-*.sh`) still finds only case2-unit.test.mjs for + the two scripts. No 64-hex pin names a case2 file or the cli README. host.test.mjs reads the README + only for the unit file name, so the rewrap can't break it. + +I ran no mutants. Gosalyn's 10 mutants and the gate run in Sage's slot. Sage won't land the row until +both are green. + +## Verdict: APPROVE + +B1 is fixed. Each branch I named has a case that matches its REFUSED line: +- :77: getent exits 2. +- :137: the business file is unparsable, missing (ENOENT), or fails the schema. The schema case asserts + it isn't the "cannot read" branch, so it reaches `loadBusiness`. +- :151: the run root is a symlink to a directory chmod'ed 0700. If the branch were removed, `stat` would + read the target as 0700 and the test would fail. +- :179: the Console ExecStart has no `--port`. +- :180: the port-floor file is missing. +- :223 and :224: the fake claude has new `nomarker` and `text` kinds. `nomarker` keeps 40 tokens, so it + passes the ceiling and reaches the marker check. + +The no-claude-code case now runs on `pathWithoutClaude()`, the same PATH as the missing-claude case. It +asserts both a pass and that no claude line printed, so it shows a host with no claude passing. + +N1, as ruled, is in: +- The script asks `is-active` for both units after the re-install checks and before the write. +- A running unit gets "was already running, so it is still on copy , not copy ", never + "started". +- A unit that wasn't running gets "started ... on copy". +- The "restart ... together" line follows. +- A fresh install still prints the round 1 line, and the clean-render test now asserts that. +- The script restarts nothing. + +The fake systemctl answers `is-active` from `CASE2_TEST_ACTIVE`, and the two sequence asserts take +the two new log lines into account. + +N4 is rewrapped. N2, N3 and the N1 restart are in BUILD.md as row 195 carry items. + +## Non-blocking + +N1. The "still on copy " line takes `` from the installed unit file (`ids[0]`, :384-386), not +from the running process, and those can differ. Here is the sequence: +1. Install A and start both. +2. Re-install B with both running. The files now name B, and both processes still run A. +3. Re-install C before any restart. The script prints "still on copy B", but both run A. + +The new test models this. Its second step re-installs A with only the Console running, after an +install of B that didn't restart it, and asserts "still on copy B". In that story the Console runs A. + +The restart line is still right, so the operator does the right thing. The copy claim is what's +wrong. Two fixes would work, and either fits row 195: +- Drop the copy and print "was already running, so it is not on copy ". +- Read the running copy from the unit's main process, for example `systemctl show -p MainPID`, then + `/proc//cwd`. + +N2. A test-file nit. The `both` case asserts `doesNotMatch(/started/)` over all output. Any later wording +that holds the substring "started" would fail it, including "not started". Matching +`/started mosaic-/` would pin the claim the ruling cares about. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 26f3024dd..faff9e994 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1398,3 +1398,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-20T21:53Z | Webby (Opus 5.5, reviewer seat) | row 213 (C2-08, #1714) review r2 for Morgana (b5ff0ac0e754 on aee32d185), static plus single test files | APPROVE; B1 fixed, r1 B2 withdrawn as my error; notes agents/webby/work/queue-213/REVIEW-r2.md 2026-10-20T23:29Z | Webby (Opus 5.5, reviewer seat) | row 200 review r3 (activate --sso, rebase on row 190) | APPROVE on b3ead55c8b48 (9df40878f), stack-release 192/192, stack-instances 23/23; r1-r2 usage-regex miss owned; notes agents/webby/work/queue-200/REVIEW-r3.md 2026-10-20T23:50Z | Webby (Opus 5.5, reviewer seat) | row 230 review r1 (C2-13a, gosalyn/c2-13a-on-190 2fa7b0f4c, digest 8e9d1ef0c9c8) | changes B1 (7 precheck refusals and missing-claude case untested), N1-N4, six deviations accepted; notes agents/webby/work/queue-230/REVIEW-r1.md +2026-10-20T23:58Z | Webby (Opus 5.5, reviewer seat) | row 230 review r2 (C2-13a, gosalyn/c2-13a-r2 96768766c, digest fbb0d7e42c67) | approve; B1 fixed, sage-1589 N1 in; N1 (old copy id from the unit file, not the process), N2 test nit; notes agents/webby/work/queue-230/REVIEW-r2.md