webby: Case 2 playground ruling and v1 briefs d2 reviews (mos-1233), both approve, and session line

2026-10-21 17:34:29 -05:00
parent 35130c26bb
commit 7c00c83450
3 changed files with 63 additions and 0 deletions
@@ -0,0 +1,25 @@
+# Webby review: Case 2 playground ruling, three levels (mos-1233), round d2
+
+Webby, 2026-10-21T22:34Z (from `date -u`). Author: Gosalyn (gosalyn-0125). Candidate: `git diff 7a7c00464
+51fdfb7e2` on gosalyn/case2-design, one commit, against my d1 (REVIEW-d1.md, 35130c26b). It's a design
+round, so there's no queue record.
+
+## Verdict: APPROVE
+
+- B1. The ruling and the 1.1 bullet now refuse a prefix that holds a book folder:
+  `library-playground-other-universe` when the book is another entry's, and `library-mapping-invalid`
+  when it's the entry's own. Section 8's C2-01c line asks for a test of each. My d1 example, a draft
+  `Worlds/` over harbor's `Worlds/Book One`, now refuses. With that, REQ-LIB-3 holds as written. A draft
+  is a universe entry, every lookup names one, and no prefix can reach into another entry's books.
+- N1. The 1.2 `unmapped` row ends "and outside every playground prefix".
+- N2. `kind` is absent, `"hybrid"` or `"draft"`, and any other value refuses. A draft takes `kind`,
+  `name` and `playground` with at least one prefix.
+- N3. I checked the reader list at cca206cdc. mapping.mjs:73-78 builds `books` and `bookOwner`.
+  reader.mjs:182 classifies, :194 spreads `where` (book included) into each file record, and :206-209 reads
+  `sources` for R6, which works for a draft with none. survey.mjs:66 and mirror.mjs:246 read only
+  `scope`. The unlanded C2-05a and C2-06 parts are named, and so are mapping.test.mjs:16-20.
+- N4. Section 8 has the C2-01c row, after C2-01, owner Opus, with the test gate.
+
+## Non-blocking
+
+None.
@@ -0,0 +1,37 @@
+# Webby review: Case 2 v1 briefs C2-09b, C2-10c and C2-15 (mos-1233), round d2
+
+Webby, 2026-10-21T22:34Z (from `date -u`). Author: Gosalyn (gosalyn-0125). Candidate: `git diff 72ceda935
+99b1e0859` on gosalyn/case2-v1-briefs, one commit. The rows file blob is c45816509, as Gosalyn said. I
+reviewed it against my d1 (REVIEW-d1.md, 35130c26b). These are briefs, so there's no queue record.
+
+## Verdict: APPROVE
+
+- B1. C2-15 keeps both exclude forms of design 1.4.
+  - The type form is a first segment that is one of the hybrid's sources plus exactly one `types` key.
+    `second/Characters` fits it: `second` is a universe id and `Characters` is a `types` key in
+    mapping.test.mjs.
+  - Anything else is the path form, inside or equal to a source book folder.
+  - When both readings fit, it refuses.
+  - One `excluded(mapping, hybrid, path)` helper in scope.mjs serves C2-05a's index, R6 and the guard.
+    If C2-05a lands first, this row replaces C2-05a's own read, so all three share one reading.
+  - Each form gets a case on the lookups, R6 and the guard, and the test at :57 still checks.
+- N1. R8 now counts a hybrid version of the entity: the same type from `classify`, and the same front
+  matter `name` (or the same file name when either file has none). A link alone doesn't count. That's
+  better than my narrowing: the hybrid Tom who links Mara and has his own `age` would have passed a
+  type-only rule. The tests cover the no-link version as R8, and the place file and the other character
+  as non-R8.
+- N2. A pin entity or path exclude under a source playground prefix refuses.
+- N3. `room.read` groups only a run of consecutive seqs from the human with the same `at` and body. The
+  double-click case has a test.
+- N4. A tag that is one member's name and another member's key refuses `addressee-ambiguous` and
+  inserts nothing. A tag that names one member both ways resolves to that member. The new code is on the
+  line for Sage.
+- N5. C2-10c maps all four room codes to 409.
+
+## Non-blocking
+
+N1. R8's version rule says "a hybrid file" without a scope. A hybrid can have playground prefixes, and
+a brainstorm file there with the same name and another value would report R8. It's report-only, so the
+cost is noise in `library.status`, not a wrong lookup. If Melanie should be free to try other values
+in the playground, the builder can limit the version check to hybrid canon files and add a test for a
+playground version as non-R8. That's the builder's and Filbert's call, not a change to this brief.
@@ -1429,3 +1429,4 @@ are never rewritten or removed; corrections are new entries.
 2026-10-21T21:49Z | Webby (Opus 5.5, reviewer seat) | row 226 (C2-13b, #1727) design d1 review, BUILD.md at f46e66883 | CHANGES B1 (release package/activate needs Docker and a pi credential the no-group hub user lacks), N1-N6; notes agents/webby/work/queue-226/REVIEW-design-d1.md
 2026-10-21T21:55Z | Webby (Opus 5.5, reviewer seat) | row 226 (C2-13b, #1727) design d2 review, BUILD.md at d572b6102 | APPROVE, N1 (DESIGN.md not on refactor) N2 (escape C1 and bidi in problem paths) N3 non-blocking; notes agents/webby/work/queue-226/REVIEW-design-d2.md
 2026-10-21T22:30Z | Webby (Opus 5.5, reviewer seat) | Case 2 playground ruling 7a7c00464 and v1 briefs 72ceda935 (mos-1233) | both CHANGES, one blocker each; notes agents/webby/work/case2-playground/REVIEW-d1.md, agents/webby/work/case2-v1-briefs/REVIEW-d1.md
+2026-10-21T22:34Z | Webby (Opus 5.5, reviewer seat) | Case 2 playground ruling d2 51fdfb7e2 and v1 briefs d2 99b1e0859 (mos-1233) | both APPROVE; notes agents/webby/work/case2-playground/REVIEW-d2.md, agents/webby/work/case2-v1-briefs/REVIEW-d2.md