mosaicstack/stack
25
0
Fork 1
Code Issues 408 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

sage: row 172 packet, base control and trace lines corrected (Darkwing D1, D2 on #1670)

Browse Source
This commit is contained in:
jason.woltje
2026-10-19 15:34:00 -05:00
parent 0ed9412fca
commit 7f38a2f549
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
agents/sage/work/queue-172/BUILD.md
+8 -5
View File
@@ -22,9 +22,10 @@ A click inside one returned without a word: no `/api/seen`, so no redirect answe
The trace, `trace-fail-seen.json`, came from an instrumented copy of the test in
`/mnt/storage/scratch/sage-r172/wt` (base 04155deff, the same app.js), run in a loop under the suite's own
load until it failed (loop run 3). It records every fetch's path, start and end, the clicks and the sign-out
event. The wait gave up at 5191 ms with the page clock at 5792 ms, so the click was at about 595 ms. A
`/api/board` read ran from 580 to 615 ms. No `/api/seen` fetch and no sign-out event appear anywhere.
load until it failed (loop run 3). It records every fetch's path, start and end, and the sign-out event. It
doesn't record the click: the click time comes from the page clock minus the wait. The wait gave up at
5191 ms with the page clock at 5792 ms, so the click was at about 595 ms. A `/api/board` read ran from 580 to
615 ms. No `/api/seen` fetch and no sign-out event appear anywhere.
This is a product defect. On the live Board a Seen click during the 10 s poll's read does nothing, and a slow
machine scan makes that window wider.
@@ -49,8 +50,10 @@ The stub gains `window.__hold`: the next fetch of that path waits until the test
4. Clicks Seen again while the POST is held, waits 200 ms, releases.
5. The Seen count is 1, and exactly one `/api/seen` and no other Board read follow the held read.
On the base app.js it fails at `#seen-count === "1"` (`/mnt/storage/scratch/sage-r172/base-control.log`).
On the candidate it passed 3 of 3 on its own.
On the base app.js the committed test fails at :185, `window.__held.length === 1`: the click is dropped, so
no POST is held (Darkwing's review run, #1670 comment 29207). `/mnt/storage/scratch/sage-r172/base-control.log`
is from an earlier draft of the test, before the hold on `/api/seen`, and fails at that draft's :183
`#seen-count === "1"` wait. On the candidate it passed 3 of 3 on its own.
## Cause 2: the row 165 test killed its own wait with a reload