mosaicstack/stack
25
0
Fork 1
Code Issues 358 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

docs(build-log): row 47 round 1 (dewey) and landing (sage)

Browse Source 
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
jason.woltje
2026-10-09 23:11:06 -05:00
co-authored by Claude Opus 5.5
parent ee5597e112
commit 80c7e573ac
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
BUILD-LOG.md
+18
View File
@@ -3881,3 +3881,21 @@ Records:
- REQUEST to Darkwing
No push. The landing target stays 2026-10-13, after the Q14 hold.
### 2026-10-10 — Dewey, row 47 round 1 in review: Mr flows test and the leftover shim (#1533)
Before: row 40 landed with mutant Mr surviving, and a conversation `shim.mjs` from Filbert's row 41 round 2 gate outlived the suite and was killed by PID. Row 47 started at rev 273 (7ab2f92d).
After: `flows.test.mjs` has the drafted test for a hold inside held input, and it fails under Mr. The shim ignores SIGTERM by design and exits only on `release`, which no `src/` code sends, so a force-stopped scope stays up until it is killed. claim.test's W5 probe and W13 force-stop a scope and left it for the file's `after` hook, whose `systemctl` kill and stop are unchecked. Filbert's leaked shim was the W5 probe (fixture f55). The journal stops before W5 ends, so why that kill missed can't be shown. W5 and W13 now reap their own scopes. K19 kills its scope if its own kill or release fails. The harness gains `liveShims`, `killShims` and `shimsGone`, and `reap` ends with a sweep. claim, cohort and races each end with a test that names a leaked shim, and an `after` assertion that none outlives the file.
Mutants (full conversation suite, scratch copies): base 165/165; Mr, noprobe and now13 each fail one test; afterleak (no probe reap and no `after` sweep) fails the final test and the `after` hook, and leaves one shim, which the runner killed. Gate on a detached worktree of 21e0f1a3 plus the candidate: conversation 165/0, webui 22/0, test-auth 15, test-conductor 17, test-config 24, test-discord 66, test-extension-package 18, test-foundation 44, test-queue 27 (node 148), test-release 14, test-task 98, all 0 failed. No shim was left after the gate.
Not fixed, reported to Sage for a follow-up row: in a running controller, every force stop leaves its scope and idle shim until something kills the unit, because nothing sends `release`. That is in cohort.mjs and controller.mjs, out of scope for this row.
Records: manifest 0587e393 (6 files, `agents/dewey/work/queue-47/`), revs 277-278 (10351f6a), request comment 27036, notes comment 27037. REQUEST to Darkwing and Filbert. No push.
### 2026-10-10 — Sage, row 47 landed: Mr flows test and no shim left after the suite (#1533)
Both round 1 reviews approve candidate 0587e393: Filbert (comment 27041, rev 281, 05ea5f45) and Darkwing (comment 27043, rev 282, 46b87c5d, packet 3b502421). The manifest checked 6/6 in the canonical tree, and the candidate landed as ee5597e1, committed through a temporary index for the same reason as row 40. `queue review verify-commit 47 HEAD` matched all 6 paths. Gate on a detached worktree of 0dc9218d plus the candidate: webui 22/0, conversation 165/0, control-board 124/0, test-auth 15, test-conductor 17, test-config 24, test-discord 66, test-extension-package 18, test-foundation 44, test-queue 27, test-release 14, test-task 98, all with 0 failed. The Docker recall pair passed. No `mosaic-chat-*` unit and no `shim.mjs` process were left after the gate.
Dewey's src finding is row 50 (#1536, brief d378a445): a force stop and controller close never send `release`, so a running controller keeps one idle shim per force stop. The reviewers' test-harness notes go to the same row, posted as comment 27045 on #1536: Filbert N1 (no positive check that `liveShims` sees a shim), N2 and Darkwing's note (`killShims` must match `^mosaic-chat-` before it kills a unit), and N3 (K19's wait on `proc.exited` needs a bound).