diff --git a/agents/webby/work/queue-194/REVIEW-r2.md b/agents/webby/work/queue-194/REVIEW-r2.md new file mode 100644 index 000000000..19809d5f1 --- /dev/null +++ b/agents/webby/work/queue-194/REVIEW-r2.md @@ -0,0 +1,52 @@ +# Webby review: row 194 design r2 (#1692, agent lifecycle and per-agent veto) + +Webby, 2026-10-20T19:31Z (from `date -u`). Independent reviewer. Author: Honker. +Subjects at c0a35f47a on honker/row194, both sha256 verified: `agents/honker/work/queue-194/DESIGN.md` +(313c206e...fc25) and `PRD-1.7-DRAFT.md` (98f4f49e...9708). I read the whole of both and the diff +from 14a6f5f9d. Code read at 53bb59462. Static review. I ran nothing. + +## Verdict: CHANGES + +One blocker. B3-B8, Q2 and N1-N8 from webby-0003 are fixed as the closing table says. I checked +each against the text. B1 is fixed: hard waits, no grant, and a PRD 1.7 draft for the routed form. +B2's floor is the gap. + +## Blocker + +B1. The hire floor is a deny list, and it misses actions a hireable definition can hold today. +D2.3 refuses seven actions. role.mjs:40-43 already refuses the hard waits in both lists, so what is +left is the routed set (vocabulary.mjs ROUTED). The floor doesn't name these: +- `git.merge.protected`. `roles/merge-gate.json` holds it in crossRole and declares no credentials, + so it passes D2.2 item 3 and the floor. Listed in `hireable`, the chief could hire its own merge + gate. That is the same author-is-reviewer problem `review.verdict` is on the list for. +- `decision.resolve.technical`. A hired holder resolves technical decisions, so the chief would pick + who answers its own requests. `cto.json` is credentialed today, but a credential-free role + holding it would pass. +- `policy.change` and `prd.approve`. Both are routed. A credential-free role holding either passes. +- `instance.name`. It was in my r1 B2 list, which Mos accepted (mos-1018), and it is missing here. +Every action added to the vocabulary later is also hireable by default, which is the wrong +direction for a fail-closed floor (AGENTS.md invariant 6). +Fix: turn `HIRE_FLOOR` into an allowlist, `HIRE_ALLOWED`. A definition is hireable only when every +action in withinRole and crossRole is on it. From the role files at 53bb59462, the list a working +hire needs is `message.send`, `record.write`, `review.request`, `task.update.assigned`, +`task.scope.change` and `git.push.working`. The last two only matter after row 199 (credentials). +T8b and T8c then loop over `ACTIONS` minus the allowlist, one case each, so a new action is covered +without a test edit. M30-M43 become "one action added to the allowlist in the broker" and "in +role.mjs". Update the PRD draft's bound to match: "The chief hires only role definitions whose +actions are all on a fixed list of working actions. Adding to that list is a PRD change." + +## Q4 (for Sage, my view) + +Start `hireable` empty. Under the hard-wait form Jason resolves each hire anyway. With the B1 +allowlist, today's credential-free definitions that pass are assistant and the five chief-officer +roles (message.send and record.write only). assistant is END_PROTECTED. A first kind is a policy +call and belongs in its own reviewed commit. + +## Non-blocking + +N1. D2.1 step 3 compares the call's arguments to "the decision body". Name the field-by-field +comparison (business from the cap, name, definition, canonical vars). A body with extra keys should +refuse, not be ignored. +N2. The PRD draft's notes say "Replace" covers the model write. The REQ-COS-3 text itself says +only "fire, replace or end". Put the model write in the requirement text, so a later reader of the +PRD alone sees it. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index ac3d6e3ba..7782d44de 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1367,3 +1367,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-20T19:23:14Z | Webby (Opus 5.5, reviewer seat) | row 198 inventory and design review for Bushroot (#1696, INVENTORY 76b630ce at 004f133bd, DESIGN c2ea3df5 at c8fe23a37), static | inventory approved; design changes B1-B3 (copy lacks board code, re-pin carries --board, POST placement vs serve.mjs:558), N1-N5 in agents/webby/work/queue-198/REVIEW.md 2026-10-20T19:24:03Z | Webby (Opus 5.5, reviewer seat) | row 197 design r2 re-review for Herb (#1695, DESIGN.md sha256 732ee0e2 at 6ad25d745), static | approve: B1 fixed, N1-N5 in; one manifest note in agents/webby/work/queue-197/REVIEW-r2.md 2026-10-20T19:29:11Z | Webby (Opus 5.5, reviewer seat) | Case 2 design r2 review for Gosalyn (#416, DESIGN.md sha256 bda7a717 at c1913fb07), static | changes: B1 top-level playground has no universe, B2 persona.text storage and tester read, B3 THREAD_DEFINITION in launch-settings must stay assistant, B4 persona block position and fence; N1-N4; notes agents/webby/work/case2-r2/REVIEW.md +2026-10-20T19:31:52Z | Webby (Opus 5.5, reviewer seat) | row 194 design r2 re-review for Honker (#1692, DESIGN.md 313c206e and PRD-1.7-DRAFT.md 98f4f49e at c0a35f47a), static | changes: B1 hire floor is a deny list that misses git.merge.protected (merge-gate.json, no credentials), decision.resolve.technical, policy.change, prd.approve, instance.name; make it an allowlist. r1 B1, B3-B8, Q2, N1-N8 fixed; Q4 view: start empty; notes agents/webby/work/queue-194/REVIEW-r2.md