queue: row 172 round 1 Darkwing approve (darkwing rev 2018), landing note and done (Sage revs 2019-2020)

This commit is contained in:
2026-10-19 15:35:49 -05:00
parent be10e0c838
commit 83db85aa3a
2 changed files with 82 additions and 11 deletions
+2 -2
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 2017 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
Generated from `docs/plans/queue.json` revision 2020 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---|
@@ -208,7 +208,7 @@ Generated from `docs/plans/queue.json` revision 2017 by `queue render`. Do not e
| 169 | stack-release.sh two-phase PM start past c216f47db: activate --pm-after-harness, pending pointer, pm-on verb, unknown-kind-for-target precheck (P19 382, mos-0848) | darkwing; reviewers filbert | #1666 | in-progress | — | Filbert approves the candidate manifest; cli suite and every scripts/test-*.sh green on Sage's gate; scratch rehearsal files with sha256 (sage) | `docs/plans/2026-10-19_pm-after-harness.md` § Brief: activate past c216f47db with the PM launched after the harness kind is set | In-review only after row 166 lands: rebase onto its landing and rerun the four brief tests and mutants first (mos-0852 point 5). after cleared so Darkwing can claim and build on 166's r1 candidate now. |
| 170 | A tester message to a role nobody runs is refused tester-target-not-running before it is stored; talk --tester exits 3 (P19 380, mos-0845 D2) | dewey; reviewers filbert | #1667 | done | — | Filbert approves the candidate manifest; bus and cli suites and every scripts/test-*.sh green on Sage's gate (sage) | `docs/plans/2026-10-19_tester-no-holder-refusal.md` § Brief: a tester message to a role nobody runs is refused, not queued | Rebased for landing onto 228aeb503 as cb43dcb45 (Sage, mos-0857 item 3). git range-diff 000730949..0b6ff260f 228aeb503..cb43dcb45 prints '1: 0b6ff260f = 1: cb43dcb45', and the six paths' +/- lines hash the same before and after. The candidate Filbert approved is unchanged. |
| 171 | A thread project named like a business-file repo: project-name-is-repo refusal unless --repo matches, clearer CLI refusal (P19 379, mos-0854) | rocko; reviewers dewey | #1668 | done | — | Dewey approves the candidate manifest; bus, cli, webui and plugins suites and every scripts/test-*.sh green on Sage's gate (sage) | `docs/plans/2026-10-19_project-names-and-repos.md` § Brief: a thread project named like a business-file repo | Landed as 078518e4e (Sage). Rebuilt on d58c9c5cd as 9a29febb6, gate GATE_PASSED there, then cherry-picked onto ed045ac84+b2d3b6c47: git range-diff prints '9a29febb6 = 078518e4e'. All 11 paths match candidate manifest c498ca89. Pushed d58c9c5cd..078518e4e with 4d9114ab4, ed045ac84, b2d3b6c47 (doc and SESSIONS commits). |
| 172 | Board-held sign-out wait times out under gate load: find and fix the cause, not the timeout (P19 366, mos-0858) | sage; reviewers darkwing | #1670 | in-review, round 1, request posted | 171 done | Darkwing approves the candidate manifest; the cause and trace are in the packet; webui suite 10 runs green under gate load and full gate green on Sage's gate (sage) | `docs/plans/2026-10-19_board-held-signout-flake.md` § Brief: the board-held sign-out wait times out under gate load | mos-0858: if row 171's gate trips on this flake twice, this row lands ahead of 171's rerun loop. The brief's cause section must be filled in and re-pinned before briefed. |
| 172 | Board-held sign-out wait times out under gate load: find and fix the cause, not the timeout (P19 366, mos-0858) | sage; reviewers darkwing | #1670 | done | 171 done | Darkwing approves the candidate manifest; the cause and trace are in the packet; webui suite 10 runs green under gate load and full gate green on Sage's gate (sage) | `docs/plans/2026-10-19_board-held-signout-flake.md` § Brief: the board-held sign-out wait times out under gate load | Landed be10e0c83 on 7f38a2f54, a cherry-pick of 15c3d8ca1 (base 164e1f97f). range-diff 164e1f97f..15c3d8ca1 vs 7f38a2f54..be10e0c83: 1 = 1. patch-id --stable fb6a65e7ec1d on both. packages/ tree equals 15c3d8ca1, whose full gate passed (sage-r172 gate-run1.txt); the commits between are packet, queue and SESSIONS only. Darkwing approve 29207, rev 2018. D1/D2 fixed in 7f38a2f54. Live only after a re-pin. |
<!-- mosaic-queue:end -->
+80 -9
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 2017,
"revision": 2020,
"rows": [
{
"id": 1,
@@ -17997,7 +17997,7 @@
"closes": [
1670
],
"state": "in-review",
"state": "done",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -18048,18 +18048,24 @@
}
],
"duplicateRisk": false,
"receipts": []
"receipts": [
{
"reviewer": "darkwing",
"op": "darkwing-r172-r1-verdict",
"at": "2026-10-19T20:30:23.224Z",
"verdict": "approve",
"comment": 29207,
"candidate": "278b0effc90baf0f9f32faa3e0269baebe89edda8e88e635fc092afbfd50477c"
}
]
}
]
},
"claim": {
"seat": "sage",
"op": "sage-r172-start"
},
"note": "mos-0858: if row 171's gate trips on this flake twice, this row lands ahead of 171's rerun loop. The brief's cause section must be filled in and re-pinned before briefed.",
"claim": null,
"note": "Landed be10e0c83 on 7f38a2f54, a cherry-pick of 15c3d8ca1 (base 164e1f97f). range-diff 164e1f97f..15c3d8ca1 vs 7f38a2f54..be10e0c83: 1 = 1. patch-id --stable fb6a65e7ec1d on both. packages/ tree equals 15c3d8ca1, whose full gate passed (sage-r172 gate-run1.txt); the commits between are packet, queue and SESSIONS only. Darkwing approve 29207, rev 2018. D1/D2 fixed in 7f38a2f54. Live only after a re-pin.",
"blockedReason": null,
"createdAt": "2026-10-19T19:21:45.951Z",
"updatedAt": "2026-10-19T20:19:53.037Z",
"updatedAt": "2026-10-19T20:34:56.110Z",
"updatedBy": "sage"
}
],
@@ -71367,6 +71373,71 @@
"receipt": "ok sage-r172-inreview.outcome rev 2017 row 172 round 1 request sage-r172-inreview posted comment 29205"
},
"viewSha": "599e088eb11c88f059ce32807645b7ea40dfd64fa04804bedecb6f524308a306"
},
{
"rev": 2018,
"op": "darkwing-r172-r1-verdict",
"verb": "review-record",
"args": {
"id": 172,
"verdict": "approve",
"comment": 29207,
"candidate": "278b0effc90baf0f9f32faa3e0269baebe89edda8e88e635fc092afbfd50477c"
},
"by": "darkwing",
"at": "2026-10-19T20:30:23.224Z",
"semantics": 2,
"result": {
"row": 172,
"round": 1,
"verdict": "approve",
"receipt": "ok darkwing-r172-r1-verdict rev 2018 row 172 round 1 approve by darkwing (comment 29207)"
},
"viewSha": "7173c623e46bbe71ba4c416343ca91f62bf11c015a4e3dd76dc7c26099936ffb"
},
{
"rev": 2019,
"op": "sage-r172-landing-note",
"verb": "note",
"args": {
"id": 172,
"text": "Landed be10e0c83 on 7f38a2f54, a cherry-pick of 15c3d8ca1 (base 164e1f97f). range-diff 164e1f97f..15c3d8ca1 vs 7f38a2f54..be10e0c83: 1 = 1. patch-id --stable fb6a65e7ec1d on both. packages/ tree equals 15c3d8ca1, whose full gate passed (sage-r172 gate-run1.txt); the commits between are packet, queue and SESSIONS only. Darkwing approve 29207, rev 2018. D1/D2 fixed in 7f38a2f54. Live only after a re-pin."
},
"by": "sage",
"at": "2026-10-19T20:34:32.714Z",
"semantics": 2,
"result": {
"row": 172,
"field": "note",
"receipt": "ok sage-r172-landing-note rev 2019 row 172 note"
},
"viewSha": "719b66a8a161fcb097e478d49fd3f5e7aa3e067f4469bea6d789f20083b21974"
},
{
"rev": 2020,
"op": "sage-r172-done",
"verb": "move",
"args": {
"id": 172,
"to": "done",
"reason": null,
"candidate": null,
"evidence": null,
"issue": null
},
"by": "sage",
"at": "2026-10-19T20:34:56.110Z",
"semantics": 2,
"result": {
"row": 172,
"from": "in-review",
"to": "done",
"round": 1,
"issue": null,
"candidate": null,
"receipt": "ok sage-r172-done rev 2020 row 172 in-review→done round 1"
},
"viewSha": "3c24e59e8a395a5ae371b83c3f88b571a308a75ef11487e10e27fa8772692345"
}
]
}