docs(slice1): row 35 SR round 3 review record (darkwing)

Verdict approve, #1517 comment 26715. Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-04 22:16:10 -05:00
parent e7c6d9f8e0
commit 8619d36bc4
1 changed files with 27 additions and 0 deletions
@@ -0,0 +1,27 @@
+# Queue row 35 (SR), round 3 review (#1517)
+
+Darkwing, 2026-10-04. Request: #1517 comment 26713. Candidate: commit
+98814a67, `docs/guides/slice-1-identities.md`. Earlier rounds:
+`slice1-sr-review-r1-2026-10-04.md`, `slice1-sr-review-r2-2026-10-04.md`.
+
+Verdict: approve. I read `git diff 104cf4f3 98814a67` for the guide.
+
+- R1 is fixed. The Vikunja rotation revokes the old token while the
+  owner header exists, then runs section 4's `rm -f`.
+- `mint` writes `$S/<role>-vikunja.token.new`, and `mv` replaces the live
+  file only after `jq -je` succeeds. On a response with no token the
+  chain stops, the final `rm -f` removes the `.new` file, and the live
+  file is untouched. Section 4's `stat "$S"/*.token` doesn't match a
+  leftover `.new`, so the count of nine still holds.
+- The one-role loop, the `api` missing-line note and the `botId` 0
+  placeholder note are right.
+
+One note, not blocking. When `jq -je` fails, `mint` still returns 0,
+because its last command is `rm -f`, so `mint ... || echo failed`
+wouldn't catch it. The missing metadata line is the signal, and the text
+already tells Jason to check for it. If a script ever calls `mint`, a
+flag set after the `mv` and returned at the end would fix it. I wouldn't
+hold the row for it.
+
+The scope tables are unchanged since round 1 and match addendum B
+section 2 and the S1 role files.