mosaicstack/stack
1
0
Fork 1
Code Issues 203 Pull Requests 14 Actions Packages Projects Releases 15 Wiki Activity

test: close W-0R review findings — assert the omission notice, skip chmod simulations under root

Browse Source 
The independent W-0R review of 3592b92e passed but left two PLAUSIBLE
findings: the stderr notice for a legitimately-omitted operator source was
claimed and never asserted (a silent omission is the original defect in
miniature), and the chmod 0o000 unreadable simulations fail spuriously when
euid==0 (CAP_DAC_OVERRIDE). Falsifier for the new assertion: deleting the
notice block turns the suite red (failures=3); restoring returns green.

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01EHYXhcCQsL3J1Lnm7EraGq
This commit is contained in:
Jason Woltje
2026-08-07 12:25:24 -05:00
co-authored by Claude Fable 5
parent 3592b92e04
commit 87ef1c1439
1 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/mosaic/src/lease-broker/promotion_binding_unittest.py
+17 -1
View File
@@ -26,6 +26,8 @@ collapsing the two is what let a permission change quietly shrink the law.
from __future__ import annotations from __future__ import annotations
import contextlib
import io
import os import os
import sys import sys
import tempfile import tempfile
@@ -45,6 +47,12 @@ REQUIRED = frozenset(lease_promote.REQUIRED_SOURCES) | {RUNTIME_CONTRACT}
# exists to catch. # exists to catch.
OPTIONAL = tuple(s for s in ALL_SOURCES if s not in REQUIRED) OPTIONAL = tuple(s for s in ALL_SOURCES if s not in REQUIRED)
# chmod 0o000 does not deny root (CAP_DAC_OVERRIDE), so the unreadable
# simulations would fail spuriously in a root container.
runs_unprivileged = unittest.skipIf(
os.geteuid() == 0, "chmod 0o000 cannot make a file unreadable to root"
)
class PromotionBindingTest(unittest.TestCase): class PromotionBindingTest(unittest.TestCase):
def setUp(self) -> None: def setUp(self) -> None:
@@ -106,13 +114,19 @@ class PromotionBindingTest(unittest.TestCase):
with self.subTest(source=source_id): with self.subTest(source=source_id):
self.reset_home() self.reset_home()
(self.root / source_id).unlink() (self.root / source_id).unlink()
bound = self.source_ids() notice = io.StringIO()
with contextlib.redirect_stderr(notice):
bound = self.source_ids()
self.assertNotIn(source_id, bound) self.assertNotIn(source_id, bound)
for required in lease_promote.REQUIRED_SOURCES: for required in lease_promote.REQUIRED_SOURCES:
self.assertIn(required, bound) self.assertIn(required, bound)
# A silent omission is the original defect in miniature: the
# narrower binding must announce itself.
self.assertIn(source_id, notice.getvalue())
# --- unreadable is never the same as absent ----------------------------- # --- unreadable is never the same as absent -----------------------------
@runs_unprivileged
def test_unreadable_source_is_refused_even_when_optional(self) -> None: def test_unreadable_source_is_refused_even_when_optional(self) -> None:
for source_id in ALL_SOURCES: for source_id in ALL_SOURCES:
with self.subTest(source=source_id): with self.subTest(source=source_id):
@@ -124,6 +138,7 @@ class PromotionBindingTest(unittest.TestCase):
# --- the exact measured regression -------------------------------------- # --- the exact measured regression --------------------------------------
@runs_unprivileged
def test_single_readable_source_cannot_promote(self) -> None: def test_single_readable_source_cannot_promote(self) -> None:
"""The observed failure: only USER.md readable produced a valid binding.""" """The observed failure: only USER.md readable produced a valid binding."""
for source_id in ALL_SOURCES: for source_id in ALL_SOURCES:
@@ -132,6 +147,7 @@ class PromotionBindingTest(unittest.TestCase):
with self.assertRaises(lease_promote.IncompleteBinding): with self.assertRaises(lease_promote.IncompleteBinding):
self.build() self.build()
@runs_unprivileged
def test_no_source_readable_cannot_promote(self) -> None: def test_no_source_readable_cannot_promote(self) -> None:
for source_id in ALL_SOURCES: for source_id in ALL_SOURCES:
(self.root / source_id).chmod(0o000) (self.root / source_id).chmod(0o000)