gosalyn: row 231 BUILD.md, base after 212 landed ee7b2f137, patch-id 45911915a9ee unchanged, singles 60/0 (sage-1886, sage-1889)

2026-10-21 04:21:22 -05:00
parent 3647a5a930
commit 88daaac505
1 changed files with 43 additions and 0 deletions
@@ -0,0 +1,43 @@
+# Row 231 build notes, C2-01b survey escapes, list item lines and attachment embeds (#1733)
+
+Brief: docs/plans/2026-10-20_case2-rows.md "C2-01b survey escapes, list item lines and attachment embeds",
+blob 16847e94ae17. These are Webby's row 212 notes N1 to N3 (webby-0041), split out by sage-1517.
+
+## Base
+
+First built as 777f7358a on 212's first round bdf18272a. 212 landed as ee7b2f137 (sage-1886), so the
+commit was cherry-picked onto refactor fefd54e13 under the new branch gosalyn/c2-01b-r2 as 3647a5a93.
+`git patch-id --stable` is 45911915a9ee before and after. packages/library is the same in bdf18272a
+and in 212's landed round a2c72ac95, so nothing the commit touches moved under it.
+
+## What changed
+
+- N1, `packages/library/src/survey.mjs`: JSON strings escape C0 controls but leave DEL, C1 and bidi
+  controls raw. The new `quote()` escapes those too, and folder names print through it.
+- N2, `packages/library/src/reader.mjs`: front matter parsing records each block list item's line, and
+  a link in a block list carries its item's line instead of its key's.
+- N3, `links.mjs` exports `isAttachment` through `index.mjs`. A wikilink or embed whose target's last
+  segment ends in an extension other than `.md` is an attachment. The reader neither resolves nor
+  indexes it, and it raises no problem. The survey prints a count of body links to attachments.
+- `packages/library/README.md` describes all three, and the links, reader and survey tests cover them.
+
+## Outside readers
+
+`packages/cli/tests/stack-copy.test.mjs:38` checks only that `packages/library/src/index.mjs` exists, and
+`scripts/mosaic:41` execs `survey.mjs`. No test pins a hash of a library file.
+
+## Tests
+
+On 3647a5a93, slot grant sage-1889, 09:20:01Z to 09:20:14Z, after a busy check. One `node --test` per
+file, every rc 0.
+
+| File | pass | fail |
+|---|---|---|
+| packages/library/tests/links.test.mjs | 7 | 0 |
+| packages/library/tests/mapping.test.mjs | 7 | 0 |
+| packages/library/tests/reader.test.mjs | 13 | 0 |
+| packages/library/tests/render.test.mjs | 11 | 0 |
+| packages/library/tests/survey.test.mjs | 6 | 0 |
+| packages/cli/tests/stack-copy.test.mjs | 16 | 0 |
+
+Total: 60 pass, 0 fail, 0 cancelled, summed by awk.