docs(records): row 5 round 1 review files, record-issue gap in DEFERRED

Both reviewers requested changes (26681, 26683). Darkwing's verdict landed on #1508; pointer 26685 on #1507. Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-04 14:01:37 -05:00
parent 14562ac227
commit 8a3e672f4a
4 changed files with 436 additions and 0 deletions
@@ -464,3 +464,5 @@ are never rewritten or removed; corrections are new entries.
 2026-10-04T08:11:41Z | Dewey (T3 Claude Code) | CHAT-03 I1 build, row 5 (#1507) | candidate frozen: manifest agents/dewey/work/chat-03/I1-manifest.sha256 (1404341e, 27 files), packet BUILD-I1.md; all acceptance suites green, 41/41 mutants killed after 7 kill tests; row 5 in-review round 1, request comment 26671 (rev 52); reviewers darkwing, filbert; nothing committed or pushed
 2026-10-04T18:45:43Z | Sage (T3 Claude Code, thread 1ef1e4f8) | foundation direction (Jason's KPI message) | proposal docs/plans/2026-10-04_foundation-direction.md: five questions answered, brain dump mapped against what exists, Vikunja integrate-not-annex, slice 1 order; row 32 park recommended; needs Jason's ratification before any goal moves; row 5 I1 reviews pinged to darkwing and filbert
 2026-10-04T18:52:41Z | Sage (T3 Claude Code, thread 1ef1e4f8) | row 5 r1 routing (#1507) | pushed darkwing's queue commit 5a5013c4 (verify rev 53 ok); woke Dewey (84fb346c, stopped) with B1/B2 rework under decision 42, and Filbert's session restarted on my INFO; Sage-launched sessions running: 2 of 2 (dewey, filbert); one round 2 to both reviewers after rework
+2026-10-04T19:00:33Z | Filbert (T3 Claude Code, thread 9cb9731e) | row 5 CHAT-03 I1 review round 1 (#1507) | candidate 1404341e (27 files) verified frozen in a scratch clone and an export; §10 suites green (conductor 17/17 needs a git clone, queue 27 + 2 canonical-only skips); changes requested: B1 terminal Enter concatenation, B2 split paste-start ESC, B3 parallel force-stop escalations corrupt claim phaseStarted, B4 no test kills decision 34, B5 K12 freeze unproven (no-freeze mutant 18/18), B6 K15 missing-path case absent (ENOENT mutant 18/18); 20 notes; comment 26683, recorded rev 54 (filbert-5-r1-changes), committed f0b13a2f via queue-commit.sh, not pushed; review file agents/filbert/work/chat-03-i1-review-r1-2026-10-04.md (0444, uncommitted); REVIEW-RESULT to Dewey, copy to Sage; Darkwing's 26681 is on #1508, not the round's #1507 (flagged to Sage); rev 55 (jason park row 32) left uncommitted
+2026-10-04T19:01:37Z | Sage (T3 Claude Code, thread 1ef1e4f8) | foundation ratified, row 32 parked, row 5 r1 records | Jason ratified the foundation direction (lead decision 44; goals page superseded in part); row 32 parked on Jason's word (rev 55, 3270cc4e); row 5 r1 closed with both reviewers requesting changes (darkwing 26681, filbert 26683), both review files committed; pointer comment 26685 on #1507 for darkwing's verdict that landed on #1508; DEFERRED item for review record not checking the comment's issue
@@ -165,6 +165,15 @@ at every gate. Started 2026-09-12 during the control board MVP.
  no `timeout` on PATH the queue issue calls report "credential or Gitea
  request failure". Optional test and clearer message. Filbert, E r2.
  (2026-09-27, #1508)
+- **`review record` doesn't check which issue the verdict comment is on.**
+  Row 5 round 1's request (26671) and Filbert's verdict (26683) are on
+  #1507. Darkwing's verdict 26681 went to #1508, and `review record`
+  accepted it, because only `review resolve` reads the comment back
+  (`checkComment` in `packages/queue/src/review.mjs`). The receipt
+  points at a real comment on the wrong issue. Sage posted a pointer on
+  #1507 (comment 26685). Fix: have `record` check the comment's issue and author the way
+  `resolve` does, or refuse a comment id it can't verify. Found by
+  Filbert. (2026-10-04, #1508)

 ## Queue