PR 1838 review P3s (#725): approved wording in the tasks requirements test header, REBASE-1.19 location correction

GPT review of the 1.19 rebase found the test header still called the PRD a candidate and the rebase record placed lines 793 and 645 in the wrong requirements. Comment and record only; no assertion changes.
This commit is contained in:
jason.woltje committed 2026-11-02 17:29:16 -06:00
1 parent 31222d81d7
commit 9256129228
3 files changed
+9 -1

No files matched your search

@@ -141,3 +141,9 @@ Then `git checkout -- packages/tasks/requirements.json` restored `"version": "1.
4. Line 7 says "approved the exact text at `e5400456`". That is the PR branch commit, which is not on `refactor`. Its rebased copy is `259e59d40`. I kept the sentence verbatim, since the brief allows no other wording change. The lead may want it to point to `259e59d40`.
5. The commit messages carry no attribution lines. The harness asked for a Co-Authored-By line. The user's standing rule against attribution lines in any commit governs, and I followed it.
6. The branch is `t3/pr1838-prd119-rebase`. I did not check out or rename anything.
## Correction (2026-11-02, lead)
The label list above names two requirements wrongly. PRD line 793 is in REQ-TRUST-2, not REQ-WAIT-1; lines 804
and 809 are in REQ-WAIT-1. PRD line 645 is in REQ-CRED-4, not REQ-GRANT-1. The PRD text and the moved labels are
correct. Found by the GPT review of the rebase.
+2
View File
@@ -1955,3 +1955,5 @@ are never rewritten or removed; corrections are new entries.
2026-11-02 | Lead sub-agent (Claude Opus 5.5, under T3 c5c1e8ba) | Row 227 R2 (#1728): standalone Case 2 suite, Opus review P1, P2 and P3 | Code 04e1ce24c on t3/row227-r2-fix: controller ties removed, suite green twice (4.96 s, 5.74 s), env control clean, 5 of 6 mutants red, tip check green. Not pushed; record in queue-227 BUILD.md "R2".
2026-11-02 | Lead sub-agent (Claude Opus 5.5, under T3 c5c1e8ba) | Row 227 R3 (#1728): sandbox guard, literal cwd sweep and TMPDIR limit for test-case2.sh | Code abc66a598 on t3/row227-r3-fix: P1 to P3 fixed, 40 no-signal checks pass, namespace failure controls exit 2 with nothing started, suite green twice (5.64 s, 5.20 s), tip check green. Not pushed; record in queue-227 BUILD.md "R3: the sandbox guard".
2026-11-02 | Lead (Claude Opus 5.5, T3 c5c1e8ba) | PR 1838 (#725) landing: disk-space governance PRD as version 1.19 | Merge 31222d81d of the Haiku rebase 3d00efe39 onto ea02c061e; GPT review APPROVE, P3s fixed here: approved wording in the tasks requirements test header, location correction in REBASE-1.19.md. Full gate before push.
+1 -1
View File
@@ -5,7 +5,7 @@ import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { fileURLToPath } from 'node:url';
import { loadRequirements, checkRequirements, RequirementsError, REQUIREMENTS_FILE } from '../src/requirements.mjs';
// Row 90 (#1584): requirements.json against the PRD candidate it names. The PRD's **REQ-...**
// Row 90 (#1584): requirements.json against the approved PRD it names. The PRD's **REQ-...**
// bullets are the source; the list must hold the same ids in the same order, and the PRD's
// status line must give the list's version.
const list = loadRequirements();