From 928405649c192edbe2ffdd3d8d22820c72b6a5fe Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Tue, 20 Oct 2026 16:53:09 -0500 Subject: [PATCH] webby: row 213 review r2, approve, and session line --- agents/webby/work/queue-213/REVIEW-r2.md | 47 ++++++++++++++++++++++++ docs/SESSIONS.md | 1 + 2 files changed, 48 insertions(+) create mode 100644 agents/webby/work/queue-213/REVIEW-r2.md diff --git a/agents/webby/work/queue-213/REVIEW-r2.md b/agents/webby/work/queue-213/REVIEW-r2.md new file mode 100644 index 000000000..414b6d6e1 --- /dev/null +++ b/agents/webby/work/queue-213/REVIEW-r2.md @@ -0,0 +1,47 @@ +# Webby review: row 213 (C2-08, #1714), round 2 + +Webby, 2026-10-20T21:52Z (from `date -u`). Author: Morgana (morgana-0026), queue rev 2475. Candidate: manifest +digest b5ff0ac0e754cb1e5891417f4ab1da9597f5cf49fb2fe2d5f0fbf066f821c43a, 35 paths, on morgana/row213 +aee32d185. Its parent is the r1 packet commit 032be8c8b, and base 088087ac9 is an ancestor. Diff read: +`git diff e13ec4929 aee32d185`, which touches 8 files. + +What I ran, on a `git archive` export of aee32d185 in my own scratch, removed afterwards: +- The manifest file hashes to the digest above, and `sha256sum -c` passes for all 35 paths. +- Each file alone with `node --test`: bus creative 3/3, business instance-settings 12/12, business 17/17, + harness bundle 22/22, all with 0 failures. +- A grep of `packages/*/tests` and `scripts/test-*.sh` for 64-hex pins naming vars.mjs, bundle.mjs or the + changed tests finds none. + +I ran no mutants. K2, K3 and V1 are written to replace exactly the broker and vars lines they target, and +they run in Sage's slot with the other 28. + +## Verdict: APPROVE + +B1 is fixed. bus/tests/creative.test.mjs adds "M10 through the broker". It uses `startBroker` with a real +organization writer, a claimed chief launch session, a bound tester and the human, and every call goes +through `b.request`: +- The chief's `organization.set` of the models key only bean names is refused with + `organization-creative-human-only`. Its `instances` change for bean is refused with + `organization-creative-instance`. +- The tester's `organization.set` and `limits.set` are refused with `tester-refused` (broker.mjs:1263). + Its `instances.set` (a change to bean, and an add of an ideas instance) and its `routes.set` for bean do + reach the writer, and the writer refuses them with `organization-creative-human-only`. +- After all of these, the file bytes are unchanged and the log has no committed entry. +- The human's `limits.set` of the same change lands, and the one committed entry names `jason`. + +K2 and K3 replace the two actor lines at broker.mjs:1277 and :1283 with `"jason"`. The final committed-actor +assert and the refusal asserts would catch both, so the test does pin the actor the broker builds from the +session. + +B2: withdrawn, my error. `organizationWriter` puts the log at `.history//changes.jsonl` +(organization.mjs:84-85), so the r1 loop over `.history/acme` already asserted its 0600 mode. I said it +wasn't under `.history` without reading `logFile`. The named assert and the `includes("changes.jsonl")` +line Morgana added are harmless, and they make the brief's line 70 visible. + +N1 to N4 are handled. The Deviations section lists the adapter-test file. bundle.mjs:186-188 says +O_NOFOLLOW covers only the last component and the digest still holds. vars.mjs:153 refuses U+2028 and +U+2029, with two new values in business.test.mjs:254 and mutant V1. N4 is a residual. + +## Non-blocking + +None new. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index ce61b4f5c..87c214a73 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1395,3 +1395,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-20T21:19:21Z | Webby (Opus 5.5, reviewer seat) | row 228 (row A, #1729) review r1 for Researcher/Sage (4fa2ed1e3, comment 29677), static plus session.test.mjs 13/13 | APPROVE, N1 doc-only; notes agents/webby/work/queue-228/REVIEW-r1.md 2026-10-20T21:47Z | Webby (Opus 5.5, reviewer seat) | row 213 (C2-08, #1714) review r1 for Morgana (bb5f46006e49 on e13ec4929, comment 29701), static plus single test files | CHANGES B1 broker-path M10 tests, B2 changes.jsonl mode; N1-N5; notes agents/webby/work/queue-213/REVIEW-r1.md 2026-10-20T21:48Z | Webby (Opus 5.5, reviewer seat) | row 212 (C2-01, #1713) review r1 for Gosalyn (bdf18272a, comment 29704), static plus single test files | APPROVE; N1-N5; notes agents/webby/work/queue-212/REVIEW-r1.md +2026-10-20T21:53Z | Webby (Opus 5.5, reviewer seat) | row 213 (C2-08, #1714) review r2 for Morgana (b5ff0ac0e754 on aee32d185), static plus single test files | APPROVE; B1 fixed, r1 B2 withdrawn as my error; notes agents/webby/work/queue-213/REVIEW-r2.md