fix(gateway): filter projects by ownership — close data privacy leak (#202)
Some checks failed
ci/woodpecker/push/ci Pipeline failed
Some checks failed
ci/woodpecker/push/ci Pipeline failed
Co-authored-by: Jason Woltje <jason@diversecanvas.com> Co-committed-by: Jason Woltje <jason@diversecanvas.com>
This commit was merged in pull request #202.
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
import { eq, type Db, projects } from '@mosaic/db';
|
||||
import { eq, or, inArray, type Db, projects, teamMembers } from '@mosaic/db';
|
||||
|
||||
export type Project = typeof projects.$inferSelect;
|
||||
export type NewProject = typeof projects.$inferInsert;
|
||||
@@ -9,6 +9,31 @@ export function createProjectsRepo(db: Db) {
|
||||
return db.select().from(projects);
|
||||
},
|
||||
|
||||
/**
|
||||
* Return only the projects visible to a given user:
|
||||
* – projects directly owned by the user (ownerType = 'user', ownerId = userId), OR
|
||||
* – projects owned by a team the user belongs to (ownerType = 'team', teamId IN user's teams)
|
||||
*/
|
||||
async findAllForUser(userId: string): Promise<Project[]> {
|
||||
// Fetch the team IDs the user is a member of.
|
||||
const memberRows = await db
|
||||
.select({ teamId: teamMembers.teamId })
|
||||
.from(teamMembers)
|
||||
.where(eq(teamMembers.userId, userId));
|
||||
|
||||
const teamIds = memberRows.map((r) => r.teamId);
|
||||
|
||||
if (teamIds.length === 0) {
|
||||
// No team memberships — return only directly owned projects.
|
||||
return db.select().from(projects).where(eq(projects.ownerId, userId));
|
||||
}
|
||||
|
||||
return db
|
||||
.select()
|
||||
.from(projects)
|
||||
.where(or(eq(projects.ownerId, userId), inArray(projects.teamId, teamIds)));
|
||||
},
|
||||
|
||||
async findById(id: string): Promise<Project | undefined> {
|
||||
const rows = await db.select().from(projects).where(eq(projects.id, id));
|
||||
return rows[0];
|
||||
|
||||
Reference in New Issue
Block a user