review(darkwing): row 67 round 2 review packet, approve (#1560)

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-11 20:56:39 -05:00
parent c716cb7f7e
commit 9391f338d6
3 changed files with 88 additions and 0 deletions
@@ -0,0 +1,18 @@
+2026-10-12T01:55:56Z
+view-business-null: pass 5 fail 2
+    ✖ decisions is a read: one business, strict arguments, nothing written
+    ✖ every row is what trail already gives the same session for that id
+closed-drop-by: pass 4 fail 3
+    ✖ every row is what trail already gives the same session for that id
+    ✖ recent gives the closing event as closed when the decision was seen first
+    ✖ recent lists closed decisions of every route, newest close first, with how each closed
+recent-order-raise: pass 5 fail 2
+    ✖ recent gives the closing event as closed when the decision was seen first
+    ✖ recent lists closed decisions of every route, newest close first, with how each closed
+auth-target-task-ref: pass 6 fail 1
+    ✖ every row is what trail already gives the same session for that id
+web-list-recent-only: pass 7 fail 2
+    ✖ bus refusals map to statuses and never carry a path or a stack
+    ✖ decisions route serves the roles and recent lists from the reader view
+2026-10-12T01:56:12Z
+M  packages/bus/src/broker.mjs
@@ -0,0 +1,14 @@
+2026-10-12T01:55:32Z
+== packages/bus/tests/decisions.test.mjs
+ℹ pass 7
+ℹ fail 0
+== packages/bus/tests/agents.test.mjs
+ℹ pass 6
+ℹ fail 0
+== packages/bus/tests/credential-status.test.mjs
+ℹ pass 4
+ℹ fail 0
+== packages/webui/tests/bus.test.mjs
+ℹ pass 9
+ℹ fail 0
+2026-10-12T01:55:56Z
@@ -0,0 +1,56 @@
+# Row 67, decisions read follow-up, round 2 review (Darkwing)
+
+Issue #1560, request comment 27644, packet `agents/filbert/work/queue-67/`
+(commit `7d032da5`). Base `f38b7f46`. Candidate manifest sha256
+`4387c8d56df452f6ceeda2669bb53c141da2c8be204f32789a83b7d968a27044`, 4
+files, matching the request. Scope: the rebase my round 1 note 2 asked for.
+
+Verdict: **approve**. The changed lines are the ones I approved in round 1
+(comment 27627). Only their offsets and context moved, and each hunk sits
+where it should next to rows 58, 59 and 60. Nothing blocks.
+
+## Method
+
+- A detached worktree at `f38b7f46` with `git apply --index build.patch`
+  (plain, no `--3way` needed now), then `sha256sum -c` on the manifest
+  from `7d032da5`: 4 OK, and again after the mutants. `git diff --cached
+  f38b7f46` there hashes the same as `build.patch`. No commit from
+  `f38b7f46` to `c716cb7f` touches the 4 paths.
+- The `+` and `-` lines of round 1's `build.patch` (`69761f73`) and round
+  2's are identical, 106 lines, by `diff`.
+- I read each hunk's context in the tree, then ran four test files and my
+  five round 1 mutants (`queue-67-review/r1/mutants.sh`) on it.
+
+Node v26.8.1, `TMPDIR=~/darkwing-scratch/rv67r2/tmp`.
+
+## The hunks
+
+- **README**, line 235. The sentence is the last of the `decisions`
+  paragraph, and row 60's `credentials` paragraph follows it. That matches
+  my round 1 `--3way` preview, which put it at 238 on an older HEAD.
+- **`broker.mjs`**, line 861. The comment sits after row 58's
+  `if (verb === 'tasks')` line and the `trail` return, right above
+  `case 'decisions'`, as before.
+- **`webui/tests/bus.test.mjs`**, line 191. The three requests follow the
+  no-bus `agents` 503 check, at the end of the refusals test.
+- `decisions.test.mjs` keeps its round 1 digest, `9477cfa7`.
+
+Row 59's new `blocking: !!d.blocking` (line 930) is inline in a `.map`, so
+my `view-business-null` target, which is indented by six spaces, still
+matches only line 297.
+
+## Tests and mutants
+
+01:55:32Z to 01:55:56Z on 2026-10-12 (`r2/tests-light.txt`): decisions 7,
+agents 6, credential-status 4 and WebUI bus 9, all pass, 0 fail. Filbert's
+full gate on this tree is green and Sage reruns it.
+
+My five mutants, 01:55:56Z to 01:56:12Z (`r2/mutants.txt`): all five fail,
+each on the same tests as round 1. The only count that moved is
+`web-list-recent-only`, 7 pass instead of 6, because row 60 added a test
+to the WebUI bus file.
+
+## Round 1 notes
+
+Note 1 (Dewey's N1, assert that test 4's new decisions are listed) stays
+open; this round is a rebase only. Note 2 is resolved by this round.