queue: row 113 approved and done (#1607, revs 1125-1126)
Filbert's rev 1125 (round 1 approve, comment 28407) rides with Sage's 1126 (done). Landed as a5b8a99a1.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
+2
-2
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
|
|||||||
|
|
||||||
<!-- mosaic-queue:begin -->
|
<!-- mosaic-queue:begin -->
|
||||||
|
|
||||||
Generated from `docs/plans/queue.json` revision 1124 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
|
Generated from `docs/plans/queue.json` revision 1126 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
|
||||||
|
|
||||||
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|
||||||
|---|---|---|---|---|---|---|---|---|
|
|---|---|---|---|---|---|---|---|---|
|
||||||
@@ -149,7 +149,7 @@ Generated from `docs/plans/queue.json` revision 1124 by `queue render`. Do not e
|
|||||||
| 110 | Bus tester identity for PM tests, replacing the tmux path (Q134 A) | darkwing; reviewers filbert, sage | #1604 | done | 106 done, 109 done | Filbert and Sage approve on #1604 naming the manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy, re-pin and bus restart under Mos's go; tmux path retired by Mos (sage) | `docs/plans/2026-10-13_pm-tester-and-fresh-state.md` § Bus tester identity for PM tests | Landed 179697a8a (round 2 manifest bdaf7f47, verify-commit ok), pushed; #1604 closed (28368). Not live: needs new copy, re-pin and bus restart under Mos's go, and bus.tester true in the business file, held under decision 104 until Q135. Gate flakes outside the row: Vikunja #262, #263. |
|
| 110 | Bus tester identity for PM tests, replacing the tmux path (Q134 A) | darkwing; reviewers filbert, sage | #1604 | done | 106 done, 109 done | Filbert and Sage approve on #1604 naming the manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy, re-pin and bus restart under Mos's go; tmux path retired by Mos (sage) | `docs/plans/2026-10-13_pm-tester-and-fresh-state.md` § Bus tester identity for PM tests | Landed 179697a8a (round 2 manifest bdaf7f47, verify-commit ok), pushed; #1604 closed (28368). Not live: needs new copy, re-pin and bus restart under Mos's go, and bus.tester true in the business file, held under decision 104 until Q135. Gate flakes outside the row: Vikunja #262, #263. |
|
||||||
| 111 | Bus host start: release host.lock after the broker's reply and handle the child error event (Dewey 28319 a, Darkwing's async error) | darkwing; reviewers dewey | #1605 | done | — | dewey approves on #1605 naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before and after landing; live only with a new copy, re-pin and bus restart under Mos's go (sage) | `docs/plans/2026-10-13_landing-follow-ups.md` § Bus host start: release after the broker's reply, and the child `error` event | Landed 9774d70db, pushed. verify-commit ok (2 paths). Sage gate: every package suite green; test-queue failed review.test.mjs:123 once under load, passed 28/28 on rerun (Vikunja #261). Dewey note a recorded for the next host.mjs row. #1605 comment 28342, closed. Live only after the re-pin. |
|
| 111 | Bus host start: release host.lock after the broker's reply and handle the child error event (Dewey 28319 a, Darkwing's async error) | darkwing; reviewers dewey | #1605 | done | — | dewey approves on #1605 naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before and after landing; live only with a new copy, re-pin and bus restart under Mos's go (sage) | `docs/plans/2026-10-13_landing-follow-ups.md` § Bus host start: release after the broker's reply, and the child `error` event | Landed 9774d70db, pushed. verify-commit ok (2 paths). Sage gate: every package suite green; test-queue failed review.test.mjs:123 once under load, passed 28/28 on rerun (Vikunja #261). Dewey note a recorded for the next host.mjs row. #1605 comment 28342, closed. Live only after the re-pin. |
|
||||||
| 112 | Decision raise takes one recommendation key and says which field failed | darkwing; reviewers filbert, sage | #1606 | done | — | Filbert and Sage approve on #1606 naming the candidate manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy and bus restart under Mos's go, shared with row 110; Mos re-raises Q139/Q140 through the PM and sees it in the Inbox (sage) | `docs/plans/2026-10-14_decision-raise-recommendation.md` § Decision raise takes one recommendation key and says which field failed | Round 1: Sage's recorded approve (rev 1106, comment 28377) is superseded by changes in comment 28378. The README invalid-options row misstates the shape cases: keys() refuses a malformed option invalid-request. The queue allows one verdict per round, so round 1 must not land; round 2 carries the README fix. |
|
| 112 | Decision raise takes one recommendation key and says which field failed | darkwing; reviewers filbert, sage | #1606 | done | — | Filbert and Sage approve on #1606 naming the candidate manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy and bus restart under Mos's go, shared with row 110; Mos re-raises Q139/Q140 through the PM and sees it in the Inbox (sage) | `docs/plans/2026-10-14_decision-raise-recommendation.md` § Decision raise takes one recommendation key and says which field failed | Round 1: Sage's recorded approve (rev 1106, comment 28377) is superseded by changes in comment 28378. The README invalid-options row misstates the shape cases: keys() refuses a malformed option invalid-request. The queue allows one verdict per round, so round 1 must not land; round 2 carries the README fix. |
|
||||||
| 113 | The weekly ledger runs on current T3 and a week with more than 50 updated issues | darkwing; reviewers filbert | #1607 | in-review, round 1, request posted | 112 done | Filbert approves on #1607 naming the candidate manifest; Sage's full gate rerun at the landing target; after landing Sage runs 2026-10-04..10-10 with issues and T3 and exits 0 (sage) | `docs/plans/2026-10-14_ledger-reasoning-and-issue-pages.md` § The weekly ledger runs on current T3 and a week with more than 50 updated issues | — |
|
| 113 | The weekly ledger runs on current T3 and a week with more than 50 updated issues | darkwing; reviewers filbert | #1607 | done | 112 done | Filbert approves on #1607 naming the candidate manifest; Sage's full gate rerun at the landing target; after landing Sage runs 2026-10-04..10-10 with issues and T3 and exits 0 (sage) | `docs/plans/2026-10-14_ledger-reasoning-and-issue-pages.md` § The weekly ledger runs on current T3 and a week with more than 50 updated issues | — |
|
||||||
| 114 | Discord connector unit runs from a pinned copy | rocko; reviewers filbert | #1608 | briefed | 108 done | Filbert approves on #1608 naming the candidate manifest; Sage's full gate rerun at the landing target; Mos notices before and after (packages/discord flagged); install and restart are Mos's step after the SetSpark freeze lifts (sage) | `docs/plans/2026-10-14_discord-pinned-copy.md` § Discord connector unit runs from a pinned copy | — |
|
| 114 | Discord connector unit runs from a pinned copy | rocko; reviewers filbert | #1608 | briefed | 108 done | Filbert approves on #1608 naming the candidate manifest; Sage's full gate rerun at the landing target; Mos notices before and after (packages/discord flagged); install and restart are Mos's step after the SetSpark freeze lifts (sage) | `docs/plans/2026-10-14_discord-pinned-copy.md` § Discord connector unit runs from a pinned copy | — |
|
||||||
| 115 | A closed decision sends the raising role a message | darkwing; reviewers filbert, sage | #1609 | briefed | 113 done | Filbert and Sage approve on #1609 naming the candidate manifest; Sage's full gate rerun at the landing target; Mos notices before and after (decision 109); live only via copy, re-pin and bus restart on Mos's go (sage) | `docs/plans/2026-10-14_decision-close-message.md` § A closed decision sends the raising role a message | — |
|
| 115 | A closed decision sends the raising role a message | darkwing; reviewers filbert, sage | #1609 | briefed | 113 done | Filbert and Sage approve on #1609 naming the candidate manifest; Sage's full gate rerun at the landing target; Mos notices before and after (decision 109); live only via copy, re-pin and bus restart on Mos's go (sage) | `docs/plans/2026-10-14_decision-close-message.md` § A closed decision sends the raising role a message | — |
|
||||||
|
|
||||||
|
|||||||
+62
-9
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"version": 1,
|
"version": 1,
|
||||||
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
|
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
|
||||||
"revision": 1124,
|
"revision": 1126,
|
||||||
"rows": [
|
"rows": [
|
||||||
{
|
{
|
||||||
"id": 1,
|
"id": 1,
|
||||||
@@ -10240,7 +10240,7 @@
|
|||||||
"closes": [
|
"closes": [
|
||||||
1607
|
1607
|
||||||
],
|
],
|
||||||
"state": "in-review",
|
"state": "done",
|
||||||
"previousState": null,
|
"previousState": null,
|
||||||
"required": false,
|
"required": false,
|
||||||
"requiredSince": null,
|
"requiredSince": null,
|
||||||
@@ -10291,19 +10291,25 @@
|
|||||||
}
|
}
|
||||||
],
|
],
|
||||||
"duplicateRisk": false,
|
"duplicateRisk": false,
|
||||||
"receipts": []
|
"receipts": [
|
||||||
|
{
|
||||||
|
"reviewer": "filbert",
|
||||||
|
"op": "filbert-113-r1",
|
||||||
|
"at": "2026-10-14T16:29:25.432Z",
|
||||||
|
"verdict": "approve",
|
||||||
|
"comment": 28407,
|
||||||
|
"candidate": "4eed1d6405a505e88cde5062c61f768639d899b8f301019b1403d68fb15d9d36"
|
||||||
|
}
|
||||||
|
]
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
},
|
},
|
||||||
"claim": {
|
"claim": null,
|
||||||
"seat": "darkwing",
|
|
||||||
"op": "darkwing-113-start-1"
|
|
||||||
},
|
|
||||||
"note": null,
|
"note": null,
|
||||||
"blockedReason": null,
|
"blockedReason": null,
|
||||||
"createdAt": "2026-10-14T15:55:10.675Z",
|
"createdAt": "2026-10-14T15:55:10.675Z",
|
||||||
"updatedAt": "2026-10-14T16:26:08.082Z",
|
"updatedAt": "2026-10-14T16:35:50.295Z",
|
||||||
"updatedBy": "darkwing"
|
"updatedBy": "sage"
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"id": 114,
|
"id": 114,
|
||||||
@@ -40097,6 +40103,53 @@
|
|||||||
"receipt": "ok darkwing-113-review-1.outcome rev 1124 row 113 round 1 request darkwing-113-review-1 posted comment 28402"
|
"receipt": "ok darkwing-113-review-1.outcome rev 1124 row 113 round 1 request darkwing-113-review-1 posted comment 28402"
|
||||||
},
|
},
|
||||||
"viewSha": "a98e45561909c19e6fc03db939e7d44b5f53836c31fb63af8c542f7626cc8b3f"
|
"viewSha": "a98e45561909c19e6fc03db939e7d44b5f53836c31fb63af8c542f7626cc8b3f"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"rev": 1125,
|
||||||
|
"op": "filbert-113-r1",
|
||||||
|
"verb": "review-record",
|
||||||
|
"args": {
|
||||||
|
"id": 113,
|
||||||
|
"verdict": "approve",
|
||||||
|
"comment": 28407,
|
||||||
|
"candidate": "4eed1d6405a505e88cde5062c61f768639d899b8f301019b1403d68fb15d9d36"
|
||||||
|
},
|
||||||
|
"by": "filbert",
|
||||||
|
"at": "2026-10-14T16:29:25.432Z",
|
||||||
|
"semantics": 2,
|
||||||
|
"result": {
|
||||||
|
"row": 113,
|
||||||
|
"round": 1,
|
||||||
|
"verdict": "approve",
|
||||||
|
"receipt": "ok filbert-113-r1 rev 1125 row 113 round 1 approve by filbert (comment 28407)"
|
||||||
|
},
|
||||||
|
"viewSha": "ddfe98dc010468cf5fc566daa1b4c808a917143bd6c22652e8bfb955181c505f"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"rev": 1126,
|
||||||
|
"op": "sage-113-done",
|
||||||
|
"verb": "move",
|
||||||
|
"args": {
|
||||||
|
"id": 113,
|
||||||
|
"to": "done",
|
||||||
|
"reason": null,
|
||||||
|
"candidate": null,
|
||||||
|
"evidence": null,
|
||||||
|
"issue": null
|
||||||
|
},
|
||||||
|
"by": "sage",
|
||||||
|
"at": "2026-10-14T16:35:50.295Z",
|
||||||
|
"semantics": 2,
|
||||||
|
"result": {
|
||||||
|
"row": 113,
|
||||||
|
"from": "in-review",
|
||||||
|
"to": "done",
|
||||||
|
"round": 1,
|
||||||
|
"issue": null,
|
||||||
|
"candidate": null,
|
||||||
|
"receipt": "ok sage-113-done rev 1126 row 113 in-review→done round 1"
|
||||||
|
},
|
||||||
|
"viewSha": "1b1281f44779ab2fb8b3c55631c277e6c0e7be9178e991c11b6234adb767dc08"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user