From 96b50ba3199a36100e3cc7e91680b26c2ba0298c Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Wed, 14 Oct 2026 15:23:25 -0500 Subject: [PATCH] docs: queue revs 1183-1184, row 108 approved by Filbert (1183, Filbert's) and done (landed 0d030011a, #1602) --- docs/plans/QUEUE.md | 4 +-- docs/plans/queue.json | 69 ++++++++++++++++++++++++++++++++++++++----- 2 files changed, 63 insertions(+), 10 deletions(-) diff --git a/docs/plans/QUEUE.md b/docs/plans/QUEUE.md index d45c12fdd..123deab23 100644 --- a/docs/plans/QUEUE.md +++ b/docs/plans/QUEUE.md @@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here. -Generated from `docs/plans/queue.json` revision 1182 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. +Generated from `docs/plans/queue.json` revision 1184 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. | # | Piece | Owner | Issues | State | After | Gate | Brief | Note | |---|---|---|---|---|---|---|---|---| @@ -144,7 +144,7 @@ Generated from `docs/plans/queue.json` revision 1182 by `queue render`. Do not e | 105 | A review request says whether a reviewer is running | researcher; reviewers filbert | #1599 | done | — | filbert approves on 1599 naming the candidate manifest; bus and harness node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before and after landing, bus side live after a bus restart Mos approves (sage) | `docs/plans/2026-10-13_retest-faults.md` § A review request says whether a reviewer is running | landed 3a1e11b83 on refactor; manifest cd6d5eb3 matches; Filbert 28247; Sage gate 79e126be0+101+105 all green, task 98; broker live only at a bus restart | | 106 | Bus host lock: release on a late throw, a vanishing lock, the third racer | darkwing; reviewers dewey | #1600 | done | — | dewey approves on 1600 naming the candidate manifest; cli and harness node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before and after landing, host side live only with a new copy, re-pin and bus restart under Mos's go (sage) | `docs/plans/2026-10-13_landing-follow-ups.md` § Bus host lock: release on a late throw, a vanishing lock, the third racer | Landed 8b58cb7e4 on refactor (pushed). Dewey approve c28319 on manifest ae38cbe2; Sage gate rerun on f63c965f9+patch all green (cli 168, harness 73, release 14). Landing comment c28321, #1600 closed. Note b accepted; note a goes to one follow-up row with Darkwing's async error point. Live only via the 104+106 re-pin under Mos's go. | | 107 | Queue add: pin the retry order and drop the row history from the refusal | researcher; reviewers filbert | #1601 | done | — | filbert approves on 1601 naming the candidate manifest; queue node suite and scripts/test-queue.sh green on Sage's canonical-root gate rerun (sage) | `docs/plans/2026-10-13_landing-follow-ups.md` § Queue add: pin the retry order and drop the row history from the refusal | landed fe27adea1 (store.mjs + gate-owner.test.mjs from row107.patch, packet manifest b70dfe4a); Filbert approve round 1 comment 28286; Sage canonical-root gate on ae4ae7102+patch 22:15:55Z: queue 156/0 incl. the retried null-gate-owner add test, test-queue 30/0 with live queue verify at rev 1042 | -| 108 | Bus unit drop-in guard, script usage, and the copy wrapper | rocko; reviewers filbert | #1602 | in-review, round 1, request posted | 106 done | filbert approves on 1602 naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun; live only at the next copy and re-pin under Mos's go (sage) | `docs/plans/2026-10-13_landing-follow-ups.md` § Bus unit drop-in guard, script usage, and the copy wrapper | — | +| 108 | Bus unit drop-in guard, script usage, and the copy wrapper | rocko; reviewers filbert | #1602 | done | 106 done | filbert approves on 1602 naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun; live only at the next copy and re-pin under Mos's go (sage) | `docs/plans/2026-10-13_landing-follow-ups.md` § Bus unit drop-in guard, script usage, and the copy wrapper | — | | 109 | PM: a new run reads current launch state and task status before it plans | researcher; reviewers filbert | #1603 | done | — | Filbert approves on #1603 naming the manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy and re-pin under Mos's go (sage) | `docs/plans/2026-10-13_pm-tester-and-fresh-state.md` § A new PM run reads current launch state and task status before it plans | Landed badfa52b9, pushed. verify-commit ok (11 paths). Sage gate on 9774d70db plus row109.patch: every package suite and every script suite green on the first run, skipped 0 in bus, harness and seat. #1603 comment 28348, closed. Vikunja #259 stays open until the re-pin is live and a fresh PM run reads allowed. | | 110 | Bus tester identity for PM tests, replacing the tmux path (Q134 A) | darkwing; reviewers filbert, sage | #1604 | done | 106 done, 109 done | Filbert and Sage approve on #1604 naming the manifest; Sage's full gate rerun; Mos notices before and after; live only with a new copy, re-pin and bus restart under Mos's go; tmux path retired by Mos (sage) | `docs/plans/2026-10-13_pm-tester-and-fresh-state.md` § Bus tester identity for PM tests | Landed 179697a8a (round 2 manifest bdaf7f47, verify-commit ok), pushed; #1604 closed (28368). Not live: needs new copy, re-pin and bus restart under Mos's go, and bus.tester true in the business file, held under decision 104 until Q135. Gate flakes outside the row: Vikunja #262, #263. | | 111 | Bus host start: release host.lock after the broker's reply and handle the child error event (Dewey 28319 a, Darkwing's async error) | darkwing; reviewers dewey | #1605 | done | — | dewey approves on #1605 naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before and after landing; live only with a new copy, re-pin and bus restart under Mos's go (sage) | `docs/plans/2026-10-13_landing-follow-ups.md` § Bus host start: release after the broker's reply, and the child `error` event | Landed 9774d70db, pushed. verify-commit ok (2 paths). Sage gate: every package suite green; test-queue failed review.test.mjs:123 once under load, passed 28/28 on rerun (Vikunja #261). Dewey note a recorded for the next host.mjs row. #1605 comment 28342, closed. Live only after the re-pin. | diff --git a/docs/plans/queue.json b/docs/plans/queue.json index b2fe43b42..d85541734 100644 --- a/docs/plans/queue.json +++ b/docs/plans/queue.json @@ -1,7 +1,7 @@ { "version": 1, "canonicalRoot": "/mnt/storage/src/mosaic-stack", - "revision": 1182, + "revision": 1184, "rows": [ { "id": 1, @@ -9676,7 +9676,7 @@ "closes": [ 1602 ], - "state": "in-review", + "state": "done", "previousState": null, "required": false, "requiredSince": null, @@ -9741,18 +9741,24 @@ } ], "duplicateRisk": false, - "receipts": [] + "receipts": [ + { + "reviewer": "filbert", + "op": "filbert-108-r1", + "at": "2026-10-14T20:17:13.380Z", + "verdict": "approve", + "comment": 28489, + "candidate": "19ef7133db592787c24fa473357687a5741ccd7823627b970624c930a7611dbc" + } + ] } ] }, - "claim": { - "seat": "rocko", - "op": "rocko-108-start-20261014" - }, + "claim": null, "note": null, "blockedReason": null, "createdAt": "2026-10-13T21:57:26.020Z", - "updatedAt": "2026-10-14T20:13:21.409Z", + "updatedAt": "2026-10-14T20:22:56.065Z", "updatedBy": "sage" }, { @@ -42648,6 +42654,53 @@ "receipt": "ok sage-108-review-request-1.outcome rev 1182 row 108 round 1 request sage-108-review-request-1 posted comment 28485" }, "viewSha": "f3b06f2c061234bc494e7d09cb9defce16cfa727b58833d011a31dd8c5f8f99a" + }, + { + "rev": 1183, + "op": "filbert-108-r1", + "verb": "review-record", + "args": { + "id": 108, + "verdict": "approve", + "comment": 28489, + "candidate": "19ef7133db592787c24fa473357687a5741ccd7823627b970624c930a7611dbc" + }, + "by": "filbert", + "at": "2026-10-14T20:17:13.380Z", + "semantics": 2, + "result": { + "row": 108, + "round": 1, + "verdict": "approve", + "receipt": "ok filbert-108-r1 rev 1183 row 108 round 1 approve by filbert (comment 28489)" + }, + "viewSha": "7a83c743eea16825f95e817257cc66ee3a210a0d11e9a88b6f691e7c28667b53" + }, + { + "rev": 1184, + "op": "sage-108-land", + "verb": "move", + "args": { + "id": 108, + "to": "done", + "reason": null, + "candidate": null, + "evidence": null, + "issue": null + }, + "by": "sage", + "at": "2026-10-14T20:22:56.065Z", + "semantics": 2, + "result": { + "row": 108, + "from": "in-review", + "to": "done", + "round": 1, + "issue": null, + "candidate": null, + "receipt": "ok sage-108-land rev 1184 row 108 in-review→done round 1" + }, + "viewSha": "aa6b013a9d581880a1d1b176b3ee6134b7d5dd82e653b5830aadf5c972f83c55" } ] }