mosaicstack/stack
25
0
Fork 1
Code Issues 362 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

queue: row 77 review request round 1 as jarvis, comment 27767 (revs 678-679); carries rocko's revs 676-677 (in-review, failed request)

Browse Source 
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
jason.woltje
2026-10-12 13:40:36 -05:00
co-authored by Claude Opus 5.5
parent 436d581118
commit 974a7e436f
2 changed files with 152 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/QUEUE.md
+2 -2
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 675 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
Generated from `docs/plans/queue.json` revision 679 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---|
@@ -113,7 +113,7 @@ Generated from `docs/plans/queue.json` revision 675 by `queue render`. Do not ed
| 74 | WebUI preview: a signed-in, read-only Console behind the edge proxy | dewey; reviewers darkwing, filbert | #1568 | done | — | darkwing and filbert approve on the issue naming the candidate manifest; webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Sage starts it after landing once rev-sol-01 passes ops-01's route (decision 93) (sage) | `docs/plans/2026-10-11_webui-preview.md` § WebUI preview: a signed-in, read-only Console behind the edge proxy | Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged. |
| 75 | Console as a user service: render, install and status, Jason starts it | rocko; reviewers filbert | #1569 | done | — | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console as a user service | — |
| 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | done | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh. |
| 77 | Console pinned copy, update step and service hardening (row 75 N1-N5, Vikunja 146 147) | rocko; reviewers darkwing, filbert | #1571 | in-progress | 75 done | darkwing and filbert approve on 1571 naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing (decision 109) (sage) | `docs/plans/2026-10-12_console-pinned-copy.md` § Console pinned copy, update step and service hardening | Brief replaced by lead decision 112. Mos does the one reinstall after landing. Vikunja 146, 147, 155. |
| 77 | Console pinned copy, update step and service hardening (row 75 N1-N5, Vikunja 146 147) | rocko; reviewers darkwing, filbert | #1571 | in-review, round 1, request posted | 75 done | darkwing and filbert approve on 1571 naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing (decision 109) (sage) | `docs/plans/2026-10-12_console-pinned-copy.md` § Console pinned copy, update step and service hardening | Brief replaced by lead decision 112. Mos does the one reinstall after landing. Vikunja 146, 147, 155. |
| 78 | Claude pin default-path tests: row 72 review follow-up N1 | rocko; reviewers filbert | #1572 | done | 73 done | filbert approves on the issue naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin default-path tests | — |
| 79 | Coder grant stale text: row 73 packet follow-up | rocko; reviewers dewey | #1573 | done | 73 done | dewey approves on the issue naming the candidate manifest; tasks and business node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder grant stale text | Rev for Dewey's row 73 N1 (comment 27506): brief amended. Row 79 also pins the coder's untyped list in packages/harness/tests/tools.test.mjs with one deepEqual, records Dewey's mutants.sh header correction in the packet, and adds the harness suite to the gate. |
| 80 | Bus: list messages stranded by a holder change (row 59 review Note B) | darkwing; reviewers filbert | #1574 | briefed | 59 done | filbert approves on the issue naming the candidate manifest; bus, webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_bus-stranded-delivery.md` § Show messages stranded by a holder change | Decision 94 hold ended (cutover live 17:21Z); restarted under decision 111 and Mos sage-0091. |
docs/plans/queue.json
+150 -5
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 675,
"revision": 679,
"rows": [
{
"id": 1,
@@ -6046,7 +6046,7 @@
"closes": [
1571
],
"state": "in-progress",
"state": "in-review",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -6067,7 +6067,55 @@
"darkwing",
"filbert"
],
"review": null,
"review": {
"rounds": [
{
"n": 1,
"op": "rocko-77-review-1",
"by": "rocko",
"at": "2026-10-12T18:38:36.297Z",
"issue": 1571,
"candidate": {
"kind": "manifest",
"digest": "4927de6625a0159eb9633d679a348a77a98978cc403bd9eee78fff8c1d6482a0",
"text": "28c4708c062b752832576eb42aa1f1c9cede16f940d6d8929a4f47957c2f2b4d agents/rocko/work/queue-77/byte-check.sh\nb917b2607ae5f27a95ac09d29b8a2fdedf80069eda0beab9943e22a167250188 agents/rocko/work/queue-77/mutants.py\nff08f52d09ab3f1f9254e7afed418469fb4744a8fee3971129b62b4e2664ec5b docs/TOOLS.md\n769e8358fee021cf1a1d6cdce712549220e07491743829e657fe1ec905df86de packages/webui/README.md\nfdd202e6faa08f3b6e1784b805c6e4db5464126b8d7ed54f471cc38a524597e6 packages/webui/src/cli.mjs\n5692e797e1a1b561a218f49229c8ff297e00ea83a246ac6f828dff7c6e89afed packages/webui/src/reads.mjs\n7a449ef91310ab6b0185ab97f1720e0790adbd9a8d1d83c3c716e36da976acb5 packages/webui/systemd/mosaic-webui.service.in\n1282f274af3a1d956f4411699f884390493e0a067f3674daba86c1fad8bdce39 packages/webui/tests/pinned-copy.test.mjs\n7a22650b68a8a0502ac79b47f3d5c725c3014a78da15b2f12a979e6b6346eed6 packages/webui/tests/service.test.mjs\nc8e43013ef9b7bba28a712ba09b86903ed7a0e49906f4998ccb4fda8099043a4 scripts/webui-service.sh\n"
},
"request": "comment",
"attempts": [
{
"op": "rocko-77-review-1",
"by": "rocko",
"at": "2026-10-12T18:38:36.297Z",
"state": "failed",
"comment": null,
"transport": {
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"resolutions": []
},
{
"op": "sage-77-review-1b",
"by": "sage",
"at": "2026-10-12T18:39:42.860Z",
"state": "posted",
"comment": 27767,
"transport": {
"outcome": "posted",
"status": 201,
"comment": 27767,
"detail": "created"
},
"resolutions": []
}
],
"duplicateRisk": false,
"receipts": []
}
]
},
"claim": {
"seat": "rocko",
"op": "rocko-77-start"
@@ -6075,8 +6123,8 @@
"note": "Brief replaced by lead decision 112. Mos does the one reinstall after landing. Vikunja 146, 147, 155.",
"blockedReason": null,
"createdAt": "2026-10-11T22:46:07.285Z",
"updatedAt": "2026-10-12T18:12:39.449Z",
"updatedBy": "rocko"
"updatedAt": "2026-10-12T18:39:49.104Z",
"updatedBy": "sage"
},
{
"id": 78,
@@ -25041,6 +25089,103 @@
"receipt": "ok dewey-81-review-1.outcome rev 675 row 81 round 1 request dewey-81-review-1 posted comment 27763"
},
"viewSha": "157cde512e3fc3df2e6765687401f85470a7b9eec37bf5c703634d8e42cc12c4"
},
{
"rev": 676,
"op": "rocko-77-review-1",
"verb": "move",
"args": {
"id": 77,
"to": "in-review",
"reason": null,
"candidate": "agents/rocko/work/queue-77/candidate-manifest.sha256",
"evidence": null,
"issue": 1571
},
"by": "rocko",
"at": "2026-10-12T18:38:36.297Z",
"semantics": 2,
"result": {
"row": 77,
"from": "in-progress",
"to": "in-review",
"round": 1,
"issue": 1571,
"candidate": {
"kind": "manifest",
"digest": "4927de6625a0159eb9633d679a348a77a98978cc403bd9eee78fff8c1d6482a0",
"text": "28c4708c062b752832576eb42aa1f1c9cede16f940d6d8929a4f47957c2f2b4d agents/rocko/work/queue-77/byte-check.sh\nb917b2607ae5f27a95ac09d29b8a2fdedf80069eda0beab9943e22a167250188 agents/rocko/work/queue-77/mutants.py\nff08f52d09ab3f1f9254e7afed418469fb4744a8fee3971129b62b4e2664ec5b docs/TOOLS.md\n769e8358fee021cf1a1d6cdce712549220e07491743829e657fe1ec905df86de packages/webui/README.md\nfdd202e6faa08f3b6e1784b805c6e4db5464126b8d7ed54f471cc38a524597e6 packages/webui/src/cli.mjs\n5692e797e1a1b561a218f49229c8ff297e00ea83a246ac6f828dff7c6e89afed packages/webui/src/reads.mjs\n7a449ef91310ab6b0185ab97f1720e0790adbd9a8d1d83c3c716e36da976acb5 packages/webui/systemd/mosaic-webui.service.in\n1282f274af3a1d956f4411699f884390493e0a067f3674daba86c1fad8bdce39 packages/webui/tests/pinned-copy.test.mjs\n7a22650b68a8a0502ac79b47f3d5c725c3014a78da15b2f12a979e6b6346eed6 packages/webui/tests/service.test.mjs\nc8e43013ef9b7bba28a712ba09b86903ed7a0e49906f4998ccb4fda8099043a4 scripts/webui-service.sh\n"
},
"receipt": "ok rocko-77-review-1 rev 676 row 77 in-progress→in-review round 1 on #1571; request rocko-77-review-1 requesting"
},
"viewSha": "988dad00dac2dbf1d6efe0c0d07c90eb75eae6296d52429d0281dba5fc6f65cc"
},
{
"rev": 677,
"op": "rocko-77-review-1.outcome",
"verb": "review-outcome",
"args": {
"id": 77,
"attempt": "rocko-77-review-1",
"outcome": "failed",
"status": null,
"comment": null,
"detail": "pre-send: the credential or account check failed"
},
"by": "rocko",
"at": "2026-10-12T18:38:38.990Z",
"semantics": 2,
"result": {
"row": 77,
"round": 1,
"attempt": "rocko-77-review-1",
"state": "failed",
"receipt": "ok rocko-77-review-1.outcome rev 677 row 77 round 1 request rocko-77-review-1 failed"
},
"viewSha": "813eeae4fcaae0f422f3b1bfa1ee94db99d4b35a598a64edfb6e0c017b41338e"
},
{
"rev": 678,
"op": "sage-77-review-1b",
"verb": "review-request",
"args": {
"id": 77
},
"by": "sage",
"at": "2026-10-12T18:39:42.860Z",
"semantics": 2,
"result": {
"row": 77,
"round": 1,
"attempt": "sage-77-review-1b",
"state": "requesting",
"receipt": "ok sage-77-review-1b rev 678 row 77 round 1 request sage-77-review-1b requesting"
},
"viewSha": "a66a9ff57319e11bdeec1e5a7165e1e79aa65966be3b5faa2795d9c974c3ab56"
},
{
"rev": 679,
"op": "sage-77-review-1b.outcome",
"verb": "review-outcome",
"args": {
"id": 77,
"attempt": "sage-77-review-1b",
"outcome": "posted",
"status": 201,
"comment": 27767,
"detail": "created"
},
"by": "sage",
"at": "2026-10-12T18:39:49.104Z",
"semantics": 2,
"result": {
"row": 77,
"round": 1,
"attempt": "sage-77-review-1b",
"state": "posted",
"receipt": "ok sage-77-review-1b.outcome rev 679 row 77 round 1 request sage-77-review-1b posted comment 27767"
},
"viewSha": "a0a20ec5f0a2db8b26c9058685d85535a4d3c37414fcc065a85176287a324dd9"
}
]
}