fix(wake): #932 stop reconciler re-enumerating already-CONSUMED detector state (#935)
All checks were successful
ci/woodpecker/push/publish Pipeline was successful
ci/woodpecker/push/ci Pipeline was successful

Co-authored-by: jason.woltje <jason@diversecanvas.com>
Co-committed-by: jason.woltje <jason@diversecanvas.com>
This commit was merged in pull request #935.
This commit is contained in:
2026-07-26 15:48:40 +00:00
committed by Mos
parent 9becaf877f
commit 9e81ffd7fc
6 changed files with 244 additions and 5 deletions

View File

@@ -47,10 +47,14 @@
# RETIRED; --allow-enumerate / WAKE_RECONCILE_ALLOW_ENUMERATE remain accepted
# as deprecated no-ops for caller compatibility. The G3 accounting invariants
# (0-UNACCOUNTED, vacuous-pass prevention) are unaffected and still enforced.
# * "accounted" is judged against observed_seq/inbox (§4/G3 wording) PLUS the
# reconciler's OWN durable reconciled-state ledger — NOT the detector's
# hash-file. Judging by the detector baseline would let a silent first-seen
# baseline swallow a pre-existing obligation (the exact hole G3 closes).
# * "accounted" is judged against THREE sources: observed_seq/inbox (§4/G3
# wording), the reconciler's OWN durable reconciled-state ledger, and (#932)
# the STORE's last-consumed record (consumed-hashes.jsonl, store-written at
# consume-truncation) — NOT the detector's hash-file. Judging by the detector
# baseline would let a silent first-seen baseline swallow a pre-existing
# obligation (the exact hole G3 closes). The 3rd source suppresses ONLY states
# the store RECORDED as consumed (structurally cannot be hash-advance-without-
# enqueue), so a truly-unaccounted state still re-enumerates (G3 teeth intact).
# * enumeration uses the non-coalescible fail-safe class `actionable` (§2.3)
# so two distinct pre-existing obligations can never coalesce into one.
#
@@ -367,6 +371,35 @@ _inbox_has() {
[ "${n:-0}" -gt 0 ]
}
# _store_consumed_has KIND ID HASH — #932 THIRD accounting source. True iff the
# STORE's last-consumed record (consumed-hashes.jsonl, written by store.sh at
# consume-truncation) records HASH as the last-consumed observed_hash for
# (kind,id). After consume truncates the pending prefix, a consumed state matches
# NEITHER _inbox_has (inbox truncated) NOR the reconciler's own seen-ledger (it
# only covers the reconciler's OWN enumerations) — so without this check the
# reconciler re-enumerates the just-consumed state: one DUPLICATE orientation
# wake + one SPURIOUS rc=1 CRITICAL per detector-active window per cycle (#932).
#
# TRUST BOUNDARY (load-bearing — do NOT violate): this consults ONLY the
# store-written record under STATE_DIR — NEVER a detector-owned hash-file. The
# store record is trustworthy BY CONSTRUCTION: it is written only at CONSUME of a
# durably-enqueued entry, so its existence implies the state WAS durably enqueued,
# and it structurally cannot exhibit the §5 swallow-hole signature (hash-advance-
# WITHOUT-enqueue). Trusting DETECTOR hash-files STAYS REJECTED (it reopens §5).
#
# G3 is NOT weakened: this suppresses ONLY states the store has RECORDED as
# consumed. A genuinely-unaccounted state (durably enqueued but not yet consumed
# — still in the inbox — OR a real gap) has no matching consumed record, so it is
# still UNACCOUNTED and still re-enumerates + alarms.
_store_consumed_has() {
local kind="$1" id="$2" h="$3" n
[ -f "$STATE_DIR/consumed-hashes.jsonl" ] || return 1
n="$(jq -s --arg k "$kind" --arg id "$id" --arg h "$h" \
'[ .[] | select(.kind==$k and .id==$id and .observed_hash==$h) ] | length' \
"$STATE_DIR/consumed-hashes.jsonl" 2>/dev/null || echo 0)"
[ "${n:-0}" -gt 0 ]
}
cmd_reconcile() {
local enumerate=1 allow_enumerate=0
while [ $# -gt 0 ]; do
@@ -444,6 +477,12 @@ cmd_reconcile() {
# Or already reconciled to this exact state before (durable ledger)?
elif [ -f "$ledger" ] && [ "$(tr -d '[:space:]' <"$ledger")" = "$curhash" ]; then
accounted=1
# Or the STORE recorded this exact state as ALREADY CONSUMED (#932 — the THIRD
# accounting source; a consume-truncated state matches neither the inbox nor
# the seen-ledger, so without this it would spuriously re-enumerate). Consults
# ONLY the store-written record, never a detector hash-file (§5 stays closed).
elif _store_consumed_has "$kind" "$id" "$curhash"; then
accounted=1
fi
if [ "$accounted" -eq 1 ]; then