diff --git a/agents/duckworth/work/row269/REVIEW-design-early.md b/agents/duckworth/work/row269/REVIEW-design-early.md index 401c0fa7e..611301c21 100644 --- a/agents/duckworth/work/row269/REVIEW-design-early.md +++ b/agents/duckworth/work/row269/REVIEW-design-early.md @@ -83,3 +83,12 @@ Any other change to a pre-existing test goes to Mos first. - **C3.** `session-workspace-overlap` belongs to the realpath compare, and `session-workspace-unsafe` stays with the segment check. M4's input, `/workspaces/` as a symlink into the session path, passes every segment check. - **C4.** end-launch.test:193-195 is the only changed old assertion, under mos-1285's terms. The other readers are listed with reasons. I check the exact diff at the manifest round. - N3, doc only: "I haven't traced the code a bus caller sees" for the limits verb is fine for a rollback note. Trace it in the code round if a test pins it. + +## bindLaunch change (duckworth-0152) + +- Input: gizmoduck-0237. Local commit f684317eb, BUILD.md blob 7b985f8bf. The diff from 04676f57b is one bullet, +6/-3. Read with git. +- Verdict: accepted, no blockers. My C1-C4 check now binds to blob 7b985f8bf. +- The early look agreed to the bind-time `session-running` refusal. Dropping it is right: + - threads.test.mjs:87-89 and sessions.test.mjs:117-120 at aca16404c bind a second unended run to one session and expect `thread-already-held` at claim. A bind refusal would change both old tests, and under mos-1285 that goes to Mos. + - The brief (docs/plans/2026-10-21_t1-sessions.md:111-112) asks for "a private per-session lock plus the broker's unique holder/generation fence". The claim check at broker.mjs:4815 (`#sessionHolder(s.session)?.op === 'claim'`) is that broker fence, and the `.lock` O_EXCL lock is the private lock. +- What this means for the code round: the claim comes after the spawn, so only the host lock and the registry check stop a second setup or spawn. M3 (the lock ignores a live holder) carries that. The brief's T2 "two concurrent dispatchers claim the same session: one holder" is the existing claim refusal, which stays tested. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 291281cfb..deecf7ca0 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1487,3 +1487,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-22T14:43Z | Duckworth (Opus 5.5) | row 269 C4 ruling mos-1285 recorded in early-look note | manifest-round check: end-launch.test:193 exact update only | 2026-10-22T14:46Z | Duckworth (Opus 5.5) | row 269 (264b, #1774) C1-C4 fold check on 04676f57b BUILD.md (duckworth-0151) | C1-C4 met, no blockers, code can start | 2026-10-22T14:48Z | Duckworth (Opus 5.5) | row 253 (#1758) run-log part on record tip 34401e7c9 (duckworth-0151) | 27 whole files 604/0/0 verified from logs, N9 pass accepted, no blockers | +2026-10-22T14:51Z | Duckworth (Opus 5.5) | row 269 (264b) bindLaunch change f684317eb BUILD.md 7b985f8bf (duckworth-0152) | session-running drop accepted, matches brief :111-112, no blockers |