webby: row 278 manifest round 1 approve, and session line

This commit is contained in:
jason.woltje committed 2026-10-22 07:34:44 -05:00
1 parent 6b4202fb6d
commit a6275ca3a8
2 files changed
+70

No files matched your search

+69
View File
@@ -0,0 +1,69 @@
# Row 278 (#1783) manifest round 1, Webby
Candidate: origin/gander/row278-b 385a7194c (first-parent, no merges), base 6af85df4b.
Runtime e7d21b91b, test fixes 964b6b184 and 9696d1fcb. Manifest digest
8fa859a0c617defe42e50028b057a603c6634f6db47ac2e3f7c01dfb290228a3, seven paths.
Run 3 records under agents/gander/work/queue-278/run3/ (gander-0096). I read them with git;
I ran nothing.
## Verdict: APPROVE
## Bytes
- All seven manifest hashes match `git show 385a7194c:<path> | sha256sum`.
- Outside agents/gander/, 6af85df4b..385a7194c changes only the seven manifest paths plus
BUILD-LOG.md.
- origin/refactor is still 6af85df4b, so there is no base drift.
- No co-author lines in 6af85df4b..385a7194c.
## Gate (run 3, runs 1 and 2 void)
My own sums of the TAP and selftest lines in the raw logs:
- Syntax 6 files, no output.
- Intended RED: red-0 and red-1 each 0/1 on the base source, then restored.
- Focused whole files: thread-claims 4/0/0, thread-claims-browser 6/0/0, shell 5/0/0.
- Bus whole 793/0/0. WebUI whole 345/0/1.
- Ten shells, 425/0 in total: auth 15, conductor 17, config 31, discord 81,
extension-package 18, foundation 44, land-work 86, queue 28, release 14, task 91.
- The WebUI skip is the pinned-esbuild rebuild test (0.28.1 installed, 0.28.2 needed). That's an
environment skip.
- Three shell skips the report doesn't name: test-queue's verify and render --check (the seat
worktree isn't the queue's canonical root), and test-task's two live-provider cases (row 244,
no provider call in the gate). Both are existing refactor behavior, not this row.
Timeouts (mos-1275, sage-2650): every shell command.json is `timeout -k 10 LIMIT bash
scripts/test-X.sh`, with LIMIT taken from SHELL-LIMITS.json. Each limit is ceil(3x the
receipt) + 120 s. Every observed run is well under its limit; the longest is foundation at
39.9 s against 240 s. results.json shows `timeout: false` for every change.
## Changes (changes.json, run3/changes)
| Id | Change | Killer | Failure |
|---|---|---|---|
| M1 | section returns '' | held/release browser test | wait for #b-thread-claims never met |
| M2 | thread rows pushed into the role `claims` before rows and count | same | AssertionError |
| M3 | 403 rethrown with signed-out | 403-stays-local test | local `human-required` code never shown |
| M4 | tester guard removed | tester socket test | AssertionError on status or calls |
| M5 | adapter calls `agents` | adapter test | AssertionError on verb |
| M6 | cache kept on refusal | 403-stays-local test | stale repaint `not-read` never shown |
Each change has a passing base (M2 shares M1's, M6 shares M3's), and every changed run fails in its
named test on an assertion or a never-met browser condition. None is a harness timeout or a
syntax error. M2 is the brief's "claims counted into role totals". M3 is R1, and M4 plus the
tester browser test are R2.
## Design checks carried
R1 (only signed-out leaves the section; a 403 evicts only the claims cache) and R2 (tester 403
before the bus, and the tester browser skips the section) are in the source and are killed as above.
The hostile-field test covers `instance`. The role section stays byte-equal across held, release
and refusal.
## Notes (non-blocking)
N1. Name the three shell skips (queue canonical-root, task live-provider x2) in the landing
record next to the esbuild skip.
N2. Early-read N1 (a failed /api/config shows the local 403 banner in a tester browser) and N2
(two sequential reads on Agents) still stand. Neither needs a change.
+1
View File
@@ -1474,3 +1474,4 @@ are never rewritten or removed; corrections are new entries.
2026-10-22T12:10Z | Webby (Opus 5.5, reviewer seat) | row 278 fixture fix 964b6b184 check (manifest 188071d8) | one test line, all six blobs match; run 2 full scope
2026-10-22T12:16Z | Webby (Opus 5.5, reviewer seat) | row 278 run 2 stop (gander-0094) shell.test.mjs read | stub repair complete for the five-states loop; ruling is Mos's
2026-10-22T12:22Z | Webby (Opus 5.5, reviewer seat) | row 278 shell stub fix 9696d1fcb check (manifest 8fa859a0, 7 paths) | two fixture lines, all blobs match; per-script limits tighter than sage-2644 900 s, flagged
2026-10-22T12:34Z | Webby (Opus 5.5, reviewer seat) | row 278 manifest round 1 on 385a7194c (manifest 8fa859a0) | APPROVE, N1-N2