diff --git a/docs/reviews/2026-10-22_q195-docx-citations.md b/docs/reviews/2026-10-22_q195-docx-citations.md index 42459e4c9..fc7269cc5 100644 --- a/docs/reviews/2026-10-22_q195-docx-citations.md +++ b/docs/reviews/2026-10-22_q195-docx-citations.md @@ -238,3 +238,143 @@ and the design builds no notice. Revise the design for B1-B9 and send the new commit and blob to me and Sage. I re-review only the changed sections and the items above. M1 waits on Mos and Jason. If the design takes the O2-only-thread recommendation, M1 closes without a ruling. + +## Round 2: 019a0ea5b (blob 14dfe92d9) + +Reviewed: Rocko's round 2 commit 019a0ea5b, a fast-forward on 15e91538f, design blob 14dfe92d9. +I read the whole file again, not only the changed lines, because the change was large (+453/-120). +Static review only. + +### Verdict: CHANGES + +The design now closes B1-B9 and M1 as they were written. Two problems remain. R2-B1 is a +projection rule that contradicts D25's "final accepted reading". R2-B2 is an existing backup and +restore path that section 7 does not cover. Each needs a rule and an acceptance row, not a new +design. + +### Round 1 items + +- **B1, closed.** + - The `docx-selection` wrapper: 2..32 consecutive ranges, a shared snapshot, empty intermediate + paragraphs, one budget for the whole selection, atomic failure and one canonical form. + - `xmlId` is null exactly when the node has no paraId. + - The wikiToken and anchor grammars now match the locator. + - The chip, share and refusal envelopes are exact. + - The departure from D25 is named (lines 108-111). +- **B2, closed except for R2-B1.** The closed leaf table and the ancestor veto for nested revisions + are in (lines 268-310). +- **B3, closed.** + - `refs/heads/writing-published` advances first-parent with no force. + - Publication commits are defined per document, and `currentCommit` and stale are per document. + - A23 covers a sibling save. +- **B4, closed.** + - The principal is a tuple. + - Scope lives in `writing_access_events`, written by the business owner's existing human proof + only. + - Agent `mayShare` is false, and viewers cannot share. + - The authority vector names its sources. + - Two-human threads are refused (`editor-sharing-unsupported`). +- **B5, closed.** + - A range share allows resolve only. + - A document chip binds one exact publication. + - A latest share exists only under `conversation-current` with a whole-document chip. + - `off` and any policy change invalidate all earlier shares. + - The share's session is the new O2 execution session. +- **B6, closed.** A page ends before the first row that would overflow. A row too large for an + empty page is unsupported in v1, and A24 covers it. +- **B7, closed.** + - O2 repositories have no remotes, mirrors or forks, and the store refuses one. + - Copies exclude `writing/` and `writing-context/`. + - A25 includes a seat-token probe. +- **B8, closed except for R2-B2.** Section 7.4 names every store and renderer I listed, plus + `launches/` and `bus-host/sessions.json`. The run-records rule is explicit, and A26 probes each + store. +- **B9, closed except for R2-B2.** + - New tables are named, append-only, with no change to existing columns. + - Old renderers never query the new tables. + - A rollback probe and an extractor-retention rule are in. +- **M1, closed. No Mos/Jason item.** O2 context exists only in new, dedicated O2 conversations and + execution sessions. Existing C2 threads cannot be converted, attached, resumed or forked into O2 + mode. C2-02 supporting-doc writes and C2-06 replies keep their meaning (lines 433-441), and A28 + tests that. This adds new O2 behaviour and changes no Case 2 requirement. +- **N1-N7, addressed.** N1 is the canonical manifest bytes (lines 155-168). N2 is the business + check (lines 378-379). N3 is the ratio rule at line 257. N4 is the defaults wording at line 84. + N5 is the UI reason (lines 688-690). N6 is release-derived readiness. N7 is A23-A31. + +### R2-B1. Paragraph-mark revisions drop accepted text, and reserved notes would refuse + +**What the design says.** Lines 276-281: "an inserted paragraph mark makes that paragraph's +projected text empty in original; a deleted paragraph mark makes it empty in final." + +**What the markup means.** In WordprocessingML, `w:pPr/w:rPr/w:del` marks only the paragraph mark +as deleted. Accepting the change merges this paragraph's text into the next one. The text is gone +only if its own runs sit under `w:del`, and the ancestor veto already handles that. `w:ins` on the +mark works the same way in `original`. + +**Why that breaks the projection.** When a human joins two paragraphs with tracking on, the first +paragraph's live text disappears from `final`. A quote taken from the accepted reading then can't be +cited. That contradicts D25's "default final accepted reading" and the design's own definition at +line 267. + +**Fix.** Paragraph-mark revisions never change text. Runs follow the ancestor rule alone. Since +views never merge or split paragraphs, a mark-only revision shows up only as a zero-width +whole-paragraph-mark span in `markup`. Extend A31 with a mark-only deletion whose text stays in +`final`, and a mark-only insertion whose text stays in `original`. + +**Reserved notes.** The leaf table "is exhaustive; unknown leaves refuse" (line 305). Word writes a +separator note and a continuation-separator note into every `footnotes.xml` and `endnotes.xml`, +holding `w:separator` and `w:continuationSeparator` (and sometimes `w:continuationNotice`). Line +227-229 calls these notes structural, but the table doesn't name those leaves. Read literally, every +document that has footnotes refuses. Name the three leaves as allowed only inside reserved notes, +structurally validated and never projected. Say whether leaf validation covers the whole part or +only the requested story. + +### R2-B2. The release backup and restore path keeps O2 text and can revive revoked access + +**What the design says.** +- Section 7.4 forbids "plaintext backup" of O2 material (lines 625-626). +- Section 7.5 puts O2 message bodies, share selections (which hold quotes) and every grant and + policy event into new tables in the bus store (lines 638-663). + +**What the release script does.** `scripts/stack-release.sh` copies that store, in plaintext, on +every activate: +- `backup_store` writes `$DATA/backups/stack//bus/bus.sqlite` (lines 474-493). +- It never prunes backups (line 18). +- `rehearse` reads them (line 22). +- `restore_store` moves the current `bus/` into a post-attempt directory and deletes nothing + (line 496). + +So O2 text persists in backups and post-attempt directories that section 7.4 does not name. + +**The restore gap.** `rollback --restore` puts back an older store. The guard counts `events` plus +the fixed `COUNTED` list (lines 16-17 and 418-420). The design keeps O2 writes out of generic +events (lines 659-661), and the new tables are not in `COUNTED`. A restore over revocations made +after the backup therefore passes the guard without Jason's `--events N`. It also silently brings +back the revoked `writing_access_events`, `writing_policy_events` and session-end rows. That +revives revoked grants and shares, against section 7.3's "a scope decrease/revocation denies even +historical shares". + +**What the design needs to state.** +1. **Backups.** Either O2 bodies and quotes live outside `bus.sqlite` (for example under + `writing-context/`) so that release backups hold opaque rows only, or release backups and + post-attempt directories are named O2-classified stores in section 7.4, with mode, access and a + prune rule. +2. **The guard.** Every `writing_*` table joins the restore guard's counted list. The T46 guard + already requires every schema table to be classified. +3. **After a restore.** A restore that drops any `writing_*` row disables O2 readiness until the + owner reconfirms access. It never brings back an older grant, share or policy. +4. **Acceptance.** Add a row: a revocation after the backup, then a restore, must leave the revoked + share refused. A secret marker must stay absent from every backup and post-attempt path except + the named O2-classified ones. + +### Non-blocking + +- R2-N1. Define the agent `subject.id` for `editor.access.set` as the bus agent instance ID (the + principal tuple's `agentInstance`), so a grant can't name a role or a seat display name. +- R2-N2. Lines 330-332 restate the structural leaves already in the table. Drop the sentence or + point it to the table, so there is one list. + +### Next round + +Fix R2-B1 and R2-B2 and send the commit and blob to me and Sage. I'll re-check those two items and +any lines they touch.