From a7ed41f22332f3ed5d03a8fe20002edb7b58264a Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Mon, 12 Oct 2026 16:35:47 -0500 Subject: [PATCH] queue: row 92 round 1 review request as darkwing, comment 27936 (revs 764-765) --- docs/plans/QUEUE.md | 4 +- docs/plans/queue.json | 98 ++++++++++++++++++++++++++++++++++++++++--- 2 files changed, 95 insertions(+), 7 deletions(-) diff --git a/docs/plans/QUEUE.md b/docs/plans/QUEUE.md index 966facfef..651b2d379 100644 --- a/docs/plans/QUEUE.md +++ b/docs/plans/QUEUE.md @@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here. -Generated from `docs/plans/queue.json` revision 763 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. +Generated from `docs/plans/queue.json` revision 765 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. | # | Piece | Owner | Issues | State | After | Gate | Brief | Note | |---|---|---|---|---|---|---|---|---| @@ -128,7 +128,7 @@ Generated from `docs/plans/queue.json` revision 763 by `queue render`. Do not ed | 89 | PM task reads that fit a session | dewey; reviewers darkwing | #1583 | in-review, round 1, request posted | 81 done | darkwing approves on 1583 naming the candidate manifest; bus, harness, webui and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live at the next bus restart (decision 109) (sage) | `docs/plans/2026-10-12_pm-task-flow.md` § PM task reads that fit a session | Also fixes the session text's built-in tools line for Claude Code (PM findings fault 9). | | 90 | The approved requirement ids as data | dewey; reviewers filbert | #1584 | briefed | 89 done | filbert approves on 1584 naming the candidate manifest; tasks, bus, harness, webui and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live at the next bus restart (decision 109) (sage) | `docs/plans/2026-10-12_pm-task-flow.md` § The approved requirement ids as data | Also PM fault 10 (#228 c91): a stop request with no task, and the session text on stopping. | | 91 | A project checkout in each role workspace | darkwing; reviewers filbert | #1585 | briefed | 92 done | filbert approves on 1585 naming the candidate manifest; seat, cli, bus and harness node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live at the next bus restart (decision 109) (sage) | `docs/plans/2026-10-12_pm-task-flow.md` § A project checkout in each role workspace | Vikunja P19 #228 c78 item 6. Blocks S7 (row 42); Darkwing builds it before row 88. The coder-to-reviewer handoff is the next row. | -| 92 | Role sessions confined to their own files | darkwing; reviewers dewey, filbert | #1586 | in-progress | — | filbert and dewey approve on 1586 naming the candidate manifest; seat, cli, harness, bus and webui node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live at the next bus restart (decision 109) (sage) | `docs/plans/2026-10-12_session-confinement.md` § Role sessions confined to their own files | Q126 answered (decision 119): lands on ~/.config/mosaic-dev/secrets/claude-session.env; launch check accepts any ENV_ALLOW provider credential so a proxy key swaps in by file | +| 92 | Role sessions confined to their own files | darkwing; reviewers dewey, filbert | #1586 | in-review, round 1, request posted | — | filbert and dewey approve on 1586 naming the candidate manifest; seat, cli, harness, bus and webui node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live at the next bus restart (decision 109) (sage) | `docs/plans/2026-10-12_session-confinement.md` § Role sessions confined to their own files | Q126 answered (decision 119): lands on ~/.config/mosaic-dev/secrets/claude-session.env; launch check accepts any ENV_ALLOW provider credential so a proxy key swaps in by file | | 93 | A review loop through the bus: push_working, request_review, fetch_review, review_verdict | filbert; reviewers darkwing, dewey | #1587 | briefed | 91 done, 95 done | darkwing and dewey approve on 1587 naming the candidate manifest; bus, harness, seat and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; live at the next bus restart, Mos's go first (sage-0104) (sage) | `docs/plans/2026-10-12_pm-test-fixes.md` § A review loop through the bus | PM findings faults 3 and 5, Jason's test (P19 #228). Builds after rows 91 and 95. | | 94 | Every message to the human, live: talk --follow, follow, inbox messages, Console Messages page | rocko; reviewers dewey | #1588 | briefed | 77 done | dewey approves on 1588 naming the candidate manifest; bus, cli and webui node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live after the bus and Console restart Mos approves (sage) | `docs/plans/2026-10-12_pm-test-fixes.md` § Every message to the human, live | Jason's blind-after-send report (Mos sage-0103). Rocko builds it before rows 84 and 85. | | 95 | The Console's Board shows the stack's held roles, machine sessions behind a toggle, and a signed-out line | filbert; reviewers darkwing | #1589 | in-review, round 1, request posted | — | darkwing approves on 1589 naming the candidate manifest; webui and control-board node suites and every scripts/test-*.sh green on Sage's gate rerun; Mos notified before landing, live after the Console restart Mos approves (sage) | `docs/plans/2026-10-12_pm-test-fixes.md` § The Console's Board shows the stack's seats and a sign-out | PM findings fault 8 (P19 #231) and Jason's Console report (Mos sage-0105, sage-0106). | diff --git a/docs/plans/queue.json b/docs/plans/queue.json index 5c28c8487..9bbe09d1e 100644 --- a/docs/plans/queue.json +++ b/docs/plans/queue.json @@ -1,7 +1,7 @@ { "version": 1, "canonicalRoot": "/mnt/storage/src/mosaic-stack", - "revision": 763, + "revision": 765, "rows": [ { "id": 1, @@ -7261,7 +7261,7 @@ "closes": [ 1586 ], - "state": "in-progress", + "state": "in-review", "previousState": null, "required": false, "requiredSince": null, @@ -7277,7 +7277,41 @@ "dewey", "filbert" ], - "review": null, + "review": { + "rounds": [ + { + "n": 1, + "op": "darkwing-92-review-1", + "by": "darkwing", + "at": "2026-10-12T21:35:05.102Z", + "issue": 1586, + "candidate": { + "kind": "manifest", + "digest": "bc132570f1a208223cd089bc7e64bec68c98693ccbfc3c274fa162d0bbac6a1c", + "text": "614b128067559c0319bbf7dc41e51e821a2224f0cec39381866440d697d57438 packages/cli/README.md\nd19dca70349e45ad3607c6fccd00afc9b1904b4df79e1fe107f2fd926981fd16 packages/cli/src/launcher.mjs\n8e4e255fdf560769fd79827a98591a3d56a753f2740b22a5538d5a9bd37ae741 packages/cli/systemd/mosaic-bus.service.in\n43a7f4b783a6d16edf5c2762e9fd657e0d14a0e2af2581814b8afe0df2daeac9 packages/cli/tests/fixtures/launch-host.mjs\n7e92ecf7bbcfd09f7a4cf6f3afac3646e198115d95ddd24dfdd5dd8bb53ab411 packages/cli/tests/host.test.mjs\n4b4a37e2b81490b01bdcb220949c63a213eacb7e7f3404310a74ee416b5997f1 packages/cli/tests/launcher.test.mjs\nde3e0d33e990b8157d383ccaee0f58ee7fa2ec0df67e6d072bfbe2709c16bc19 packages/harness/README.md\nbfb7ca89754e36f9f467b7ea1bad03b38ea34d5f9bf1e49000ec2643bad8c811 packages/harness/src/gate.mjs\n1da86919610090364d6617ad9a2d4393aa8768d07777477661e24d21a40e0fe1 packages/seat/README.md\n39702ce147a1d1e7fecaf7a57e34041728ad0412f2a841b925698ed00527ca9b packages/seat/src/sandbox.mjs\nc2e32e95884e734a92298d7d1e5e82445a91a7f5ca5c3d3741297d38c6c4edd6 packages/seat/src/session.mjs\n4fd2c5fd3fd5cca1e556925b72c12a1666fa96f71f821834c27aa4c243906b92 packages/seat/tests/sandbox.test.mjs\n0898f1db9e889d4a7ea1e266a450511c88127268db065be053462a4c2fe9d1c2 packages/seat/tests/session.test.mjs\n" + }, + "request": "comment", + "attempts": [ + { + "op": "darkwing-92-review-1", + "by": "darkwing", + "at": "2026-10-12T21:35:05.102Z", + "state": "posted", + "comment": 27936, + "transport": { + "outcome": "posted", + "status": 201, + "comment": 27936, + "detail": "created" + }, + "resolutions": [] + } + ], + "duplicateRisk": false, + "receipts": [] + } + ] + }, "claim": { "seat": "darkwing", "op": "darkwing-92-start-1" @@ -7285,8 +7319,8 @@ "note": "Q126 answered (decision 119): lands on ~/.config/mosaic-dev/secrets/claude-session.env; launch check accepts any ENV_ALLOW provider credential so a proxy key swaps in by file", "blockedReason": null, "createdAt": "2026-10-12T19:42:00.055Z", - "updatedAt": "2026-10-12T20:15:13.433Z", - "updatedBy": "sage" + "updatedAt": "2026-10-12T21:35:08.298Z", + "updatedBy": "darkwing" }, { "id": 93, @@ -28298,6 +28332,60 @@ "receipt": "ok filbert-95-review-1.outcome rev 763 row 95 round 1 request filbert-95-review-1 posted comment 27928" }, "viewSha": "bf1d8fd8dc011a5bb88a239db24a5aa327cd18b9b338f5b22090a7778b33fbe6" + }, + { + "rev": 764, + "op": "darkwing-92-review-1", + "verb": "move", + "args": { + "id": 92, + "to": "in-review", + "reason": null, + "candidate": "agents/darkwing/work/queue-92/candidate-manifest.sha256", + "evidence": null, + "issue": null + }, + "by": "darkwing", + "at": "2026-10-12T21:35:05.102Z", + "semantics": 2, + "result": { + "row": 92, + "from": "in-progress", + "to": "in-review", + "round": 1, + "issue": 1586, + "candidate": { + "kind": "manifest", + "digest": "bc132570f1a208223cd089bc7e64bec68c98693ccbfc3c274fa162d0bbac6a1c", + "text": "614b128067559c0319bbf7dc41e51e821a2224f0cec39381866440d697d57438 packages/cli/README.md\nd19dca70349e45ad3607c6fccd00afc9b1904b4df79e1fe107f2fd926981fd16 packages/cli/src/launcher.mjs\n8e4e255fdf560769fd79827a98591a3d56a753f2740b22a5538d5a9bd37ae741 packages/cli/systemd/mosaic-bus.service.in\n43a7f4b783a6d16edf5c2762e9fd657e0d14a0e2af2581814b8afe0df2daeac9 packages/cli/tests/fixtures/launch-host.mjs\n7e92ecf7bbcfd09f7a4cf6f3afac3646e198115d95ddd24dfdd5dd8bb53ab411 packages/cli/tests/host.test.mjs\n4b4a37e2b81490b01bdcb220949c63a213eacb7e7f3404310a74ee416b5997f1 packages/cli/tests/launcher.test.mjs\nde3e0d33e990b8157d383ccaee0f58ee7fa2ec0df67e6d072bfbe2709c16bc19 packages/harness/README.md\nbfb7ca89754e36f9f467b7ea1bad03b38ea34d5f9bf1e49000ec2643bad8c811 packages/harness/src/gate.mjs\n1da86919610090364d6617ad9a2d4393aa8768d07777477661e24d21a40e0fe1 packages/seat/README.md\n39702ce147a1d1e7fecaf7a57e34041728ad0412f2a841b925698ed00527ca9b packages/seat/src/sandbox.mjs\nc2e32e95884e734a92298d7d1e5e82445a91a7f5ca5c3d3741297d38c6c4edd6 packages/seat/src/session.mjs\n4fd2c5fd3fd5cca1e556925b72c12a1666fa96f71f821834c27aa4c243906b92 packages/seat/tests/sandbox.test.mjs\n0898f1db9e889d4a7ea1e266a450511c88127268db065be053462a4c2fe9d1c2 packages/seat/tests/session.test.mjs\n" + }, + "receipt": "ok darkwing-92-review-1 rev 764 row 92 in-progress→in-review round 1 on #1586; request darkwing-92-review-1 requesting" + }, + "viewSha": "606281d2e3c0c3e649b1aadd7ba3ed4c0c230fcbb589f46ad28bf0dd54df1c94" + }, + { + "rev": 765, + "op": "darkwing-92-review-1.outcome", + "verb": "review-outcome", + "args": { + "id": 92, + "attempt": "darkwing-92-review-1", + "outcome": "posted", + "status": 201, + "comment": 27936, + "detail": "created" + }, + "by": "darkwing", + "at": "2026-10-12T21:35:08.298Z", + "semantics": 2, + "result": { + "row": 92, + "round": 1, + "attempt": "darkwing-92-review-1", + "state": "posted", + "receipt": "ok darkwing-92-review-1.outcome rev 765 row 92 round 1 request darkwing-92-review-1 posted comment 27936" + }, + "viewSha": "27df9e6fa3898d33f2d3099f26c50c77482e08d2abe2fac89e4f189bb650bdd1" } ] }