mosaicstack/stack
25
0
Fork 1
Code Issues 360 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

queue: revs 545-547, row 74 done (351464ce), row 76 README notes (sage); darkwing's 545, row 59 round 1 review record

Browse Source
This commit is contained in:
jason.woltje
2026-10-11 18:33:51 -05:00
parent 351464ce42
commit b1c4acf327
2 changed files with 85 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plans/QUEUE.md
+3 -3
View File
@@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here.
<!-- mosaic-queue:begin -->
Generated from `docs/plans/queue.json` revision 544 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
Generated from `docs/plans/queue.json` revision 547 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`.
| # | Piece | Owner | Issues | State | After | Gate | Brief | Note |
|---|---|---|---|---|---|---|---|---|
@@ -110,9 +110,9 @@ Generated from `docs/plans/queue.json` revision 544 by `queue render`. Do not ed
| 71 | Tree read follow-up: confirm-read tests and the fake's view 404 | darkwing; reviewers dewey, filbert | #1565 | blocked (from briefed): deferred until after the mosaic.woltje.com dogfood cutover (lead decision 94) | — | dewey and filbert approve on the issue naming the candidate manifest; tasks and bus node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_tree-read-follow-up.md` § Tree read follow-up: confirm-read tests and the fake's view 404 | — |
| 72 | Claude pin tests: a directory pin, a symlink default, a pin with a space | rocko; reviewers filbert | #1566 | done | 68 done | filbert approves on the issue naming the candidate manifest; cli and harness node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin tests: a directory pin, a symlink default, a pin with a space | — |
| 73 | Coder role: drop the task.reassign grant the broker always refuses | rocko; reviewers dewey | #1567 | in-review, round 1, request posted | — | dewey approves on the issue naming the candidate manifest; tasks, bus, business and harness node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder role: drop the task.reassign grant the broker always refuses | — |
| 74 | WebUI preview: a signed-in, read-only Console behind the edge proxy | dewey; reviewers darkwing, filbert | #1568 | in-review, round 2, request posted | — | darkwing and filbert approve on the issue naming the candidate manifest; webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Sage starts it after landing once rev-sol-01 passes ops-01's route (decision 93) (sage) | `docs/plans/2026-10-11_webui-preview.md` § WebUI preview: a signed-in, read-only Console behind the edge proxy | Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged. |
| 74 | WebUI preview: a signed-in, read-only Console behind the edge proxy | dewey; reviewers darkwing, filbert | #1568 | done | — | darkwing and filbert approve on the issue naming the candidate manifest; webui, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Sage starts it after landing once rev-sol-01 passes ops-01's route (decision 93) (sage) | `docs/plans/2026-10-11_webui-preview.md` § WebUI preview: a signed-in, read-only Console behind the edge proxy | Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged. |
| 75 | Console as a user service: render, install and status, Jason starts it | rocko; reviewers filbert | #1569 | done | — | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console as a user service | — |
| 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | briefed | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | From row 74 round 1 (Dewey, point 5): the page shows 'Delivery may be unknown; check the seat before sending again.' for a 403 read-only refusal. That's wrong for a refusal. src/public/app.js is row 76's file, so row 76 fixes the message: a refusal says it was refused, and only outcome-unknown says delivery may be unknown. |
| 76 | Console sends a human message to a role | dewey; reviewers darkwing, filbert | #1570 | briefed | 74 done | darkwing and filbert approve on the issue naming the candidate manifest; webui, bus, control-board and cli node suites and every scripts/test-*.sh green on Sage's gate rerun; Jason's Q95 recorded first (sage) | `docs/plans/2026-10-11_dogfood-cutover.md` § Console sends a message to a role | Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh. |
| 77 | Console service hardening: row 75 review follow-ups N1-N5 | rocko; reviewers filbert | #1571 | queued | 75 done | filbert approves on the issue naming the candidate manifest; webui node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_console-service-followups.md` § Console service hardening | After the cutover (2026-10-12T21:30Z). Source: Filbert comment 27430 on #1569. |
| 78 | Claude pin default-path tests: row 72 review follow-up N1 | rocko; reviewers filbert | #1572 | queued | 73 done | filbert approves on the issue naming the candidate manifest; cli node suite and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Claude pin default-path tests | — |
| 79 | Coder grant stale text: row 73 packet follow-up | rocko; reviewers dewey | #1573 | queued | 73 done | dewey approves on the issue naming the candidate manifest; tasks and business node suites and every scripts/test-*.sh green on Sage's gate rerun (sage) | `docs/plans/2026-10-11_claude-pin-and-coder-grant.md` § Coder grant stale text | — |
docs/plans/queue.json
+82 -12
View File
@@ -1,7 +1,7 @@
{
"version": 1,
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
"revision": 544,
"revision": 547,
"rows": [
{
"id": 1,
@@ -4493,6 +4493,14 @@
"verdict": "approve",
"comment": 27382,
"candidate": "90d5bddc545e429091bf43202ef70cb55eeb1ce964964f440a0c753decb82f71"
},
{
"reviewer": "darkwing",
"op": "darkwing-59-review-1",
"at": "2026-10-11T23:32:40.800Z",
"verdict": "approve",
"comment": 27487,
"candidate": "90d5bddc545e429091bf43202ef70cb55eeb1ce964964f440a0c753decb82f71"
}
]
}
@@ -4505,8 +4513,8 @@
"note": null,
"blockedReason": null,
"createdAt": "2026-10-10T16:36:18.229Z",
"updatedAt": "2026-10-11T21:56:41.162Z",
"updatedBy": "dewey"
"updatedAt": "2026-10-11T23:32:40.800Z",
"updatedBy": "darkwing"
},
{
"id": 60,
@@ -5477,7 +5485,7 @@
"closes": [
1568
],
"state": "in-review",
"state": "done",
"previousState": null,
"required": false,
"requiredSince": null,
@@ -5585,15 +5593,12 @@
}
]
},
"claim": {
"seat": "dewey",
"op": "dewey-74-start-1"
},
"claim": null,
"note": "Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged.",
"blockedReason": null,
"createdAt": "2026-10-11T21:53:29.970Z",
"updatedAt": "2026-10-11T23:30:43.080Z",
"updatedBy": "darkwing"
"updatedAt": "2026-10-11T23:33:02.756Z",
"updatedBy": "sage"
},
{
"id": 75,
@@ -5718,10 +5723,10 @@
],
"review": null,
"claim": null,
"note": "From row 74 round 1 (Dewey, point 5): the page shows 'Delivery may be unknown; check the seat before sending again.' for a 403 read-only refusal. That's wrong for a refusal. src/public/app.js is row 76's file, so row 76 fixes the message: a refusal says it was refused, and only outcome-unknown says delivery may be unknown.",
"note": "Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh.",
"blockedReason": null,
"createdAt": "2026-10-11T22:17:42.739Z",
"updatedAt": "2026-10-11T22:40:59.735Z",
"updatedAt": "2026-10-11T23:33:08.623Z",
"updatedBy": "sage"
},
{
@@ -21032,6 +21037,71 @@
"receipt": "ok darkwing-74-review-2 rev 544 row 74 round 2 approve by darkwing (comment 27486)"
},
"viewSha": "cb057e9cae582c579a67ad47f1e0d242ac30b4b56de4942fd005e0d1fe3b431e"
},
{
"rev": 545,
"op": "darkwing-59-review-1",
"verb": "review-record",
"args": {
"id": 59,
"verdict": "approve",
"comment": 27487,
"candidate": "90d5bddc545e429091bf43202ef70cb55eeb1ce964964f440a0c753decb82f71"
},
"by": "darkwing",
"at": "2026-10-11T23:32:40.800Z",
"semantics": 2,
"result": {
"row": 59,
"round": 1,
"verdict": "approve",
"receipt": "ok darkwing-59-review-1 rev 545 row 59 round 1 approve by darkwing (comment 27487)"
},
"viewSha": "6030292adadddb78d1bf130d23c4fa32c5e4f55e1f99f4d42b61077eea7f11e1"
},
{
"rev": 546,
"op": "sage-74-done",
"verb": "move",
"args": {
"id": 74,
"to": "done",
"reason": null,
"candidate": null,
"evidence": null,
"issue": null
},
"by": "sage",
"at": "2026-10-11T23:33:02.756Z",
"semantics": 2,
"result": {
"row": 74,
"from": "in-review",
"to": "done",
"round": 2,
"issue": null,
"candidate": null,
"receipt": "ok sage-74-done rev 546 row 74 in-review→done round 2"
},
"viewSha": "3d89a6b7d11f7e23ca68f5b3ee2e5dfc338d624b1a848c3a9808f9c36626bcd5"
},
{
"rev": 547,
"op": "sage-76-readme-notes",
"verb": "note",
"args": {
"id": 76,
"text": "Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh."
},
"by": "sage",
"at": "2026-10-11T23:33:08.623Z",
"semantics": 2,
"result": {
"row": 76,
"field": "note",
"receipt": "ok sage-76-readme-notes rev 547 row 76 note"
},
"viewSha": "ae08b5ab30423385f0be1f52a1fb0b23a855c118be278842eef29ba5c1e60e6b"
}
]
}