queue: revs 545-547, row 74 done (351464ce), row 76 README notes (sage); darkwing's 545, row 59 round 1 review record
This commit is contained in:
+82
-12
@@ -1,7 +1,7 @@
|
||||
{
|
||||
"version": 1,
|
||||
"canonicalRoot": "/mnt/storage/src/mosaic-stack",
|
||||
"revision": 544,
|
||||
"revision": 547,
|
||||
"rows": [
|
||||
{
|
||||
"id": 1,
|
||||
@@ -4493,6 +4493,14 @@
|
||||
"verdict": "approve",
|
||||
"comment": 27382,
|
||||
"candidate": "90d5bddc545e429091bf43202ef70cb55eeb1ce964964f440a0c753decb82f71"
|
||||
},
|
||||
{
|
||||
"reviewer": "darkwing",
|
||||
"op": "darkwing-59-review-1",
|
||||
"at": "2026-10-11T23:32:40.800Z",
|
||||
"verdict": "approve",
|
||||
"comment": 27487,
|
||||
"candidate": "90d5bddc545e429091bf43202ef70cb55eeb1ce964964f440a0c753decb82f71"
|
||||
}
|
||||
]
|
||||
}
|
||||
@@ -4505,8 +4513,8 @@
|
||||
"note": null,
|
||||
"blockedReason": null,
|
||||
"createdAt": "2026-10-10T16:36:18.229Z",
|
||||
"updatedAt": "2026-10-11T21:56:41.162Z",
|
||||
"updatedBy": "dewey"
|
||||
"updatedAt": "2026-10-11T23:32:40.800Z",
|
||||
"updatedBy": "darkwing"
|
||||
},
|
||||
{
|
||||
"id": 60,
|
||||
@@ -5477,7 +5485,7 @@
|
||||
"closes": [
|
||||
1568
|
||||
],
|
||||
"state": "in-review",
|
||||
"state": "done",
|
||||
"previousState": null,
|
||||
"required": false,
|
||||
"requiredSince": null,
|
||||
@@ -5585,15 +5593,12 @@
|
||||
}
|
||||
]
|
||||
},
|
||||
"claim": {
|
||||
"seat": "dewey",
|
||||
"op": "dewey-74-start-1"
|
||||
},
|
||||
"claim": null,
|
||||
"note": "Round 2 also carries Darkwing's finding: a proxy that rewrites Host to its upstream lands on the loopback path and skips the ID check (Host 127.0.0.1:PORT, wrong user, 200). In preview mode a request whose Host isn't NAME but carries HEADER is refused. Plus Darkwing's HEAD tests and two README lines for ops-01, including that the edge must forward Host unchanged.",
|
||||
"blockedReason": null,
|
||||
"createdAt": "2026-10-11T21:53:29.970Z",
|
||||
"updatedAt": "2026-10-11T23:30:43.080Z",
|
||||
"updatedBy": "darkwing"
|
||||
"updatedAt": "2026-10-11T23:33:02.756Z",
|
||||
"updatedBy": "sage"
|
||||
},
|
||||
{
|
||||
"id": 75,
|
||||
@@ -5718,10 +5723,10 @@
|
||||
],
|
||||
"review": null,
|
||||
"claim": null,
|
||||
"note": "From row 74 round 1 (Dewey, point 5): the page shows 'Delivery may be unknown; check the seat before sending again.' for a 403 read-only refusal. That's wrong for a refusal. src/public/app.js is row 76's file, so row 76 fixes the message: a refusal says it was refused, and only outcome-unknown says delivery may be unknown.",
|
||||
"note": "Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh.",
|
||||
"blockedReason": null,
|
||||
"createdAt": "2026-10-11T22:17:42.739Z",
|
||||
"updatedAt": "2026-10-11T22:40:59.735Z",
|
||||
"updatedAt": "2026-10-11T23:33:08.623Z",
|
||||
"updatedBy": "sage"
|
||||
},
|
||||
{
|
||||
@@ -21032,6 +21037,71 @@
|
||||
"receipt": "ok darkwing-74-review-2 rev 544 row 74 round 2 approve by darkwing (comment 27486)"
|
||||
},
|
||||
"viewSha": "cb057e9cae582c579a67ad47f1e0d242ac30b4b56de4942fd005e0d1fe3b431e"
|
||||
},
|
||||
{
|
||||
"rev": 545,
|
||||
"op": "darkwing-59-review-1",
|
||||
"verb": "review-record",
|
||||
"args": {
|
||||
"id": 59,
|
||||
"verdict": "approve",
|
||||
"comment": 27487,
|
||||
"candidate": "90d5bddc545e429091bf43202ef70cb55eeb1ce964964f440a0c753decb82f71"
|
||||
},
|
||||
"by": "darkwing",
|
||||
"at": "2026-10-11T23:32:40.800Z",
|
||||
"semantics": 2,
|
||||
"result": {
|
||||
"row": 59,
|
||||
"round": 1,
|
||||
"verdict": "approve",
|
||||
"receipt": "ok darkwing-59-review-1 rev 545 row 59 round 1 approve by darkwing (comment 27487)"
|
||||
},
|
||||
"viewSha": "6030292adadddb78d1bf130d23c4fa32c5e4f55e1f99f4d42b61077eea7f11e1"
|
||||
},
|
||||
{
|
||||
"rev": 546,
|
||||
"op": "sage-74-done",
|
||||
"verb": "move",
|
||||
"args": {
|
||||
"id": 74,
|
||||
"to": "done",
|
||||
"reason": null,
|
||||
"candidate": null,
|
||||
"evidence": null,
|
||||
"issue": null
|
||||
},
|
||||
"by": "sage",
|
||||
"at": "2026-10-11T23:33:02.756Z",
|
||||
"semantics": 2,
|
||||
"result": {
|
||||
"row": 74,
|
||||
"from": "in-review",
|
||||
"to": "done",
|
||||
"round": 2,
|
||||
"issue": null,
|
||||
"candidate": null,
|
||||
"receipt": "ok sage-74-done rev 546 row 74 in-review→done round 2"
|
||||
},
|
||||
"viewSha": "3d89a6b7d11f7e23ca68f5b3ee2e5dfc338d624b1a848c3a9808f9c36626bcd5"
|
||||
},
|
||||
{
|
||||
"rev": 547,
|
||||
"op": "sage-76-readme-notes",
|
||||
"verb": "note",
|
||||
"args": {
|
||||
"id": 76,
|
||||
"text": "Fold in row 74 README wording notes: Filbert N1 (27485), 'first request' should read 'first signed-in request' since a Host-rewriting proxy's unsigned requests still take the loopback path; Darkwing (27486), the tunnel sentence should say anything reaching a tunnel's local end can send a loopback Host without HEADER, so bind it to loopback. Add the README pointer to scripts/webui-service.sh."
|
||||
},
|
||||
"by": "sage",
|
||||
"at": "2026-10-11T23:33:08.623Z",
|
||||
"semantics": 2,
|
||||
"result": {
|
||||
"row": 76,
|
||||
"field": "note",
|
||||
"receipt": "ok sage-76-readme-notes rev 547 row 76 note"
|
||||
},
|
||||
"viewSha": "ae08b5ab30423385f0be1f52a1fb0b23a855c118be278842eef29ba5c1e60e6b"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user