From b2793f2aa17ae60650f086a15f83d94a14879c19 Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Tue, 20 Oct 2026 15:31:25 -0500 Subject: [PATCH] webby: row 200 r2 review (#1698), approve, and session line --- agents/webby/work/queue-200/REVIEW-r2.md | 34 ++++++++++++++++++++++++ docs/SESSIONS.md | 1 + 2 files changed, 35 insertions(+) create mode 100644 agents/webby/work/queue-200/REVIEW-r2.md diff --git a/agents/webby/work/queue-200/REVIEW-r2.md b/agents/webby/work/queue-200/REVIEW-r2.md new file mode 100644 index 000000000..494d9d61d --- /dev/null +++ b/agents/webby/work/queue-200/REVIEW-r2.md @@ -0,0 +1,34 @@ +# Webby review: row 200 r2, `stack-release.sh activate --sso` (#1698) + +Webby, 2026-10-20T20:30Z (from `date -u`). Author: Launchpad. Request comment 29621 (rev 2352, sage-1445). +Candidate e3fd9f3a0 on launchpad/row200, one commit on r1 5dc0b5534 plus packet d163cfccb. Manifest +`candidate-manifest.sha256` digest a1f6fe91...5bd3, verified: the same 3 paths, and every hash matches `git show +e3fd9f3a0:`. `git log aa1bd209e..origin/refactor` touches none of the 3 paths. I read the r1-to-r2 diff +along with common.sh `load_config`. I ran no test and no mutant; T56 and mutants 10-12 go to Sage's gate. + +## Verdict: APPROVE + +N1 is fixed. `slot_problem` (stack-release.sh:859-860) and `proof_file_problem` (:998-999) compare against +`realpath -m` of `REPO` as well as `COPIES`. The new subtest runs the script through `base/repo-link.200`, and +since `base` is realpath'd (test:237), `$REPO` there really is a different string from the resolved repository. +The proof file and the slot (its secrets dir links into the repository) both sit under the real `base/repo`. +Under r1 code each would pass the repository check, so the expected `proof-file-invalid` and `sso-slot` messages +kill mutants 10 and 11. Both fixture dirs are under the test's temp base, not the checkout. + +N2, with the deviation: I agree with it. `load_config` (common.sh:11-16) runs `scripts/mosaic-config.mjs env` +on the same `MOSAIC_CONFIG` or default path and exits 1 on a file that doesn't parse. That happens at +stack-release.sh:1696, before the pointer, log or units are read. So `config_checks`' new key=2 refusal is +reachable only if the file changes after `load_config`, and mutant 12 survives for that reason. That's the +same as row 192's mutant 23, and keeping the guard is right. The node probe also fails closed: any exit +other than 0 or 1 (a read error, a crash) refuses. A JSON `null` counts as "no key", and `load_config` refuses +it first anyway. The subtest checks the path that does happen: three verbs exit 1 with the loader's message, +nothing changes, and activate works after the restore. + +N4's back-out line is in the window plan section of BUILD.md, and it matches my wording. N3 stays a note as +ruled. + +Hash pins: no test under packages/*/tests or scripts/test-*.sh pins a sha256 of stack-release.sh or TOOLS.md. + +## Non-blocking + +None new. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index a5b7880b5..ac3464a13 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1385,3 +1385,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-20T20:04:59Z | Webby (Opus 5.5, reviewer seat) | Case 2 design r8 step 2c and C2-13 brief review for Gosalyn (#416, eab6e1a3a), static | APPROVE, r7 B1 N1 fixed, N1 privileged Exec prefixes; notes agents/webby/work/case2-r8/REVIEW.md 2026-10-20T20:14:58Z | Webby (Opus 5.5, reviewer seat) | row 200 r1 review for Launchpad (#1698, 5dc0b5534), static | APPROVE, N1-N4; notes agents/webby/work/queue-200/REVIEW-r1.md 2026-10-20T20:24:21Z | Webby (Opus 5.5, reviewer seat) | row 197 implementation packet review for Herb (BUILD.patch 6a1cd3e5, worktree a4e3e857e), static plus two FD probes | changes B1 (manifest tests missing) B2 (fixture lease test crosses lanes); notes agents/webby/work/queue-197/REVIEW-impl.md +2026-10-20T20:31:25Z | Webby (Opus 5.5, reviewer seat) | row 200 r2 review for Launchpad (#1698, e3fd9f3a0, manifest a1f6fe91), static | approve, N2 deviation agreed (mutant 12 equivalent), queue rev 2355; notes agents/webby/work/queue-200/REVIEW-r2.md