sage: brief for the row 169 TOOLS.md follow-ups F1-F3 (Filbert, #1666 comment 29263), owner Darkwing, reviewer Dewey, after row 169
This commit is contained in:
1 parent
e7d47c3464
commit
b2a75f3189
1 file changed
+27
@@ -0,0 +1,27 @@
|
||||
# Brief: docs/TOOLS.md follow-ups from the row 169 review
|
||||
|
||||
Owner Darkwing, reviewer Dewey, gate owner Sage. Starts after row 169 lands. Filbert raised these as doc-only
|
||||
follow-ups in the row 169 round 1 review (Gitea #1666 comment 29263), and they don't block 169 (decision 137). Line
|
||||
numbers are in row 169's candidate `docs/TOOLS.md` (sha256 31e80ff21e78…f091).
|
||||
|
||||
## The change
|
||||
|
||||
`docs/TOOLS.md` only.
|
||||
|
||||
- F1, :454. "Neither touches ... the Console" is wrong for `pm-on-down`, which stops the Console. Say what each path
|
||||
does to the Console.
|
||||
- F2, :426 and :446. `mosaic plugins set` doesn't reach `packages/cli` until row 175 lands (`scripts/mosaic:37-39`).
|
||||
Give the working form, `node <copy>/packages/cli/src/cli.mjs plugins set --file P --business ID`, and the PATCH
|
||||
shape `{"revision":"<64 hex>","plugins":{"<kind>":<value>|null}}`, where null removes the kind. Add one line saying
|
||||
row 175's fixed `mosaic plugins set` replaces it once that row lands. If 175 has landed first, write the fixed
|
||||
command and leave the stand-in out.
|
||||
- F3. Document the `business-unreadable` refusal (`scripts/stack-release.sh:267`, :275 in the candidate): activate
|
||||
and rollback refuse a copy without `kinds.mjs` (older than eaeb5ebf2) and a business file the target's loader can't
|
||||
read. The live copy 5fa9cc8f2 contains eaeb5ebf2.
|
||||
|
||||
## Gate
|
||||
|
||||
Before in-review, grep `packages/*/tests` and `scripts/test-*.sh` for `TOOLS.md`. `stack-release.test.mjs:428` names it inside an expected message string, which isn't a read. If
|
||||
nothing reads it, Dewey's
|
||||
approval of the candidate manifest is the gate and no suite run is needed (decision 137, Mos 10-16). If a test reads
|
||||
it, run that test singly and say so in the packet.
|
||||
Reference in new issue
Block a user