reviews: Q195 S0 partial, WordCraft wasm dependency inventory (#1798)

This commit is contained in:
jason.woltje committed 2026-10-22 18:31:47 -05:00
1 parent e36bce3526
commit b7daf5198b
2 files changed
+7387

No files matched your search

File diff suppressed because it is too large. Load diff
@@ -0,0 +1,56 @@
# Q195 O2 S0: WordCraft source security review
Status: IN PROGRESS (partial push). No verdict yet. Do not cite this file as PASS or FAIL.
- Review id: `s0-20261022`. Record: Gitea #1798. Owner: Fenton. Reviewer: Filbert.
- Spec: `docs/plans/2026-10-21_q195-writing-editor.md` blob `322ec50f`, at e36bce352,
D6-D9 and the "S0 independent WordCraft source security review" section.
- Source: WordCraft `e05b7fe86f3b85454000dffc321de638d7009817` (0.9.0), exported with
`git archive` into the review dir. `Cargo.lock` SHA-256
`06b745e43c13df3df7f048fa6a1981625ce7a5fe4cd484bc6254d0913d865b0b`, byte-identical to the pin.
- Independence: I did not author any WordCraft import, patch or browser adapter. I reviewed the
O2 design itself (fenton-0004 to fenton-0008). That review shaped D6-D9's wording, not the code.
## Method
Evidence labels used below: **[source]** means read from pinned source, **[browser]** means
measured in the scratch harness. Nothing here was compiled.
1. `cargo fetch --locked --target wasm32-unknown-unknown` into an isolated `CARGO_HOME` in the
review dir. Cargo checks each crates.io archive against the `Cargo.lock` checksum.
2. `cargo tree -p wordcraft-web --target wasm32-unknown-unknown --locked`, with
`--edges normal` and `--edges normal,build`, then `cargo metadata --filter-platform`.
3. `harness/inventory.py` joins the three into one record per package: lock checksum, declared
license, license/notice files, build script, proc-macro and capability marker counts.
Marker counts are leads for reading, not findings.
## Inventory (complete)
| Set | Count |
|---|---|
| Local WordCraft crates in the web closure | 15 |
| Third-party packages, normal edges (D6's 199) | 199 |
| Third-party build-only packages (build-dependencies) | 10 |
| Third-party packages with a build script | 25 |
| Third-party proc-macro crates | 10 |
The 15 local crates match D6's list. `control-key` and `mcp` exist in the source tree but are
not in the web closure.
Three packages come from git, not crates.io, and have no `Cargo.lock` checksum: `craft-pdf`
and `krilla` at craft-libs `c3487320`, and `craft-ui` at craft-libs `d27646a5`. Their pin is the
git commit id.
Declared licenses are all permissive or have a permissive option. `Apache-2.0 OR GPL-2.0-only`
appears once and takes Apache-2.0. `epaint_default_fonts` carries OFL-1.1 and Ubuntu-font-1.0
font licenses, which need shipped notices. The full per-package list is in the companion
`.json`.
## Remaining work
- License findings: per-package notice obligations, font notices, git-dependency license files.
- Build scripts and proc-macros: what each runs at build time.
- D7 trace through all 15 local crates, including native-only cfg paths, and third-party
marker hotspots (eframe, rfd, web-sys, egui, image decoders, zip, flate2).
- Browser measurement and the CSP report (`2026-10-22_q195-editor-csp.md`).
- Findings, mandatory mitigations, residual risks and verdict.