webby: row 248 round 1 review, approve, and session line

agents/webby/work/queue-248/REVIEW-r1.md

@@ -0,0 +1,47 @@
+# Webby review: row 248 (#1750), round 1
+
+Webby, 2026-10-21T13:14Z (from `date -u`). Author: Sage. Request comment 30061 (sage-2001-review248,
+sage-2006). Reviewer by mos-1166. Brief: docs/plans/2026-10-20_host-credentials.md "Machine grant row b
+follow-up: the held stubs end with their test", blob 84bb8577fb23. Candidate: commit 4d99c178b, one
+commit on 540239b6b.
+
+What I checked, without runs or a worktree:
+- The candidate kind is commit, digest 4d99c178b3fc92f8fa48acd487f873fce8ffc9e3. I read it from the
+  canonical checkout. sage/row248 isn't on origin, so the commit exists only there for now.
+- 540239b6b..4d99c178b changes one file, packages/bus/tests/grant-executor.test.mjs (+3/-2). Nothing
+  under src changes, as the brief requires.
+- Overlap: refactor is bc579f7a8, and 540239b6b is its ancestor. 540239b6b..bc579f7a8 changes
+  docs/guides/host-run-sheet.md and the host-credentials plan, not the test file.
+- I read the stub fixture (test:52-96) and the three tests that set a hold flag (:427/:435, :675/:683,
+  :832/:839), plus the X5 test around :931.
+
+Sage's gate (row note, 13:05-13:07Z at 4d99c178b): three whole-file runs at 37/0 with 0 stubs left,
+the bus suite at 596/0, and the hold-add mutant leaves 2 stubs. Before the fix, 4 runs left 7. I ran
+nothing.
+
+## Verdict: APPROVE
+
+- The fix. Both hold loops (:67 add, :72 remove) now run only while `release` is missing and `$D`
+  is a directory. `D` is the mkdtemp dir (:63, :100), which `t.after` removes (:101). So once the
+  dir is gone, each loop ends within one 50 ms poll.
+- After the loop. With the dir gone, add finds no `skip`, `fail-add` or `noop-add`, and its append to
+  `$D/granted` fails, so it exits nonzero. Remove's `grep -v ... > granted.tmp` fails in the same
+  way. Both stubs end, which is all the brief asks. Their exit codes don't matter, since the test that
+  held them has already finished.
+- The test runs. While a test runs, its dir exists, so the new check can't end a hold early. The
+  three holding tests write `release` themselves (:435, :683, :839), so their behavior doesn't change.
+- The comment at :54 says both stubs also stop when the dir is gone, and it cites #1750. The :432
+  comment goes to row 249, as Sage said.
+- The gate matches the brief: three whole runs with no stub left, the bus suite green, and a mutant
+  that drops the hold-add check leaves a stub.
+
+## Non-blocking
+
+N1. There's a second leftover of the same kind, though it doesn't loop. The X5 test at :934 runs
+`sleep 30` through ForceCommand and the sudo stub (`exec "$@"`, :71), then revokes. The broker
+rejects the run, but under the brief's own sshd reasoning (no SIGHUP for a non-pty command), the
+remote `sleep 30` can keep running after the test ends and the daemon is SIGKILLed (:88). It ends on
+its own within 30 s. A pgrep on TMPDIR may not see it, since its argv is just `sleep 30`. I didn't
+run anything to confirm it lingers. If a lane cleanup that scans by cwd or process tree catches it in
+proof 3, a shorter sleep, or a stub that also exits once the dir is gone, would fix it. That could go
+in row 249 or a later row, not here.

docs/SESSIONS.md

@@ -1421,3 +1421,4 @@ are never rewritten or removed; corrections are new entries.
 2026-10-21T12:00Z | Webby (Opus 5.5, reviewer seat) | row 218 (#1719) C2-12 round 2 review, doc only | APPROVE 5fcc2ec90 manifest c0d3709d, N1-N4 fixed, N5 non-blocking; notes agents/webby/work/queue-218/REVIEW-r2.md
 2026-10-21T12:04Z | Webby (Opus 5.5, reviewer seat) | row 218 (#1719) C2-12 round 3 review, doc only | APPROVE 89ba79d94 manifest 1a38baf5, N5 fixed, no new notes; notes agents/webby/work/queue-218/REVIEW-r3.md
 2026-10-21T12:17Z | Webby (Opus 5.5, reviewer seat) | row 197 queue round 6 (Herb r8 c45ddeb6b, manifest 80dc1468), merge scope | APPROVE, N1 doc; notes agents/webby/work/queue-197/REVIEW-q6r8.md
+2026-10-21T13:15Z | Webby (Opus 5.5, reviewer seat) | row 248 round 1 (Sage 4d99c178b, grant-executor held stubs) | APPROVE, N1 sleep 30 residual; notes agents/webby/work/queue-248/REVIEW-r1.md