diff --git a/docs/scratchpads/1146-ci-queue-purpose.md b/docs/scratchpads/1146-ci-queue-purpose.md index ace90e8e..dae7f7fd 100644 --- a/docs/scratchpads/1146-ci-queue-purpose.md +++ b/docs/scratchpads/1146-ci-queue-purpose.md @@ -35,9 +35,23 @@ Make the pre-push queue guard wait for queued/running CI without requiring the p ## Tests -Pending. +- RED confirmed before implementation: the focused tri-state harness reported push `terminal-failure` and `no-status` as `ASSERTED_NOT_READY`. +- GREEN: `bash packages/mosaic/framework/tools/git/test-ci-queue-wait-tristate.sh` — all outcome classes passed. +- GREEN: `bash packages/mosaic/framework/tools/git/test-ci-queue-wait-github-checks.sh` — 6/6 purpose-aware cases passed. +- GREEN: `bash -n` passed for the changed guard and both focused harnesses. +- GREEN: `pnpm preflight`, `pnpm typecheck`, and `pnpm lint` passed. +- `pnpm test` ran 45/46 workspace test tasks successfully, but the pre-existing Gateway `cross-user-isolation.test.ts` failed during cleanup with PostgreSQL error `28P01` (local `mosaic` password authentication failure). The changed Mosaic framework test task passed within that run. +- GREEN: `pnpm --filter @mosaicstack/mosaic test` passed (81 Vitest files, 1,514 tests, plus the complete framework shell suite, including both queue-guard regressions). +- GREEN: `pnpm format:check` passed. +- Note: an additional ad hoc Prettier command was not applicable to shell files because Prettier has no shell parser; the repository-wide format check passed using its configured file globs. + +## Review + +- Independent Codex review of the six-file diff: approved, confidence 0.84, zero blockers/should-fix/suggestions. +- Review confirmed push queue-clear behavior, merge fail-closed behavior, and `--require-status` coverage. ## Risks and Blockers - A source-only fix does not update `~/.config/mosaic/tools/git/ci-queue-wait.sh`; local framework activation must use the reviewed installer path rather than a manual copy. +- Full baseline test completion is blocked by the unrelated local PostgreSQL authentication/cleanup failure described above; CI has its own disposable PostgreSQL service. - Existing `.mosaic/orchestrator/*` working-tree changes are unrelated and must remain unstaged.