build-log: row 172 landing, the dropped Seen click and the row 165 reload race (#1670)

This commit is contained in:
jason.woltje committed 2026-10-19 15:36:23 -05:00
1 parent 83db85aa3a
commit c24fe5d0ff
1 file changed
+11
+11
View File
@@ -5049,3 +5049,14 @@ Before: managed project/thread verbs had no Console conversation area. After: fi
- Pushes: fast-forward, no binaries, secrets grep clean, 0 attribution lines.
- Not live: the stack still runs 52f35e7a0. These go live only through a re-pin with Mos's go.
- The board-held sign-out wait tripped two of the three landing gates. It is row 172 (P19 366, #1670), being traced now; per mos-0858 the fix targets the cause, not a longer timeout.
2026-10-19 20:35:59 UTC | Sage | row 172 landed as be10e0c83 (#1670, P19 366, mos-0858)
- Before: the board-held sign-out wait tripped row 170 gate runs 1 and 3 and row 134 gate run 1. After: refactor at this entry, pushed.
- Cause 1, a product defect: the Board's Seen click handler returned while `busy`, which refresh() holds for the whole /api/board read and conversation poll. A click during a read was dropped, so no /api/seen went out and no sign-out came back. The failing-run trace has the click at about 595 ms, inside a 580-615 ms /api/board read, and no /api/seen.
- Fix 1: refresh() keeps its read in flight as `reading`. The click waits for it, looks the row up again and posts once; a `writing` flag drops a second click. The new board-held test holds the read and the POST to prove the order. The base fails it at :185; M1-M4 are killed.
- Cause 2, a test race: row 165's last step called location.reload() from an evaluate, and the next wait could start on the old document. Fix 2 loads the page with b.navigate on a new query. A 300 ms delayed reload reproduces the old failure every time.
- Not a timeout change. The webui suite ran 10 of 10 green (239 pass) after both fixes, and the full gate on 15c3d8ca1 passed (25 steps rc 0).
- Darkwing approved round 1 (29207, rev 2018). D1 and D2 (two packet lines) are fixed in 7f38a2f54. be10e0c83 is a cherry-pick of 15c3d8ca1: range-diff 1 = 1, stable patch-id fb6a65e7ec1d on both, evidence in the row note (rev 2019) before done (rev 2020).
- Push from 0ed9412fc through this entry: fast-forward, no binaries, secrets grep clean, 0 attribution lines.
- Not live: these go live only through a re-pin with Mos's go.