diff --git a/agents/duckworth/work/q180/REVIEW-r3.md b/agents/duckworth/work/q180/REVIEW-r3.md new file mode 100644 index 000000000..80c88efc5 --- /dev/null +++ b/agents/duckworth/work/q180/REVIEW-r3.md @@ -0,0 +1,70 @@ +# Review: ops-01 Q180 tightening plan r3 (duckworth-0028) + +Reviewer Duckworth (Opus 5.5), 2026-10-20. I reviewed the document only and ran nothing on pve, PBS, .53 or .54. +Subject: /mnt/storage/scratch/tmp/mosvk/q180-tightening-plan.md, sha256 cd7165bf…0bc3fce (checked), Vikunja +#421. Checked against duckworth-0023 (REVIEW-r2.md, 523a6bddf) and mos-1041 as ops-01 relays it. + +## Verdict: changes, B6 + +B1 to B5 are resolved, and so are N1 to N3: +- B1: the Jason checklist does what B1 asked. It adds a fresh login with the new key on every remaining + account before 1d, 2a, 2b and 2c. It adds a console password tested through noVNC, and a pve web login + from the non-factory machine only. That last one is Mos's N4, and the browser-profile reason is right. + localadmin's sudo takes a password. +- B2: the new key never touches a factory host, and the FIDO-on-dragon-lin option is gone. +- B3: after the change, each account restarts its user manager and runs terminate-user. A /proc `Groups:` + count must then be 0. uid 0 processes are found by loginuid. The Docker TCP and socket-mount checks were + read at 19:39Z and get re-read right before 2a. +- B4: the order is guest first, then pve, and is checked at the next boot. The 09:00Z boot of 1012 gets a + meta dump before and after, an instance-id comparison and hashes. +- B5: §1.4 closes each path or gives it an owner. The hub's sign-in issuer is open, and Sage owns it. The + plan says that the row has to be filled before the plan is complete. That meets B5. It also means R8 + can't pass until the row is filled. +- N1: two roles, and no pools. Your `nodes/pve/report` finding (Report.pm dumps guest configs raw, so the + `cipassword` hash comes through `Sys.Audit`) is a good catch. Step 1a2, done before `OpsAuditHost` is + granted, is the right fix. +- N2 and N3: done. + +## Blocker + +B6. Root access already granted isn't undone by removing it. This is new in r3, and it is my miss in r2. +For a long time, factory processes had root on all four hosts: +- the jason key, which is dragon-lin's key, on pve, PBS and root on .53 and .54 +- jarvis@w-jarvis on pve, 1416 Hermes logins +- NOPASSWD sudo for jarvis and melanie + +The plan removes these paths, but anything a factory process left behind as root survives that. Examples: +- another file in sudoers.d +- a key in a different user's `authorized_keys`, or in `/etc/pve/priv/authorized_keys` +- a uid 0 line in `/etc/passwd` +- a root cron entry or systemd unit +- a setuid binary, `ld.so.preload`, or a PAM or sshd drop-in +The hub (.54) is the host where R8 needs this ruled out. The plan needs one of these, before 2b, with an +owner: +- (a) A read-only sweep on pve, PBS, .53 and .54, reported by name, owner, mode and hash only: + - every file in `/etc/sudoers.d` and `/etc/sudoers` + - every `authorized_keys` file on the host, found with `sshd -T`'s `authorizedkeysfile`, plus any + `authorizedkeyscommand` + - uid 0 and gid 0 accounts in `/etc/passwd` + - root and system crontabs and `/etc/cron.*` + - units in `/etc/systemd/system` and `/etc/systemd/user` that no package owns + - setuid and setgid files that no package owns, and `dpkg -V` failures for sudo, openssh, pam and + systemd + - `/etc/ld.so.preload`, and drop-ins under `/etc/pam.d` and `/etc/ssh/sshd_config.d` + + Jason reviews anything unexpected, and the sweep runs again after §2. +- (b) Rebuild 1012 from a clean image instead of cleaning it in place. That fits N2 too, since Melanie's + Hermes has to leave the hub anyway. + +## Notes (do not block) + +N4. localadmin's password has to exist at 1a. 1a creates localadmin with sudo by password, and the +checklist runs `sudo -v` there before 2a. But the console-password line says "before 2c". Jason sets the +password himself with `passwd localadmin` in the pve console when 1a runs. It never goes through a factory +session or script. The noVNC test can stay before 2c, or move up to 1a. +N5. Before `OpsAuditHost` is granted, run `pvereport` once as root on pve. Count the matches for password, +secret, token, key and `BEGIN` lines, and print counts only. That checks your by-filename reading of +Report.pm against this PVE build. +N6. On pve, `/root/.ssh/authorized_keys` is a link to `/etc/pve/priv/authorized_keys`, which the cluster +filesystem holds. Edit that file, copy that file, and say so in 1d. Then check that `pvecm updatecerts` (or +an upgrade) doesn't add back anything other than root@pve. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 40b26618e..07caa9b23 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1385,3 +1385,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-20T19:36Z | Duckworth (Opus 5.5) | row 196 build mismatch reply (duckworth-0025), gander-0017 | libuv unlink confirmed; rename-into-place recommended, residual acceptable 2026-10-20T19:39Z | Duckworth (Opus 5.5) | row 199 design r5 review (duckworth-0026), Megavolt 34bfe4a53 DESIGN.md sha256 d0b326bb | changes B5 (D9a ls-remote and push still name the upstream, not the derived fork), B6 (state the URL parse, name rule, case-insensitive owner compare) 2026-10-20T19:42Z | Duckworth (Opus 5.5) | row 199 design r6 review (duckworth-0027), Megavolt 4d3007ec9 DESIGN.md sha256 aa458dfe | approve; B5 B6 N10 N11 resolved, D9c normalization claims checked in node +2026-10-20T19:44Z | Duckworth (Opus 5.5) | Q180 tightening plan r3 review (duckworth-0028), ops-01 plan sha256 cd7165bf, #421 | changes B6 (root persistence sweep on all four hosts or rebuild 1012); B1-B5 N1-N3 resolved