docs(records): row 25 approver fix, second Discord restart, SetSpark approver and docker network gaps
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
@@ -3074,3 +3074,49 @@ extension enables the eight record and approval verbs from it. Receipt
|
||||
(0600): `restart-row25-20260926T205803Z.txt` in the Sage evidence directory.
|
||||
Jason's live check (one work item, one proposal approved by button) is still
|
||||
to do.
|
||||
|
||||
## 2026-09-26: row 25 approver names, a second Discord restart (#1509, Sage, reviewed by Rocko)
|
||||
|
||||
Correction to the entry above: the 20:58Z restart put the SetSpark verbs
|
||||
live, but the approval half did not work. In Jason's live check, SS-027 was
|
||||
created and read back. DEC-009 was also created, but no Approve button was
|
||||
posted. The Discord Sage had written `required_approvers` as `["Jason",
|
||||
"Carmen"]`. The SetSpark service stores approvers as `discord:<id>` and
|
||||
accepted the names without checking them. `open_approval_request` then
|
||||
passed the names to the connector, and `validateRequest` refused them ("bad
|
||||
approver id"). The connector was right to refuse. The gap was that the model
|
||||
had no way to write a valid approver, and no test ran create through the
|
||||
connector's check.
|
||||
|
||||
After: 20ea5a0b.
|
||||
- The binding's `users` provide the approver names.
|
||||
- `record_create` and `record_update` turn each name into `discord:<id>`.
|
||||
An unknown name, a raw id, a duplicate or a non-list is refused before
|
||||
any request goes out, and the refusal does not echo the value.
|
||||
- `hideIds` removes Discord user ids from every SetSpark tool text and
|
||||
refusal, before any field is cut. The connector's approval request still
|
||||
carries the bare ids.
|
||||
- With `setspark` set, a reload that changes a user's id or name is refused.
|
||||
That change needs a restart.
|
||||
- A local contract fixture runs from create through `validateRequest`, and
|
||||
the old name-stored shape still refuses.
|
||||
|
||||
Rocko asked for two revisions. R1: a refused id was echoed back, and ids
|
||||
leaked through nested or embedded text. R2: the service code and bad
|
||||
property names were cut before hiding. Rocko approved R3 (81379830…, report
|
||||
da75219f…). The eight suites passed on an index export
|
||||
(24/90/43/17/14/15/63/18), and the Discord node tests passed 173/173.
|
||||
|
||||
The first R3 task and release runs failed 31 and 3 tests. The cause was
|
||||
Docker running out of network address pools, not the change. My own stale
|
||||
index-export compose networks had used them up. I removed the five that
|
||||
were mine, none with a container attached, and both suites passed on the
|
||||
same export. Follow-up in DEFERRED.
|
||||
|
||||
Restart at 21:30:21Z from 20ea5a0b, with `packages/discord` clean. Old PID
|
||||
499064 stopped cleanly. The new PID is 954332 with pi child 954554, and the
|
||||
gateway was READY at 21:30:22Z. Pi's `setspark` config has the approver
|
||||
names jason and carmen. Receipt (0600):
|
||||
`restart-row25-approvers-20260926T213021Z.txt`. Jason reruns the approval
|
||||
check. DEC-009 needs a `record_update` to names, or a new decision, and
|
||||
then a new approval request.
|
||||
|
||||
Reference in New Issue
Block a user