mosaicstack/stack
21
0
Fork 1
Code Issues 338 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

fix(CQ-ORCH-9): Deduplicate spawn validation logic

Browse Source 
Remove duplicate validateSpawnRequest from AgentsController. Validation
is now handled exclusively by:
1. ValidationPipe + DTO decorators (HTTP layer, class-validator)
2. AgentSpawnerService.validateSpawnRequest (business logic layer)

This eliminates the maintenance burden and divergence risk of having
identical validation in two places. Controller tests for the removed
duplicate validation are also removed since they are fully covered by
the service tests and DTO validation decorators.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
This commit is contained in:
Jason Woltje
2026-02-06 14:09:06 -06:00
co-authored by Claude Opus 4.6
parent a0062494b7
commit c9ad3a661a
2 changed files with 3 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/orchestrator/src/api/agents/agents.controller.spec.ts
-75
View File
@@ -3,7 +3,6 @@ import { QueueService } from "../../queue/queue.service";
import { AgentSpawnerService } from "../../spawner/agent-spawner.service";
import { AgentLifecycleService } from "../../spawner/agent-lifecycle.service";
import { KillswitchService } from "../../killswitch/killswitch.service";
import { BadRequestException } from "@nestjs/common";
import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
describe("AgentsController", () => {
@@ -289,80 +288,6 @@ describe("AgentsController", () => {
expect(result.agentId).toBe(agentId);
});
it("should throw BadRequestException when taskId is missing", async () => {
// Arrange
const invalidRequest = {
agentType: "worker" as const,
context: validRequest.context,
} as unknown as typeof validRequest;
// Act & Assert
await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
expect(queueService.addTask).not.toHaveBeenCalled();
});
it("should throw BadRequestException when agentType is invalid", async () => {
// Arrange
const invalidRequest = {
...validRequest,
agentType: "invalid" as unknown as "worker",
};
// Act & Assert
await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
expect(queueService.addTask).not.toHaveBeenCalled();
});
it("should throw BadRequestException when repository is missing", async () => {
// Arrange
const invalidRequest = {
...validRequest,
context: {
...validRequest.context,
repository: "",
},
};
// Act & Assert
await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
expect(queueService.addTask).not.toHaveBeenCalled();
});
it("should throw BadRequestException when branch is missing", async () => {
// Arrange
const invalidRequest = {
...validRequest,
context: {
...validRequest.context,
branch: "",
},
};
// Act & Assert
await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
expect(queueService.addTask).not.toHaveBeenCalled();
});
it("should throw BadRequestException when workItems is empty", async () => {
// Arrange
const invalidRequest = {
...validRequest,
context: {
...validRequest.context,
workItems: [],
},
};
// Act & Assert
await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
expect(queueService.addTask).not.toHaveBeenCalled();
});
it("should propagate errors from spawner service", async () => {
// Arrange
const error = new Error("Spawner failed");