row 198 r3: drop --board for every op, reason by target (sage-2837)

install_stack runs webui-service.sh install on activate as well as rollback,
and that install refuses --board. A re-pin to a pre-198 copy would therefore
fail the same way a rollback did. console_for_target now drops the pair for
every op. The reason follows the target's cli.mjs: a target that parses
--board is pre-198 and the 7331 board is retired; one that does not runs the
board in the Console.

M13 covers a kept --board for a parsing target on activate --plan and on
rollback --plan. The webui README rollback note covers any move to a pre-198
copy. BUILD.md's Ruled section is updated to match.

UNVERIFIED: bash -n only; no node or tests run (Sage's gate).
This commit is contained in:
jason.woltje committed 2026-10-23 13:58:36 -05:00
1 parent 77c12b5545
commit c9c8badc3e
4 files changed
+49 -31

No files matched your search

+6 -6
View File
@@ -809,18 +809,18 @@ console_for_target() {
local cli="$COPIES/$TO/packages/webui/src/cli.mjs"
local -a without_tester=()
sso_base
# Row 198 (design item 8, Sage sage-2834 ruling a): --board stays only for an activate whose target's
# Console parses it. A rollback always drops it: 7331 is retired and webui-service.sh install refuses
# the flag, so a kept flag would fail the rollback at install-console. Each drop is named in the plan
# and the steps. The check reads the target's own cli.mjs, as --tester-port does.
# Row 198 (design item 8, Sage sage-2834 ruling a, sage-2837): --board is dropped for every op.
# webui-service.sh install refuses the flag, so a kept flag fails at install-console, on a rollback
# and on an activate to a pre-198 copy alike. The reason follows the target: a target that parses
# --board is pre-198 (7331 is retired); one that does not runs the board in the Console. Each drop
# is named in the plan and the steps. The check reads the target's own cli.mjs, as --tester-port does.
DROP_BOARD="" DROP_BOARD_WHY=""
local -a kept=()
for ((i = 0; i < ${#BASE_CONSOLE[@]}; i++)); do
if [ "${BASE_CONSOLE[i]}" != --board ]; then kept+=("${BASE_CONSOLE[i]}"); continue; fi
i=$((i + 1))
if [ "$OP" != rollback ] && parses_flag "$cli" --board; then kept+=(--board "${BASE_CONSOLE[i]:-}"); continue; fi
DROP_BOARD="--board ${BASE_CONSOLE[i]:-}"
if [ "$OP" = rollback ]; then DROP_BOARD_WHY="the 7331 board is retired, so the rolled-back Console runs without the board"
if parses_flag "$cli" --board; then DROP_BOARD_WHY="the 7331 board is retired, so this Console runs without the board"
else DROP_BOARD_WHY="the target Console does not parse it, so the board runs in the Console"; fi
done
BASE_CONSOLE=("${kept[@]}")