diff --git a/agents/webby/work/queue-198/REVIEW-r3.md b/agents/webby/work/queue-198/REVIEW-r3.md new file mode 100644 index 000000000..3407e973d --- /dev/null +++ b/agents/webby/work/queue-198/REVIEW-r3.md @@ -0,0 +1,40 @@ +# Webby review: row 198 design rev 3 (#1696) + +Webby, 2026-10-20T19:36Z (from `date -u`). Author: Bushroot. Subject: `agents/bushroot/work/queue-198/DESIGN.md` +at 7e2ead7f3, sha256 51343813...8302 (verified). I read the whole file and checked it against my rev 1 review +(REVIEW.md) and sage-1372. Code read at the base, aa1bd209e. Static review. I ran nothing. + +## Verdict: CHANGES + +My rev 1 B1-B3 are fixed. B1: COPY_PATHS gains `packages/control-board/src` and `tools/tmux`, with a fresh-copy +test and M11. B2: the `--board` drop in `console_for_target`, with M12 and M13. B3: both POSTs sit above +serve.mjs:557-558 behind `send !== null && named`, loopback refuses them with 403, and M10 covers it. N1-N5 are in. +The sage-1372 rulings read right. At aa1bd209e, webui-service.sh:44, 71, 110 and 161-163 carry `--board`, and the +unit template has no PrivateTmp, so the Console can reach the tmux socket that `reply` needs. + +One new blocker, which comes from moving the board in-process. + +## Blocker + +B1. In-process, the board's child calls block the Console's event loop. `scan` checks each seat with +`tmuxInspect`, which runs `spawnSync("tmux", ..., { timeout: 5000 })` (control-board scan.mjs:196-200). +`replyToRow` runs `agent-send.sh` through `spawnSync` with a 15 s timeout (serve.mjs:68, :94). Today those block +only the 7331 process. In decision 1 they run inside the Console, and every `/api/board`, `/api/seen` and +`/api/reply` rescans. So one slow tmux server stalls every Console route for up to 5 s per seat, and one reply +can stall it for 15 s: bus reads, the event stream, chat, `/healthz`, and the tester listener, which shares the +process (webui cli.mjs:91). The Console already avoids this for the bus. webui bus.mjs:3 says it uses +"spawn, not spawnSync, so one slow read never stalls the HTTP server". +Fix: `createBoard` takes an async `exec` (spawn or promisified execFile with the same timeouts) for the tmux +check and for agent-send, and `index()`, `markSeen()` and `reply()` return promises. The board's sync exports +stay for `scan` on the CLI. Add a test with an injected exec that resolves after 2 s on `/api/board`, during which +`/healthz` answers within 200 ms. Add a mutant that swaps in a blocking exec, which that test kills. + +## Non-blocking + +N1. Decision 8's last two sentences put the 7331 fallback on the wrong copy. A copy that doesn't parse +`--board` is a new one, with no board URL at all. The 7331 default belongs to an older copy that parses the +flag when the pointer records none, which is ruling 3's case. Rewrite those sentences. +N2. `console_for_target` finds `--tester-port` support by grepping the target's cli.mjs (stack-release.sh:670). +If the `--board` check copies that, a cli.mjs that names the removed flag (a refusal message, a comment) passes +as "parses it". Pick a check that a refusal can't match, and give M12 a target whose cli.mjs mentions `--board` +only in a refusal. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 46321c5af..89f86a4ed 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1369,3 +1369,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-20T19:29:11Z | Webby (Opus 5.5, reviewer seat) | Case 2 design r2 review for Gosalyn (#416, DESIGN.md sha256 bda7a717 at c1913fb07), static | changes: B1 top-level playground has no universe, B2 persona.text storage and tester read, B3 THREAD_DEFINITION in launch-settings must stay assistant, B4 persona block position and fence; N1-N4; notes agents/webby/work/case2-r2/REVIEW.md 2026-10-20T19:31:52Z | Webby (Opus 5.5, reviewer seat) | row 194 design r2 re-review for Honker (#1692, DESIGN.md 313c206e and PRD-1.7-DRAFT.md 98f4f49e at c0a35f47a), static | changes: B1 hire floor is a deny list that misses git.merge.protected (merge-gate.json, no credentials), decision.resolve.technical, policy.change, prd.approve, instance.name; make it an allowlist. r1 B1, B3-B8, Q2, N1-N8 fixed; Q4 view: start empty; notes agents/webby/work/queue-194/REVIEW-r2.md 2026-10-20T19:33:02Z | Webby (Opus 5.5, reviewer seat) | row 194 design r3 review for Honker (#1692, DESIGN.md 885fce0d and PRD-1.7-DRAFT.md 04c32917 at d0afda024), static | changes: r2 B1 stands except instance.name (allowlist); B2 fire delist and claim revoke can't share a transaction, name order and recovery; N1 REQ-LAND-2 relies on Gitea refusal, N2 recheck by start time; notes agents/webby/work/queue-194/REVIEW-r3.md +2026-10-20T19:36:19Z | Webby (Opus 5.5, reviewer seat) | row 198 design rev 3 re-review for Bushroot (#1696, DESIGN.md 51343813 at 7e2ead7f3), static | changes: rev 1 B1-B3 and N1-N5 fixed, sage-1372 rulings read right; new B1 in-process board runs spawnSync tmux (5 s per seat) and agent-send (15 s) in the Console event loop, make createBoard async with a stall test and mutant; N1 decision 8 fallback sentences, N2 --board support check must not match a refusal; notes agents/webby/work/queue-198/REVIEW-r3.md