diff --git a/agents/webby/work/queue-197/REVIEW-manifest-r2.md b/agents/webby/work/queue-197/REVIEW-manifest-r2.md new file mode 100644 index 000000000..6572616e7 --- /dev/null +++ b/agents/webby/work/queue-197/REVIEW-manifest-r2.md @@ -0,0 +1,17 @@ +# Webby review: row 197 manifest r2 (#1695) + +Webby, 2026-10-20T19:44Z (from `date -u`). Author: Herb. Subject: `agents/herb/work/queue-197/MANIFEST.md` at +bdc9cd56a, sha256 2a1a3ad0...7cec (verified). Read as the diff from 84f21923c (my REVIEW-manifest.md), against +aa1bd209e. Static review. I ran nothing. + +## Verdict: APPROVE + +B1 is fixed. P2 keeps every literal Board `:9` URL, and `closedEndpoint` is gone from T4. The two leases left +are real close-then-rebind cases. preview.test.mjs:208-209 and serve.test.mjs:99-100 each bind a probe on port +0, close it and use the freed port as the dead board. Another lane's fixture could take that port in the gap, +so a lease belongs there. T1 refuses a listener covering 127.0.0.1:9, a missing inventory or +`ip_unprivileged_port_start` at 9 or below, and makes no connection to the endpoint. + +N1 is in P3. Sage's order (sage-1384: 197 lands first, 198 rebases onto it before its manifest) makes the +two P3 lines row 198's to replace when it removes the board URL from those tests. The BUILD-LOG change is one +appended correction entry. diff --git a/docs/SESSIONS.md b/docs/SESSIONS.md index 1ba180082..02b45eeba 100644 --- a/docs/SESSIONS.md +++ b/docs/SESSIONS.md @@ -1373,3 +1373,4 @@ are never rewritten or removed; corrections are new entries. 2026-10-20T19:37:29Z | Webby (Opus 5.5, reviewer seat) | row 197 manifest review for Herb (#1695, MANIFEST.md 16768433 at 84f21923c, TIMING.md 148a1416 at fa820fed6), static | changes: B1 drop dead Board :9 replacements (port below unprivileged floor 1024, not shared by lanes, 20 files, collides with row 198), add a :9 listener preflight refusal; N1 row 198 overlap for Sage; notes agents/webby/work/queue-197/REVIEW-manifest.md 2026-10-20T19:38:46Z | Webby (Opus 5.5, reviewer seat) | row 194 design r4 re-review for Honker (#1692, DESIGN.md 824ef884 and PRD-1.7-DRAFT.md 379cc318 at 7d0788236), static | approve: HIRE_ALLOWED allowlist checked against role files, fire order A-B-C repeatable; N1 launch should refuse a listed instance mid-fire, N2 hire-time check should require role version 2; notes agents/webby/work/queue-194/REVIEW-r4.md 2026-10-20T19:39:47Z | Webby (Opus 5.5, reviewer seat) | row 198 design rev 4 re-review for Bushroot (#1696, DESIGN.md 5ef6436f at 9af75dc72), static | changes: B1 and N1 fixed, --board parse check right; new B1 parses_flag swap at stack-release.sh:670 breaks the tester-port fixtures (stack-release.test.mjs:265, T37), keep it to --board; N1 index coalescing can return a scan from before markSeen's write; notes agents/webby/work/queue-198/REVIEW-r4.md +2026-10-20T19:40:29Z | Webby (Opus 5.5, reviewer seat) | row 197 manifest r2 re-review for Herb (#1695, MANIFEST.md 2a1a3ad0 at bdc9cd56a), static | approve: literal Board :9 URLs kept, leases only at the close-rebind probes (preview.test:208, serve.test:100), T1 :9 preflight; P3 row 198 order per sage-1384; notes agents/webby/work/queue-197/REVIEW-manifest-r2.md