From cbe4c82657413cf88cdd9eaebb5b8ce487368a59 Mon Sep 17 00:00:00 2001 From: Jason Woltje Date: Mon, 19 Oct 2026 23:34:17 -0500 Subject: [PATCH] queue: revs 2135-2143: row 181 round 1 in-review #1679 comment 29370 (Darkwing 2135-2136); rows 182-184 brief re-pins to 3459e01c3358 (Sage 2137-2139); row 183 reviewer Dewey, owner Researcher, briefed (Sage 2140-2142), started (Researcher 2143) --- docs/plans/QUEUE.md | 6 +- docs/plans/queue.json | 311 ++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 299 insertions(+), 18 deletions(-) diff --git a/docs/plans/QUEUE.md b/docs/plans/QUEUE.md index e32c25306..8e18e9a71 100644 --- a/docs/plans/QUEUE.md +++ b/docs/plans/QUEUE.md @@ -33,7 +33,7 @@ Gaps found while working go to `docs/plans/DEFERRED.md`, not here. -Generated from `docs/plans/queue.json` revision 2134 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. +Generated from `docs/plans/queue.json` revision 2143 by `queue render`. Do not edit between the markers; change the queue with `scripts/mosaic queue`. | # | Piece | Owner | Issues | State | After | Gate | Brief | Note | |---|---|---|---|---|---|---|---|---| @@ -217,9 +217,9 @@ Generated from `docs/plans/queue.json` revision 2134 by `queue render`. Do not e | 178 | Console proxy proof: --proof-header and --proof-file, a signed-in request without Traefik's secret header gets 401; partial fix after the window rows, same-uid limit recorded, uid separation is Jason's on #385; console-proof.token slot, ops-01 middleware (#1676, Vikunja #385, mos-0874, mos-0878) | rocko; reviewers dewey | #1676 | in-review, round 1, request posted | 169 done, 175 done, 176 done | Reviewer approves the candidate manifest; webui and cli suites and every scripts/test-*.sh green on Sage's gate; nothing live changes at landing (sage) | `docs/plans/2026-10-19_console-proxy-proof.md` § Brief: the Console checks that a signed-in request came through Traefik | — | | 179 | docs/TOOLS.md follow-ups F1-F3 from the row 169 review | darkwing; reviewers dewey | #1677 | done | 169 done | Dewey approves the candidate manifest; no suite when no test reads docs/TOOLS.md (decision 137) (sage) | `docs/plans/2026-10-19_tools-md-169-followups.md` § Brief: docs/TOOLS.md follow-ups from the row 169 review | Landed 9e74925c2 on ce5807989 (Sage, temp index). Candidate manifest 2b161c51 approved by Dewey (29271); landed docs/TOOLS.md sha256 67acbed1 matches it. patch-id 35e385ff93cb matches Darkwing's packet. Doc-only, no suite: only stack-release.test.mjs:428 names TOOLS.md, in an expected message string (decision 137). | | 180 | stack-release activation ids unique within one second (P19 391); --plan refusals in console_for_target through check_refuse, new code tester-port-invalid (row 176 N1); webui-service tester_port_ok length before zero strip (N2) (#1678) | darkwing; reviewers dewey | #1678 | done | — | Dewey approves the candidate manifest; cli and webui suites and every scripts/test-*.sh green on Sage's gate, a killed mutant per item (sage) | `docs/plans/2026-10-20_stack-release-after-window.md` § Brief: activation ids and plan-mode refusals (row A) | Landed on refactor as 1905e385c on 828d14a0c (Darkwing author). Patch-id 31b1d502444e equals the gate candidate (build.patch, manifest c743480e approved by Dewey 29361). Gate on 828d14a0c+candidate: GATE_PASSED, 25 steps rc=0, node 2482 pass 0 fail, scripts 422 pass 0 fail plus queue 156, network removed, 0 containers. | -| 181 | stack-release --restore guard counts every table a restore drops rows from, not only events; every schema table classified into one of four lists; UPDATE gaps recorded (P19 390, mos-0927 R1) (#1679) | darkwing; reviewers filbert | #1679 | in-progress | 180 done | Filbert approves the candidate manifest; cli suite and every scripts/test-*.sh green on Sage's gate, the brief's mutants killed (sage) | `docs/plans/2026-10-20_stack-release-after-window.md` § Brief: the restore guard counts every row a restore drops (row B) | — | +| 181 | stack-release --restore guard counts every table a restore drops rows from, not only events; every schema table classified into one of four lists; UPDATE gaps recorded (P19 390, mos-0927 R1) (#1679) | darkwing; reviewers filbert | #1679 | in-review, round 1, request posted | 180 done | Filbert approves the candidate manifest; cli suite and every scripts/test-*.sh green on Sage's gate, the brief's mutants killed (sage) | `docs/plans/2026-10-20_stack-release-after-window.md` § Brief: the restore guard counts every row a restore drops (row B) | — | | 182 | Bus: a tester message reaches only a tester-owned thread (row 177 follow-up N1) | sage | #1680 | queued | — | Reviewer approves the manifest; bus, cli, webui suites and every scripts/test-*.sh green on Sage's gate; owner-check mutant killed (sage) | `docs/plans/2026-10-20_tester-thread-follow-ups.md` § Brief: a tester message reaches only a tester-owned thread (N1) | — | -| 183 | Webui: chat.mjs names the transport it is given (row 177 follow-up N2) | sage | #1681 | queued | — | Reviewer approves the manifest; webui suite and the scripts/test-*.sh that read webui paths green on Sage's gate; old-text mutant killed (sage) | `docs/plans/2026-10-20_tester-thread-follow-ups.md` § Brief: chat.mjs names the transport it is given (N2) | — | +| 183 | Webui: chat.mjs names the transport it is given (row 177 follow-up N2) | researcher; reviewers dewey | #1681 | in-progress | — | Reviewer approves the manifest; webui suite and the scripts/test-*.sh that read webui paths green on Sage's gate; old-text mutant killed (sage) | `docs/plans/2026-10-20_tester-thread-follow-ups.md` § Brief: chat.mjs names the transport it is given (N2) | — | | 184 | CLI: tester thread verbs (thread create\|open\|read, threads, talk/follow --thread with --tester) | sage | #1682 | queued | — | Reviewer approves the manifest; cli and bus suites and every scripts/test-*.sh green on Sage's gate; both mutants killed (sage) | `docs/plans/2026-10-20_tester-thread-follow-ups.md` § Brief: tester thread verbs in the CLI | — | diff --git a/docs/plans/queue.json b/docs/plans/queue.json index 23c58d7c9..644debd45 100644 --- a/docs/plans/queue.json +++ b/docs/plans/queue.json @@ -1,7 +1,7 @@ { "version": 1, "canonicalRoot": "/mnt/storage/src/mosaic-stack", - "revision": 2134, + "revision": 2143, "rows": [ { "id": 1, @@ -18949,7 +18949,7 @@ "closes": [ 1679 ], - "state": "in-progress", + "state": "in-review", "previousState": null, "required": false, "requiredSince": null, @@ -18969,7 +18969,41 @@ "reviewers": [ "filbert" ], - "review": null, + "review": { + "rounds": [ + { + "n": 1, + "op": "darkwing-181-inreview-1", + "by": "darkwing", + "at": "2026-10-20T04:24:53.604Z", + "issue": 1679, + "candidate": { + "kind": "manifest", + "digest": "46a4433ca4108682af2027dc27ad72359b45709006f809fbf45c4b45dfacc283", + "text": "64f947a040d95b90b006dad43d6140eb4533082925e4e2a82ac4dc91c773f139 scripts/stack-release.sh\n5ea483c114901de585a500e9cd87a02f5c06a63bb62f106290578784db6ca7d0 packages/cli/tests/stack-release.test.mjs\n4756c0ccf43be061ce9d2361882ec2ab78a0d2b622cda5224669d6bfd9bdda3b docs/TOOLS.md\n" + }, + "request": "comment", + "attempts": [ + { + "op": "darkwing-181-inreview-1", + "by": "darkwing", + "at": "2026-10-20T04:24:53.604Z", + "state": "posted", + "comment": 29370, + "transport": { + "outcome": "posted", + "status": 201, + "comment": 29370, + "detail": "created" + }, + "resolutions": [] + } + ], + "duplicateRisk": false, + "receipts": [] + } + ] + }, "claim": { "seat": "darkwing", "op": "darkwing-181-start-1" @@ -18977,7 +19011,7 @@ "note": null, "blockedReason": null, "createdAt": "2026-10-20T02:31:48.085Z", - "updatedAt": "2026-10-20T03:56:10.136Z", + "updatedAt": "2026-10-20T04:25:11.827Z", "updatedBy": "darkwing" }, { @@ -18999,7 +19033,7 @@ "brief": { "path": "docs/plans/2026-10-20_tester-thread-follow-ups.md", "anchor": "Brief: a tester message reaches only a tester-owned thread (N1)", - "blob": "2c2227d82b7b4100b6a025f23c50d1a62f0b8197" + "blob": "3459e01c3358014efb861dca78d469cce6da6afe" }, "after": [], "reviewers": [], @@ -19008,20 +19042,20 @@ "note": null, "blockedReason": null, "createdAt": "2026-10-20T03:30:55.306Z", - "updatedAt": "2026-10-20T03:32:08.084Z", + "updatedAt": "2026-10-20T04:26:27.095Z", "updatedBy": "sage" }, { "id": 183, "piece": "Webui: chat.mjs names the transport it is given (row 177 follow-up N2)", - "owner": "sage", + "owner": "researcher", "issues": [ 1681 ], "closes": [ 1681 ], - "state": "queued", + "state": "in-progress", "previousState": null, "required": false, "requiredSince": null, @@ -19030,17 +19064,22 @@ "brief": { "path": "docs/plans/2026-10-20_tester-thread-follow-ups.md", "anchor": "Brief: chat.mjs names the transport it is given (N2)", - "blob": "2c2227d82b7b4100b6a025f23c50d1a62f0b8197" + "blob": "3459e01c3358014efb861dca78d469cce6da6afe" }, "after": [], - "reviewers": [], + "reviewers": [ + "dewey" + ], "review": null, - "claim": null, + "claim": { + "seat": "researcher", + "op": "researcher-183-start-1" + }, "note": null, "blockedReason": null, "createdAt": "2026-10-20T03:31:10.893Z", - "updatedAt": "2026-10-20T03:32:23.862Z", - "updatedBy": "sage" + "updatedAt": "2026-10-20T04:29:26.889Z", + "updatedBy": "researcher" }, { "id": 184, @@ -19061,7 +19100,7 @@ "brief": { "path": "docs/plans/2026-10-20_tester-thread-follow-ups.md", "anchor": "Brief: tester thread verbs in the CLI", - "blob": "2c2227d82b7b4100b6a025f23c50d1a62f0b8197" + "blob": "3459e01c3358014efb861dca78d469cce6da6afe" }, "after": [], "reviewers": [], @@ -19070,7 +19109,7 @@ "note": null, "blockedReason": null, "createdAt": "2026-10-20T03:31:26.073Z", - "updatedAt": "2026-10-20T03:32:39.721Z", + "updatedAt": "2026-10-20T04:26:58.077Z", "updatedBy": "sage" } ], @@ -75452,6 +75491,248 @@ "receipt": "ok sage-178-review-r1b.outcome rev 2134 row 178 round 1 request sage-178-review-r1b posted comment 29368" }, "viewSha": "d46ea60acd0847d406bd597e5cc4539dc656d1aa0d4f1423503b3fc0659714a9" + }, + { + "rev": 2135, + "op": "darkwing-181-inreview-1", + "verb": "move", + "args": { + "id": 181, + "to": "in-review", + "reason": null, + "candidate": "agents/darkwing/work/queue-181/candidate-manifest.sha256", + "evidence": null, + "issue": null + }, + "by": "darkwing", + "at": "2026-10-20T04:24:53.604Z", + "semantics": 2, + "result": { + "row": 181, + "from": "in-progress", + "to": "in-review", + "round": 1, + "issue": 1679, + "candidate": { + "kind": "manifest", + "digest": "46a4433ca4108682af2027dc27ad72359b45709006f809fbf45c4b45dfacc283", + "text": "64f947a040d95b90b006dad43d6140eb4533082925e4e2a82ac4dc91c773f139 scripts/stack-release.sh\n5ea483c114901de585a500e9cd87a02f5c06a63bb62f106290578784db6ca7d0 packages/cli/tests/stack-release.test.mjs\n4756c0ccf43be061ce9d2361882ec2ab78a0d2b622cda5224669d6bfd9bdda3b docs/TOOLS.md\n" + }, + "receipt": "ok darkwing-181-inreview-1 rev 2135 row 181 in-progress→in-review round 1 on #1679; request darkwing-181-inreview-1 requesting" + }, + "viewSha": "c53652df31899a09a7ca165a82bead7c8a47775d34c74f7680979a3997ebd4c3" + }, + { + "rev": 2136, + "op": "darkwing-181-inreview-1.outcome", + "verb": "review-outcome", + "args": { + "id": 181, + "attempt": "darkwing-181-inreview-1", + "outcome": "posted", + "status": 201, + "comment": 29370, + "detail": "created" + }, + "by": "darkwing", + "at": "2026-10-20T04:25:11.827Z", + "semantics": 2, + "result": { + "row": 181, + "round": 1, + "attempt": "darkwing-181-inreview-1", + "state": "posted", + "receipt": "ok darkwing-181-inreview-1.outcome rev 2136 row 181 round 1 request darkwing-181-inreview-1 posted comment 29370" + }, + "viewSha": "0d51b28cf58130d4d166bd12d37f6a246522574b5205c2a02dc5fa50c478fa6f" + }, + { + "rev": 2137, + "op": "sage-182-brief-repin", + "verb": "set", + "args": { + "id": 182, + "field": "brief", + "value": "docs/plans/2026-10-20_tester-thread-follow-ups.md#Brief: a tester message reaches only a tester-owned thread (N1)", + "reason": null + }, + "by": "sage", + "at": "2026-10-20T04:26:27.095Z", + "semantics": 2, + "result": { + "row": 182, + "field": "brief", + "from": { + "path": "docs/plans/2026-10-20_tester-thread-follow-ups.md", + "anchor": "Brief: a tester message reaches only a tester-owned thread (N1)", + "blob": "2c2227d82b7b4100b6a025f23c50d1a62f0b8197" + }, + "to": { + "path": "docs/plans/2026-10-20_tester-thread-follow-ups.md", + "anchor": "Brief: a tester message reaches only a tester-owned thread (N1)", + "blob": "3459e01c3358014efb861dca78d469cce6da6afe" + }, + "receipt": "ok sage-182-brief-repin rev 2137 row 182 brief: docs/plans/2026-10-20_tester-thread-follow-ups.md § Brief: a tester message reaches only a tester-owned thread (N1) @2c2227d82b7b→docs/plans/2026-10-20_tester-thread-follow-ups.md § Brief: a tester message reaches only a tester-owned thread (N1) @3459e01c3358" + }, + "viewSha": "5fe4a3522ff9b2bc8c80a3746bcf8280a326bdba51f3886e13df56161eec6e2b" + }, + { + "rev": 2138, + "op": "sage-183-brief-repin", + "verb": "set", + "args": { + "id": 183, + "field": "brief", + "value": "docs/plans/2026-10-20_tester-thread-follow-ups.md#Brief: chat.mjs names the transport it is given (N2)", + "reason": null + }, + "by": "sage", + "at": "2026-10-20T04:26:42.794Z", + "semantics": 2, + "result": { + "row": 183, + "field": "brief", + "from": { + "path": "docs/plans/2026-10-20_tester-thread-follow-ups.md", + "anchor": "Brief: chat.mjs names the transport it is given (N2)", + "blob": "2c2227d82b7b4100b6a025f23c50d1a62f0b8197" + }, + "to": { + "path": "docs/plans/2026-10-20_tester-thread-follow-ups.md", + "anchor": "Brief: chat.mjs names the transport it is given (N2)", + "blob": "3459e01c3358014efb861dca78d469cce6da6afe" + }, + "receipt": "ok sage-183-brief-repin rev 2138 row 183 brief: docs/plans/2026-10-20_tester-thread-follow-ups.md § Brief: chat.mjs names the transport it is given (N2) @2c2227d82b7b→docs/plans/2026-10-20_tester-thread-follow-ups.md § Brief: chat.mjs names the transport it is given (N2) @3459e01c3358" + }, + "viewSha": "039387c8dbdcb7491c7ca1fbd93ac3f3f68e59bde38e8b13364fbece6d08573e" + }, + { + "rev": 2139, + "op": "sage-184-brief-repin", + "verb": "set", + "args": { + "id": 184, + "field": "brief", + "value": "docs/plans/2026-10-20_tester-thread-follow-ups.md#Brief: tester thread verbs in the CLI", + "reason": null + }, + "by": "sage", + "at": "2026-10-20T04:26:58.077Z", + "semantics": 2, + "result": { + "row": 184, + "field": "brief", + "from": { + "path": "docs/plans/2026-10-20_tester-thread-follow-ups.md", + "anchor": "Brief: tester thread verbs in the CLI", + "blob": "2c2227d82b7b4100b6a025f23c50d1a62f0b8197" + }, + "to": { + "path": "docs/plans/2026-10-20_tester-thread-follow-ups.md", + "anchor": "Brief: tester thread verbs in the CLI", + "blob": "3459e01c3358014efb861dca78d469cce6da6afe" + }, + "receipt": "ok sage-184-brief-repin rev 2139 row 184 brief: docs/plans/2026-10-20_tester-thread-follow-ups.md § Brief: tester thread verbs in the CLI @2c2227d82b7b→docs/plans/2026-10-20_tester-thread-follow-ups.md § Brief: tester thread verbs in the CLI @3459e01c3358" + }, + "viewSha": "6a1900a04587053f8cc26c098c8afd4981846f224af9c72febd47a8269147252" + }, + { + "rev": 2140, + "op": "sage-183-reviewers", + "verb": "set", + "args": { + "id": 183, + "field": "reviewers", + "value": [ + "dewey" + ], + "reason": null + }, + "by": "sage", + "at": "2026-10-20T04:27:13.862Z", + "semantics": 2, + "result": { + "row": 183, + "field": "reviewers", + "from": [], + "to": [ + "dewey" + ], + "receipt": "ok sage-183-reviewers rev 2140 row 183 reviewers: none→dewey" + }, + "viewSha": "14a8e17350865d826a0fac22b813251c5dabad0e56a38bd5f665ea754de36b84" + }, + { + "rev": 2141, + "op": "sage-183-assign", + "verb": "assign", + "args": { + "id": 183, + "seat": "researcher" + }, + "by": "sage", + "at": "2026-10-20T04:27:29.387Z", + "semantics": 2, + "result": { + "row": 183, + "field": "owner", + "from": "sage", + "to": "researcher", + "receipt": "ok sage-183-assign rev 2141 row 183 owner: sage→researcher" + }, + "viewSha": "7b4d3257133e9320153f1219c46c66e7b9d58dd9db562f62f52bf8a34f54b345" + }, + { + "rev": 2142, + "op": "sage-183-briefed", + "verb": "move", + "args": { + "id": 183, + "to": "briefed", + "reason": null, + "candidate": null, + "evidence": null, + "issue": null + }, + "by": "sage", + "at": "2026-10-20T04:27:45.360Z", + "semantics": 2, + "result": { + "row": 183, + "from": "queued", + "to": "briefed", + "round": null, + "issue": null, + "candidate": null, + "receipt": "ok sage-183-briefed rev 2142 row 183 queued→briefed" + }, + "viewSha": "9133129b612d93cfe486dcf889bc5e36ff8dfa14ecb74aa5647d35605c54da86" + }, + { + "rev": 2143, + "op": "researcher-183-start-1", + "verb": "move", + "args": { + "id": 183, + "to": "in-progress", + "reason": null, + "candidate": null, + "evidence": null, + "issue": null + }, + "by": "researcher", + "at": "2026-10-20T04:29:26.889Z", + "semantics": 2, + "result": { + "row": 183, + "from": "briefed", + "to": "in-progress", + "round": null, + "issue": null, + "candidate": null, + "receipt": "ok researcher-183-start-1 rev 2143 row 183 briefed→in-progress" + }, + "viewSha": "392f8dd5fddaa934493bae830be55ee366314d989ff6a87a849764083668c834" } ] }